Better handling of version when inside git repo #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not indiscriminately go up in search for .git, otherwise people get strange gap versions if they build the tarball somewhere in a git tree.
vbraun
changed the title
olexandr-konovalov
added
the
gapsagedays2016
|
This patch seems good to me. The extra printing only happens when we have already got inconsistent library & kernel. |
|
Thanks! @markuspf, are you happy to merge this (it was you who created |
markuspf
added a commit
that referenced
this pull request
Feb 6, 2016
Better handling of version when inside git repo
| GAP_BUILD_VERSION=`git describe --tags --dirty || echo` | ||
| GAP_BUILD_DATE=`date +"%Y-%m-%d %H:%M:%S (%Z)"` | ||
| if test x"${GAP_BUILD_VERSION}" = x ; then | ||
| if test -d ../.git ; then |
There was a problem hiding this comment.
This test is wrong. The path ../.git is taken relative to the to current working directory (cwd / pwd), not relative to the script. But the script is invoked from the Makefile, which is in the GAP root directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for building the gap tarball inside a git repo (as is the case in Sage)