Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an unexpected error when computing conjugacy classes in certain large permutation groups (and other improvements) #4875

Merged
merged 5 commits into from
Apr 21, 2022
Merged

Fix an unexpected error when computing conjugacy classes in certain large permutation groups (and other improvements) #4875

merged 5 commits into from
Apr 21, 2022

Conversation

hulpke
Copy link
Contributor

@hulpke hulpke commented Apr 20, 2022

New features:

Text for release notes

An issue leading to an error message when computing conjugacy classes in large permutation groups has been fixed.

@hulpke
ENHANCE: ctblgrp clean out spaces in own routine
6838557 
And small changes in info messages
@hulpke hulpke added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes priority: high labels Apr 20, 2022
fingolfin
fingolfin reviewed Apr 20, 2022
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, very nice!

Just a minor remark: one commit introduces some new code that uses tabs for indentation while the surrounding code uses spaces, which results in hard to read code if one does not use the "correct" tab settings...

lib/ctblfuns.gi Outdated Show resolved Hide resolved
lib/ctblfuns.gi Outdated Show resolved Hide resolved
lib/ctblfuns.gi Outdated Show resolved Hide resolved
@hulpke
FIX: ConjugacyClasses in Fitting free
975d07a 
The series used must go through the socle, otherwise abelian factors can end
up forgotten.
This fixes gap-system#4866
fingolfin
fingolfin approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fingolfin fingolfin merged commit d4f2222 into gap-system:master Apr 21, 2022
@hulpke hulpke assigned hulpke and unassigned hulpke Apr 21, 2022
@fingolfin fingolfin changed the title Collected Additions Fix an unexpected error when computing conjugacy classes in certain large permutation groups Aug 17, 2022
@fingolfin fingolfin added release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes and removed kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Aug 17, 2022
@fingolfin fingolfin changed the title Fix an unexpected error when computing conjugacy classes in certain large permutation groups Fix an unexpected error when computing conjugacy classes in certain large permutation groups (and other improvements) Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them priority: high release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hulpke @fingolfin