Skip to content

Commit

Permalink
FIX: ConjugacyClasses in Fitting free
Browse files Browse the repository at this point in the history
The series used must go through the socle, otherwise abelian factors can end
up forgotten.
This fixes #4866
  • Loading branch information
hulpke committed Apr 20, 2022
1 parent dee8a02 commit 137566b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 4 deletions.
8 changes: 4 additions & 4 deletions lib/clashom.gi
Original file line number Diff line number Diff line change
Expand Up @@ -1130,7 +1130,7 @@ local cs, # chief series of G
# we will give classes always by their representatives in G and
# centralizers by their full preimages in G.

cs:= ChiefSeriesOfGroup( G );
cs:= ChiefSeriesThrough( G,[Socle(G)] );

# the first step is always simple
if HasAbelianFactorGroup(G,cs[2]) then
Expand Down Expand Up @@ -1719,8 +1719,6 @@ BindGlobal("LiftClassesEANonsolvGeneral",

# Construct matrices for the affine operation on $N/[h,N]$.
Info(InfoHomClass,4,"space=",Size(field),"^",r);
if Size(field)^r>3*10^8 then Error("too large");fi;
aff := ExtendedVectors( field ^ r );

gens:=Concatenation(cl[2],Npcgs,cl[3]); # all generators
gpsz:=cl[5];
Expand All @@ -1745,7 +1743,9 @@ BindGlobal("LiftClassesEANonsolvGeneral",
Add( imgs, M );
od;

#if Size(field)^r>10^7 then Error("BIG");fi;

if Size(field)^r>3*10^8 then Error("too large");fi;
aff := ExtendedVectors( field ^ r );

# now compute orbits, being careful to get stabilizers in steps
#orbreps:=[];
Expand Down
7 changes: 7 additions & 0 deletions tst/testbugfix/2022-04-19-conjcl.tst
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# ConjugacyClasses, #4866
gap> g:=Group((9,11)(12,14)(15,17)(18,20)(21,23)(24,26)(27,29)(30,32)(33,35)
> (36,38),(9,39)(11,40)(13,42)(15,44)(17,45)(19,46)(21,47)(23,49)(25,51)
> (27,52)(29,53)(31,54)(33,56)(35,58)(37,59), (7,8)(10,11)(15,16)(20,21)
> (25,26)(30,31)(35,36)(40,41)(43,44)(47,48)(50,51)(54,55)(57,58));;
gap> Length(ConjugacyClasses(G));
1308

0 comments on commit 137566b

Please sign in to comment.