Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document TensorProduct, ExteriorPower and SymmetricPower (they existed since at least GAP 4.4) #4339

Conversation

fingolfin
Copy link
Member

This is triggered by a discussion with @AnnaKDS and @wucas.

They've been around for many years but undocumented; people still use them. I see no harm in documenting them.

Related: issue #1362 which discusses a SymmetricPower method for matrices, which perhaps also should be documented? And related to that (as well as TensorProduct) there is KroneckerProduct, which already is in the manual -- but perhaps there should be references between those?

In the same issue, problems with these over finite fields are mentioned. Perhaps those should be investigated and fixed.

Finally, some tests in the test suite for these would be nice.

@fingolfin fingolfin added topic: documentation Issues and PRs related to documentation do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) labels Mar 24, 2021
@fingolfin fingolfin requested review from wucas and AnnaKDS March 24, 2021 23:28
@fingolfin fingolfin force-pushed the mh/doc-TensorProduct-ExteriorPower-SymmetricPower branch from 82d1536 to b1442d7 Compare August 3, 2022 12:59
@fingolfin fingolfin changed the title Document TensorProduct/ExteriorPower/SymmetricPower (WIP) Document TensorProduct/ExteriorPower/SymmetricPower Aug 3, 2022
@fingolfin fingolfin added release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes and removed do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) labels Aug 3, 2022
@fingolfin fingolfin changed the title Document TensorProduct/ExteriorPower/SymmetricPower Document TensorProduct, ExteriorPower and SymmetricPower (they existed since at least GAP 4.4) Aug 3, 2022
@fingolfin fingolfin marked this pull request as ready for review August 3, 2022 13:09
@fingolfin fingolfin merged commit f0b3d55 into gap-system:master Aug 3, 2022
@fingolfin fingolfin deleted the mh/doc-TensorProduct-ExteriorPower-SymmetricPower branch August 3, 2022 20:29
Copy link

@pedritomelenas pedritomelenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine.

ThomasBreuer added a commit to ThomasBreuer/gap that referenced this pull request Sep 7, 2022
…racters

This was suggested by Gabi Nebe.

Note that just a few weeks ago, these functions became documented
for vector spaces (see gap-system#4339).
ThomasBreuer added a commit to ThomasBreuer/gap that referenced this pull request Sep 8, 2022
…racters

This was suggested by Gabi Nebe.

Note that just a few weeks ago, these functions became documented
for vector spaces (see gap-system#4339).
fingolfin pushed a commit that referenced this pull request Sep 9, 2022
…racters

This was suggested by Gabi Nebe.

Note that just a few weeks ago, these functions became documented
for vector spaces (see #4339).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: documentation Issues and PRs related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants