Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected error when testing permutation groups for conjugacy #3747

Merged
merged 3 commits into from
Nov 20, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 24 additions & 20 deletions lib/stbcbckt.gi
Original file line number Diff line number Diff line change
Expand Up @@ -692,26 +692,30 @@ local dom, # operation domain for the group

# Map the suborbit <sub> with each old representative.
for o in old do
if subs.reps[ o ] = true then
subs.reps[ o ] := InverseRepresentative( subs.stabChainTop,
SuboTruePos(ran, subs.blists[ o ] ) ) ^ -1;
fi;
for img in OnTuples( sub, subs.reps[ o ] ) do

# Find the suborbit <i> of the image.
i := subs.which[ img ];

# If this suborbit is encountered for the first time, add
# it to <new> and store its distance <len>.
if key[ i ] = 0 then
Add( new, i );
key[ i ] := len;
fi;

# Store the arrow which starts at suborbit <o>.
key[ o ] := key[ o ] + d *
Length( sub ) ^ ( key[ i ] mod d );
od;
if subs.reps[o]<>false then
if subs.reps[ o ] = true then
subs.reps[ o ] := InverseRepresentative( subs.stabChainTop,
SuboTruePos(ran, subs.blists[ o ] ) ) ^ -1;
fi;
for img in OnTuples( sub, subs.reps[ o ] ) do

# Find the suborbit <i> of the image.
i := subs.which[ img ];

# If this suborbit is encountered for the first time, add
# it to <new> and store its distance <len>.
if key[ i ] = 0 then
Add( new, i );
key[ i ] := len;
fi;

# Store the arrow which starts at suborbit <o>.
key[ o ] := key[ o ] + d *
Length( sub ) ^ ( key[ i ] mod d );
od;
else
Info(InfoWarning,1,"suborbits variant triggered, check!");
fi;
od;
od;

Expand Down
Loading