-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unexpected error when testing permutation groups for conjugacy #3747
Conversation
This is also my best guess as to how to fix this too (and I'm also unsure) |
Thank you! |
Should this be backported? Normally I'd say "no, to risky, let's first test it for a while in |
@fingolfin I thus think it is safe to not backport it -- we can always issue a fix later. |
This is a work-around for the problem encountered in #3446, that is the code accessing
subs.reps[o]
is not executed, if it is not in the expected form (true
or a list).In the cases I encountered this resolves the error (and leads to a correct result).
I however do not understand the code (and parameters) well enough to assure that this is simply an omission in the original code, and not a reflection of a deeper problem. Thge code thus issues a warning, if this happens.
I have been running my own calculations with this modification for half a year now and did not encounter any problems, I thus want to offer it to the general system.
Resolves #3446