Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep the ordering of characters/classes #3581

Merged
merged 2 commits into from
Jul 18, 2019
Merged

keep the ordering of characters/classes #3581

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96d7671
keep the ordering of characters/classes
ThomasBreuer Jul 17, 2019
c149620
added a test that documents the changed behaviour
ThomasBreuer Jul 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions lib/ctbl.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5997,7 +5997,7 @@ InstallOtherMethod( CharacterTableIsoclinic,
"for an ordinary character table and two lists of class positions",
[ IsOrdinaryTable, IsObject, IsObject ],
function( tbl, nsg, center )
local size, classes, r;
local size, classes, orders, max, r;

size:= Size( tbl );
classes:= SizesConjugacyClasses( tbl );
Expand All @@ -6011,9 +6011,9 @@ InstallOtherMethod( CharacterTableIsoclinic,

if IsList( center ) then
# find an element of largest order
center:= ShallowCopy( center );
SortParallel( OrdersClassRepresentatives( tbl ){ center }, center );
center:= center[ Length( center ) ];
orders:= OrdersClassRepresentatives( tbl );
max:= Maximum( orders{ center } );
center:= First( center, i -> orders[i] = max );
fi;

r:= rec();
Expand Down Expand Up @@ -6354,9 +6354,12 @@ InstallMethod( CharacterTableIsoclinic,
irreducibles:= List( Irr( modtbl ), ValuesOfClassFunction );
else
factorfusion:= GetFusionMap( reg, ordiso );
xpos:= source.centralElement;
xpos:= Position( factorfusion, source.centralElement );
centre:= [ xpos ];
outer:= source.outerClasses;
outer:= List( source.outerClasses,
l -> Filtered( List( l,
i -> Position( factorfusion, i ) ),
IsInt ) );
irreducibles:= IrreducibleCharactersOfIsoclinicGroup( Irr( modtbl ),
centre, outer, xpos, source.p, source.k ).all;
fi;
Expand Down