keep the ordering of characters/classes #3581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes from pull request gap-system#3253 had the effect that the orderings of characters and classes in the result of `CharacterTableIsoclinic` were different from those in released versions of GAP. With the current change, we return to the previous orderings.
ThomasBreuer
added
regression
fingolfin
reviewed
Jul 17, 2019
Codecov Report
@@ Coverage Diff @@
## master #3581 +/- ##
==========================================
- Coverage 84.46% 84.34% -0.13%
==========================================
Files 696 696
Lines 345127 345130 +3
==========================================
- Hits 291497 291085 -412
- Misses 53630 54045 +415
|
hulpke
approved these changes
Jul 17, 2019
(The idea of the change is to guarantee a particular ordering of conjugacy classes, I have no idea how to express this without referring to a given class ordering, that is, referring to some library character table.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes from pull request #3253 had the effect that the orderings
of characters and classes in the result of
CharacterTableIsoclinicwere different from those in released versions of GAP.
With the current change, we return to the previous orderings.