Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated version of PR #2035 #2253

Merged
merged 6 commits into from
Mar 8, 2018
Merged

Updated version of PR #2035 #2253

merged 6 commits into from
Mar 8, 2018

Commits on Mar 7, 2018

  1. FIX/ENHANCE: Performance and memory for ImageKernelBlockHomomorphism. 

    The old code added every generator found with
`AddGeneratorsExtendSchreierTree'. This caused the storage of lots of
generators and subsequent memory issues.

Also, if there are few large blocks, Butler's block homomorphism code is
inefficient and it needs to run through all points in one block. In this
case an ordinary orbit calculation is far more efficient.

Together these issues did cause severe problems in large degrees with few
blocks (observed by Thomas).

It it possible that it also rectifies some of the observed problems in
larger degree.

What one could still do is to use random subproducts instead of testing all
Schreier generators, but this is not the right time to do so.
    @hulpke @fingolfin
    hulpke authored and fingolfin committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    1c4ac1b View commit details
    Browse the repository at this point in the history

  2. Replaced tabs with blanks to avoid indentation issues.

    @hulpke @fingolfin
    hulpke authored and fingolfin committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    3217433 View commit details
    Browse the repository at this point in the history

  3. Added test file

    @hulpke @fingolfin
    hulpke authored and fingolfin committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    ecaa208 View commit details
    Browse the repository at this point in the history

  4. DOC: ClassesSolvableGroup requires, but does not test membership. 

    This resolves gap-system#2055
    @hulpke @fingolfin
    hulpke authored and fingolfin committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    df1cbfb View commit details
    Browse the repository at this point in the history

  5. FIX: Enforce that Natural(G/S)L test creates module with generators. 

    This fixes gap-system#2104
    @hulpke @fingolfin
    hulpke authored and fingolfin committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    22c725c View commit details
    Browse the repository at this point in the history

  6. ENHANCE: Added LowIndexSubgroups to ref manual 

    as requested in gap-system#2131

Also added `LowLayerSubgroups` and minor rephrasing.

Also redid part of gap-system#683, as for some reason (probably my stupidity)
part of gap-system#683 had fallen out of master. Added it again.
    @hulpke @fingolfin
    hulpke authored and fingolfin committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    bcf12d7 View commit details
    Browse the repository at this point in the history