Updated version of PR #2035 #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old code added every generator found with `AddGeneratorsExtendSchreierTree'. This caused the storage of lots of generators and subsequent memory issues. Also, if there are few large blocks, Butler's block homomorphism code is inefficient and it needs to run through all points in one block. In this case an ordinary orbit calculation is far more efficient. Together these issues did cause severe problems in large degrees with few blocks (observed by Thomas). It it possible that it also rectifies some of the observed problems in larger degree. What one could still do is to use random subproducts instead of testing all Schreier generators, but this is not the right time to do so.
as requested in gap-system#2131 Also added `LowLayerSubgroups` and minor rephrasing. Also redid part of gap-system#683, as for some reason (probably my stupidity) part of gap-system#683 had fallen out of master. Added it again.
fingolfin
added
kind: bug
Codecov Report
@@ Coverage Diff @@
## stable-4.9 #2253 +/- ##
==============================================
+ Coverage 69.24% 69.28% +0.03%
==============================================
Files 493 493
Lines 260080 260120 +40
==============================================
+ Hits 180102 180214 +112
+ Misses 79978 79906 -72
|
fingolfin
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports some fixes from master to stable-4.9
Let's wait till the tests complete, then e.g. @hulpke can merge this.