Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problems with MTX.SubGModule #5476

Open
ThomasBreuer opened this issue Jul 24, 2023 · 1 comment
Open

problems with MTX.SubGModule #5476

ThomasBreuer opened this issue Jul 24, 2023 · 1 comment

Comments

@ThomasBreuer
Copy link
Contributor

The following problems are present in GAP 4.12 and in the GAP master branch.
They have been observed by @fieker.

gap> G:= SymmetricGroup(3);;
gap> M:= PermutationGModule( G, GF(2) );;
gap> mat:= [ [ 1, 1, 1 ], [ 0, 1, 1 ] ] * Z(2);;
gap> orig:= StructuralCopy( mat );;
gap> MTX.SubGModule( M, mat );;
gap> mat = orig;    # the function call changes the 2nd argument
false
gap> MTX.SubGModule( M, Immutable( orig ) );;    # the 2nd argument must be mutable
Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `TriangulizeMat' on 1 arguments at [...]

I think that MTX.SubGModule is not allowed to change its 2nd argument,
and that also an immutable 2nd argument should be allowed.

The easiest solution would be to call TriangulizedMat instead of TriangulizeMat.

@ThomasBreuer
Copy link
Contributor Author

Pull request #5477 fixes just the reported problem.
It would be good to check that all (documented) MTX functions have the property that either they do not change their arguments or their documentation states that arguments may be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant