fix a mutation/mutability problem in MTX.SubGModule

addresses gap-system#5476
ThomasBreuer · Jul 25, 2023 · b1c83fa · b1c83fa
1 parent aafd490
commit b1c83fa
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/lib/meataxe.gi b/lib/meataxe.gi
@@ -396,7 +396,7 @@ SMTX.SpinnedBasis:=function( arg  )
    if IsList(v) and Length(v)=0 then
      return [];
    elif IsMatrix(v) then
-     TriangulizeMat(v);
+     v:= TriangulizedMat(v);
      ans:=Filtered(v,x->not IsZero(x));
    elif IsList(v) and IsVectorObj(v[1]) then
      v:=TriangulizedMat(Matrix(F,v));

diff --git a/tst/testinstall/meataxe.tst b/tst/testinstall/meataxe.tst
@@ -1,4 +1,4 @@
-#@local G,M,M2,M3,M4,M5,V,bf,bo,cf,homs,m,mat,qf,randM,res,sf,subs,mats,Q
+#@local G,M,M2,M3,M4,M5,V,bf,bo,cf,homs,m,mat,qf,randM,res,sf,subs,mats,Q,orig,S
 gap> START_TEST("meataxe.tst");
 
 #
@@ -184,6 +184,16 @@ gap> Display(res[5]);
  . . . . 1 .
  . . . . . 1
 
+#
+gap> G:= SymmetricGroup(3);;
+gap> M:= PermutationGModule( G, GF(2) );;
+gap> mat:= [ [ 1, 1, 1 ], [ 0, 1, 1 ] ] * Z(2);;
+gap> orig:= StructuralCopy( mat );;
+gap> S:= MTX.SubGModule( M, mat );;
+gap> mat = orig;    # the function call must not change the 2nd argument
+true
+gap> S = MTX.SubGModule( M, Immutable( orig ) );; # 2nd argument may be immutable
+
 #
 # Tests for MTX.InvariantQuadraticForm and MTX.OrthogonalSign
 # (the documentation is a bit unorthodox)
@@ -231,8 +241,8 @@ gap> Q:= MTX.InvariantQuadraticForm( m );
 fail
 gap> MTX.OrthogonalSign( m );
 fail
-gap> g:= SU(4, 3);;
-gap> m:= GModuleByMats( GeneratorsOfGroup( g ), GF(9) );;
+gap> G:= SU(4, 3);;
+gap> m:= GModuleByMats( GeneratorsOfGroup( G ), GF(9) );;
 gap> MTX.InvariantBilinearForm( m );
 fail
 gap> MTX.InvariantQuadraticForm( m );