Build the nq package for Travis tests #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 26, 2020
|
Unfortunately this breaks code coverage, because io and profiling don't get compiled anymore. But no worries, I'll submit a PR to fix it; I just wanted to mention that this is something to look out for (I guess we could / should also try to improve the scripts to automatically add these to |
|
Whoops, thank you for letting me know @fingolfin, that's good to know. Thanks for offering to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Travis tests currently fail - as it is, the
XModAlgpackage cannot even load, because thenqexecutable is not available.This resolves the problem.