Accommodate correctly pluralized ViewStrings in GAP #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
=======================================
Coverage 78.62% 78.62%
=======================================
Files 39 39
Lines 13851 13851
=======================================
Hits 10890 10890
Misses 2961 2961 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note: this is very similar to the PR I made for the package
XModAlg.)In a future version of GAP, some nouns will be correctly pluralised to match their number. For example, the
ViewStringin GAP forCyclicGroup(3);is currently<pc group of size 3 with 1 generators>, whereas it will soon correctly show<pc group of size 3 with 1 generator>.The changes in this PR maintain the backwards compatibility of this package with GAP, and it ensures that the upcoming changes to GAP on this topic do not affect the package either.
See gap-system/gap#3992 and gap-system/gap#4050 for more context.