Fix failing to send data to Garmin devices #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although a previous change fixed how we receive data from devices that split their header and data, the MTP spec indicates that the initiator *also* needs to switch into that mode when sending. This patch sets the SeparateHeader flag if we suspect that the device is communicating in split header/data mode.
Noticed this while testing - probably unnecessarily verbose otherwise. :)
|
I have merged your pr and the test cases seems to be working fine. The mtp device does in fact go crazy after running the whole bunch of test cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix made in PR #1 wasn't the complete fix for devices that support split header/payload functionality, like Garmin devices. It turns out that once either side has switched to that "separate" mode, both sides need to communicate in that format:
To that end, this patch turns on
d.SeparateHeadermode (which apparently is already implemented but was unused?) if we think that the device might be in that mode.In theory ganeshrvel/openmtp#153 should be fixed but despite being able to get go-mtpfs working:
And go-mtpx unit tests mostly passing (the watch seems to get into a bad state at one point near the end of the tests and doesn't reconnect):
I haven't been able to get OpenMTP to list files out yet. 😞