Fix two issues preventing Garmin devices working #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All three device descriptor strings are technically optional. Rather than returning an error when one is empty, continue to iterate through the rest.
When dealing with a separate header and payload, make sure that we do not expect to receive additional USB packet headers in the payload portion of the transfer. Previously, we were assuming that this would only occur when the device was sending more than a full packet's worth of data, but this is not correct - we should continue the bulk transfer any time the device sends us less data than the header says it will be sending.
|
Awesome, Thanks for putting the effort. I am in middle of adding apple silicone support. I will run the tests on my devices and will approve this pr. Thanks again. |
|
Thank you for the PRs. Merged them. Shall be releasing a beta release of OpenMTP tonight |
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of implementation issues preventing Garmin devices working correctly with OpenMTP (ganeshrvel/openmtp#153).
First, Garmin devices don't typically populate all three device descriptors - usually only the SerialNumber string is available. Previously, we would fail early if any string was unavailable.
Second, Garmin devices separate the header from payload during the data phase. It seems like we previously assumed that if that were the case then the packet would be full, but that's not necessarily true. I've added a check so if we read less than the size the device has said it's going to send, that will also trigger a bulk read of the payload.
Note:
This code was committed on a different computer than was developed, so it probably needs secondary verification. Also, I'm not a Go developer so this may need formatting/rewriting to conform to Go standards.