Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colabfold #5785

Merged
merged 33 commits into from
Mar 24, 2024
Merged

Add colabfold #5785

merged 33 commits into from
Mar 24, 2024

Conversation

astrovsky01
Copy link
Contributor

Adds colabfold tool. Testing output requires data caches, so the tests here just check for command line content
FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

astrovsky01 and others added 2 commits February 21, 2024 09:58
Co-authored-by: Wolfgang Maier <maierw@posteo.de>
@bernt-matthias
Copy link
Contributor

Just stumbled over https://academic.oup.com/bioinformatics/article/39/1/btac749/6839971 .. wondering if the collabfold output could be used for this as is.

@astrovsky01
Copy link
Contributor Author

@bernt-matthias That's using a different part of colabfold than we use here, specifically Search instead of Batch. Part of why I made it a suite is that there will be different future versions of the tool depending on where it's being run, and that is one of them. If that is made into a tool, the output should be useable, though, from what I understand

@astrovsky01
Copy link
Contributor Author

astrovsky01 commented Mar 11, 2024

Also, the shed error that's happening here is not occurring locally, and I'm unsure how to fix.
The other error is the lack of datatype, which should have been taken care of in the above datatype PR...

@astrovsky01
Copy link
Contributor Author

Current failure is on the msa step is due to a new param I added to standardize naming. Easily fixed, but requires minor testing first

…t history names, modify help text, put params into advanced section
@astrovsky01
Copy link
Contributor Author

astrovsky01 commented Mar 15, 2024

@bernt-matthias The fail for the msa step is the same error as it was before where it doesn't see that new datatype, but I can't even tell what's going wrong with the alphafold step, it looks like it's just shutting down immediately?

@bernt-matthias
Copy link
Contributor

Do you know how much memory is used in the msa step test?

@astrovsky01
Copy link
Contributor Author

astrovsky01 commented Mar 15, 2024

It was only allocated 2.7GB on test, but we're not sure how much of that is actually used

@astrovsky01
Copy link
Contributor Author

@bernt-matthias @bgruening the most I have found that gives a hint is Tool colabfold_alphafold created job None (16.176 ms) in the test log

@astrovsky01
Copy link
Contributor Author

astrovsky01 commented Mar 20, 2024

Woo passing! Before any merge, though, I wanted to ask for clarification about the expect_failure. Does that still test the command line against the assert_command I have, or is it just expecting a non-zero error code? I can't tell based on other tools in iuc that have been published

@astrovsky01
Copy link
Contributor Author

@bernt-matthias @bgruening intentionally breaking the command assertion failed, which means the test is doing what I thought it was, and the tool is ready

@bernt-matthias
Copy link
Contributor

intentionally breaking the command assertion failed

Thanks for testing this. Can you test for the exit code?

@astrovsky01
Copy link
Contributor Author

Thanks for testing this. Can you test for the exit code?

It's failing with exit code 1, which is what the test is specifying, but the test itself is still failing despite that

@astrovsky01
Copy link
Contributor Author

The linter will not allow both expect_num_outputs and expect_fail, so this is what I can do with the test

Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it one last round. Sorry.

@bernt-matthias
Copy link
Contributor

Thanks for the efforts

@bernt-matthias
Copy link
Contributor

Anything left from your side @bgruening?

@bgruening bgruening merged commit a95dcf3 into galaxyproject:main Mar 24, 2024
12 checks passed
@gxydevbot
Copy link
Collaborator

Attention: deployment failure!

https://github.com/galaxyproject/tools-iuc/actions/runs/8412373924

1 similar comment
@gxydevbot
Copy link
Collaborator

Attention: deployment failure!

https://github.com/galaxyproject/tools-iuc/actions/runs/8412373924

@bernt-matthias
Copy link
Contributor

We have this one again:

Unexpected HTTP status code: 500: {"err_msg": "Metadata may have been defined for some items in revision '66cd8f416122'.  Correct the following problems if necessary and reset metadata.<br/><b>colabfold_alphafold.xml<\/b> - parameter 'num_models': the attribute 'value' must be set for non optional parameters<br/>"}

we had this on matrix recently, but forgot the conclusion...

@bernt-matthias
Copy link
Contributor

Should actually be allowed galaxyproject/galaxy#16966 ..

@bernt-matthias
Copy link
Contributor

Quick fix is to set value="".

@astrovsky01
Copy link
Contributor Author

I set it to optional here #5908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants