-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add colabfold #5785
Add colabfold #5785
Conversation
Co-authored-by: Wolfgang Maier <maierw@posteo.de>
Just stumbled over https://academic.oup.com/bioinformatics/article/39/1/btac749/6839971 .. wondering if the collabfold output could be used for this as is. |
@bernt-matthias That's using a different part of colabfold than we use here, specifically Search instead of Batch. Part of why I made it a suite is that there will be different future versions of the tool depending on where it's being run, and that is one of them. If that is made into a tool, the output should be useable, though, from what I understand |
Also, the shed error that's happening here is not occurring locally, and I'm unsure how to fix. |
…problems, update docker image version
Current failure is on the msa step is due to a new param I added to standardize naming. Easily fixed, but requires minor testing first |
…t history names, modify help text, put params into advanced section
@bernt-matthias The fail for the msa step is the same error as it was before where it doesn't see that new datatype, but I can't even tell what's going wrong with the alphafold step, it looks like it's just shutting down immediately? |
Do you know how much memory is used in the msa step test? |
It was only allocated 2.7GB on test, but we're not sure how much of that is actually used |
@bernt-matthias @bgruening the most I have found that gives a hint is |
Woo passing! Before any merge, though, I wanted to ask for clarification about the expect_failure. Does that still test the command line against the assert_command I have, or is it just expecting a non-zero error code? I can't tell based on other tools in iuc that have been published |
@bernt-matthias @bgruening intentionally breaking the command assertion failed, which means the test is doing what I thought it was, and the tool is ready |
Thanks for testing this. Can you test for the exit code? |
It's failing with exit code 1, which is what the test is specifying, but the test itself is still failing despite that |
The linter will not allow both expect_num_outputs and expect_fail, so this is what I can do with the test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave it one last round. Sorry.
Thanks for the efforts |
Anything left from your side @bgruening? |
Attention: deployment failure! https://github.com/galaxyproject/tools-iuc/actions/runs/8412373924 |
1 similar comment
Attention: deployment failure! https://github.com/galaxyproject/tools-iuc/actions/runs/8412373924 |
We have this one again:
we had this on matrix recently, but forgot the conclusion... |
Should actually be allowed galaxyproject/galaxy#16966 .. |
Quick fix is to set |
I set it to optional here #5908 |
Adds colabfold tool. Testing output requires data caches, so the tests here just check for command line content
FOR CONTRIBUTOR: