Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate autoupdate workflow #4832

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bernt-matthias
Copy link
Contributor

Integrate the planemo autoupdate workflow as reusable workflow

  • Its to the largest extend identical to the excellent work of @simonbray at https://github.com/planemo-autoupdate/autoupdate, I only simplified a few bits.
  • Branches will be created locally in the IUC repo (autoupdate/REPOPATH) For people who want to add changes to such a PR might either create a PR targeting the autoupdate/REPOPATH branch?
  • This is also a potential downside of moving the tools, since the bot writes to the repository itself security considerations have to be considered. Since the workflow will have/need write premissions for creating branches
    and PRs we will need to make sure that in particular the main branch is protected and also changes to the workflow will need careful reviews. I also tried (on my fork) to limit the permissions to read for all workflows (in the settings) and raise it to write for the autoudate workflow.
  • The advantage will be that we won't need a wf for each repo at https://github.com/planemo-autoupdate/autoupdate/ and all repos deriving from the template will have autoupdate automatically.
  • Also added a new slash command /run-autoupdate which was quite handy for development
  • PR will have the autoupdate label (which we will need to add)
  • We will need to close / merge old autoupdate PRs manually.
  • I also tried to use an autoupdate mode of the planemo-ci-action (https://github.com/bernt-matthias/planemo-ci-action/tree/topic/autoupdate) which runs on all repos at once in a separate step. But its tricky since its difficult to add commits to an existing branch (which may have additional changes).
  • TODO change git config --global user.email "m.bernt@ufz.de"?

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

@bgruening
Copy link
Member

TODO change git config --global user.email "m.bernt@ufz.de"?

you could use the IUC mailing address if you like

@bernt-matthias
Copy link
Contributor Author

Didn't know that there is a IUC mailing address .. what is it?

@bgruening
Copy link
Member

galaxy-iuc@lists.galaxyproject.org you are not on that list?

@bernt-matthias
Copy link
Contributor Author

galaxy-iuc@lists.galaxyproject.org you are not on that list?

Apparently not :)

@bgruening
Copy link
Member

The ML says your are on it ;)

Please feel free to merge and follow-up.

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not -1 one on this but we will have the same problem as with the other CIs, it is harder to update the bot in decentral repos in contrast to the current central one.

@bernt-matthias
Copy link
Contributor Author

I think this is not a problem, because it's implemented as reusable wf. wf_autoupdate will live only in the IUC repo (which we can update and improve). The repos only get the autoupdate workflow which calls wf_autoupdate at IUC.

Anyway, I would prefer to first get #4830 done in order to see reusable wfs in action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants