Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EMBOSS backtranseq to 6.6.0 #2261

Merged
merged 3 commits into from
Jan 28, 2019
Merged

Update EMBOSS backtranseq to 6.6.0 #2261

merged 3 commits into from
Jan 28, 2019

Conversation

nsoranzo
Copy link
Member

to support multi sequence FASTA. Add test.

Also:

  • Fix old wrong test: previously the input was a DNA sequence instead of a protein
  • Use 4-space indentation
  • Update help

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

@nsoranzo nsoranzo mentioned this pull request Jan 28, 2019
Merged
@nsoranzo
Fix EMBOSS backtranseq test
33ef2a0 
Previously the input was a DNA sequence instead of a protein.
@nsoranzo
Update backtranseq to 6.6.0
11ed47a 
to support multi sequence FASTA. Add test.

Also:
- use 4-space indentation
- Update help
@nsoranzo
Check output format
b2b06f5 
The datatype is updated by `emboss_format_corrector.py` code file,
which is a bit of a dirty hack but I won't touch it at the moment.
@nsoranzo nsoranzo merged commit 431486b into galaxyproject:master Jan 28, 2019
@nsoranzo nsoranzo deleted the emboss_backtranseq branch January 28, 2019 18:59
@innovate-invent
Copy link
Contributor

This should probably be moved with #4347

@innovate-invent innovate-invent mentioned this pull request Feb 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nsoranzo @innovate-invent @mvdbeek