Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Prevent dragover for item from same history in history panel #17761

Conversation

ahmedhamidawan
Copy link
Member

We would allow users to dragover items from the same history over its panel and render the dropzone, this prevents that entirely. Fixes #17743

Before:

dropping_same_history_before.mp4

Now:

dropping_same_history_after.mp4

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

We would allow users to dragover items from the same history over its panel and render the dropzone, this prevents that entirely.
Fixes galaxyproject#17743
@github-actions github-actions bot added this to the 24.1 milestone Mar 15, 2024
@martenson martenson modified the milestones: 24.1, 24.0 Mar 15, 2024
@martenson
Copy link
Member

works well, would you mind incorporating similar fix for the clickable area as in #17621?

@ahmedhamidawan
Copy link
Member Author

works well, would you mind incorporating similar fix for the clickable area as in #17621?

Ah good pick, the content item draggable area needs to be larger as well

@ahmedhamidawan
Copy link
Member Author

@martenson I made the whole ContentItem draggable, I hope this works better?

@martenson
Copy link
Member

yeah, it works great! let's wait for the tests and merge ahead :)

@martenson martenson merged commit 1150fb4 into galaxyproject:release_24.0 Mar 16, 2024
26 of 27 checks passed
@ahmedhamidawan ahmedhamidawan deleted the remove_copy_to_same_history_toast branch March 16, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants