Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Increase ContentItem clickable area #17621

Conversation

ahmedhamidawan
Copy link
Member

@ahmedhamidawan ahmedhamidawan commented Mar 6, 2024

Fixes #17620

Before After
increase_content_item_click_before.mp4
increase_content_item_click_after.mp4

Also adds a minor enhancement where if you might have entered a collection view by clicking or keyboard, when you return to the panel, the collection is focused so that you can continue navigating the history with the arrow keys etc.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

... to indicate what `ContentItem` was clicked last.
@ahmedhamidawan ahmedhamidawan marked this pull request as ready for review March 7, 2024 02:25
@ahmedhamidawan ahmedhamidawan linked an issue Mar 7, 2024 that may be closed by this pull request
Copy link
Member

@martenson martenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better, thank you @ahmedhamidawan

@martenson martenson merged commit a1d3d8a into galaxyproject:release_24.0 Mar 7, 2024
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extend history item selection area
2 participants