Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.0] Fix History filters includes related filter bug #15975

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion client/src/stores/history/historyItemsStore.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ export const useHistoryItemsStore = defineStore("historyItemsStore", {
getHistoryItems: (state) => {
return (historyId, filterText) => {
const itemArray = state.items[historyId] || [];
const filters = HistoryFilters.getFilters(filterText).filter((filter) => !filter.includes("related"));
const filters = HistoryFilters.getFilters(filterText).filter(
(filter) => !filter[0].includes("related")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to merge this with manual verification for the release, but it might be really nice to have store specific tests applying the filtering here if you had time to take a pass at that. I know we have tests for HistoryFilters, so maybe pushing this filter specific logic into there and testing it there makes sense, too?

);
const relatedHid = HistoryFilters.getFilterValue(filterText, "related");
const filtered = itemArray.filter((item) => {
if (!item) {
Expand Down