[23.0] Fix History filters includes related filter bug #15975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itisAliRH
approved these changes
Apr 21, 2023
dannon
reviewed
Apr 24, 2023
| @@ -28,7 +28,9 @@ export const useHistoryItemsStore = defineStore("historyItemsStore", { | |||
| getHistoryItems: (state) => { | |||
| return (historyId, filterText) => { | |||
| const itemArray = state.items[historyId] || []; | |||
| const filters = HistoryFilters.getFilters(filterText).filter((filter) => !filter.includes("related")); | |||
| const filters = HistoryFilters.getFilters(filterText).filter( | |||
| (filter) => !filter[0].includes("related") | |||
There was a problem hiding this comment.
I'm happy to merge this with manual verification for the release, but it might be really nice to have store specific tests applying the filtering here if you had time to take a pass at that. I know we have tests for HistoryFilters, so maybe pushing this filter specific logic into there and testing it there makes sense, too?
dannon
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If some filter other than the related filter was set = "related" (e.g.:
state:related||tag:related), we would remove the filter inhistoryItemsStore.getHistoryItems.How to test the changes?
(Select all options that apply)
License