Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completes docs on using external files #400

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Completes docs on using external files #400

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67f3fc0
Completes docs on using external files
pcm32 Dec 15, 2022
03bf2b7
Uses in-line notation as first option.
pcm32 Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,8 @@ extraFileMappings:
1. Creating a symbolic link in the chart directory to the external file, or
2. using `--set-file` to specify the contents of the file. E.g:
`helm upgrade --install galaxy cloudve/galaxy -n galaxy --set-file extraFileMappings."/galaxy/server/static/welcome\.html".content=/home/user/data/welcome.html`

Loading the files from external locations still requires a minimal entry in the `extraFileMappings` for that file, as shown above but with no `content:` part. Otherwise, the setup doesn't know on which pods to apply this.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add those as extra set properties, to be more inline with this particular example?

extraFileMappings."/galaxy/server/static/welcome\.html".applyToWeb=true

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh, cool, how come I didn't thought of that. Sure, will do.


## Setting parameters on the command line

Expand Down