Completes docs on using external files #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuwang
reviewed
Dec 15, 2022
README.md
Outdated
| @@ -261,6 +261,8 @@ extraFileMappings: | |||
| 1. Creating a symbolic link in the chart directory to the external file, or | |||
| 2. using `--set-file` to specify the contents of the file. E.g: | |||
| `helm upgrade --install galaxy cloudve/galaxy -n galaxy --set-file extraFileMappings."/galaxy/server/static/welcome\.html".content=/home/user/data/welcome.html` | |||
|
|
|||
| Loading the files from external locations still requires a minimal entry in the `extraFileMappings` for that file, as shown above but with no `content:` part. Otherwise, the setup doesn't know on which pods to apply this. | |||
There was a problem hiding this comment.
Can we add those as extra set properties, to be more inline with this particular example?
extraFileMappings."/galaxy/server/static/welcome\.html".applyToWeb=true
There was a problem hiding this comment.
Ahhh, cool, how come I didn't thought of that. Sure, will do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small clarification that when using external files you still need to include some part for them on the extra file mappings of the values.