Skip to content

Commit

Permalink
Merge search to master (amundsen-io#315)
Browse files Browse the repository at this point in the history
* Merge `master` into `feature/search_v2` (amundsen-io#253)

* Clean up doc (amundsen-io#249)

* Remove example folder in FE (amundsen-io#251)

* Add better logging for profile page views (amundsen-io#239)

* Added new search page layout (amundsen-io#250)

* Added SearchPanel to search page, with new wide layout
* Added 'ResourceSelector'

* Add SearchBar to NavBar + update styles (amundsen-io#252)

* Add SearchBar to NavBar + update styles

* Lint fix

* Code cleanup

* Fix tests

* Update ResourceListItem UI (amundsen-io#255)

* WIP

* Update layout

* Some code cleanup

* Tests

* Add some starter doc for the AppConfig

* Code cleanup + update UserListItem description UI

* start icon -> resource icon

* Moved Feedback tool to NavBar (amundsen-io#256)

* Update Feedback Component

* Update tests

* Clean up some styles

* reposition form

* Tweak feedback style

* Initial implementation of SearchFilter (amundsen-io#260)

* Initial implementation of SearchFilter

* Clean some code + add CheckBoxItem tests

* Fixed warning on ResourceSelector

* Add/fix some more tests

* Some tweaks before merge

* Implement New color theme (amundsen-io#276)

* Added a color palette file
* Replaced $gray-light/dark colors with semantic variables for each purpose
* Update brand colors to indigo

* Merge `master` into  `feature/search_v2` (amundsen-io#286)

* Update searchv2 master (amundsen-io#313)

* Clean up doc (amundsen-io#249)

* Remove example folder in FE (amundsen-io#251)

* Add better logging for profile page views (amundsen-io#239)

* add stalebot config (amundsen-io#264)

* Update stalebot setting (amundsen-io#268)

* Adds the request timeout configuration (amundsen-io#275)

* Adds the request timeout configuration

* Bumps the version to take advantage of request timeout

* Update AxiosError handling (amundsen-io#283)

* Update v0.ts

* lint fix

* Use Redux-Saga for Search Actions (amundsen-io#265)

* Added redux actions and sagas instead for each search action: `submitSearch`, `setResource`, `setPageIndex`, `loadPreviousSearch`, and `UrlDidUpdate`. This greatly simplifies the `SearchPage` logic in preparation for adding filters.
* Added `navigation-utils`.

* Removed `SQUASH COMMITS` from the PR template (amundsen-io#287)

Removed `SQUASH COMMITS` from the PR template

* TagInfo now fires 'submitSearch' instead of using navigation (amundsen-io#285)

* Remove render_template for feedback email (amundsen-io#293)

* Remove render_template for feedback email

* Fix html markup

* Added auto-select resource after searching (amundsen-io#292)

* Truncate the column type (amundsen-io#297)

* Truncate the column type

* Update truncation method

* Cleanup logic

* Improve table & columns description formatting (amundsen-io#98) (amundsen-io#298)

* Add support for React-Markdown to editable text fields
* Add support for windows via cross-env

* Update EditableText component (amundsen-io#299)

* Fix some styling issues with react-markdown
* Update EditableText to use React Refs instead of ref callbacks
* Add configs for table and column description max lengths

* Change 'json' to 'data' field for Python Requests (amundsen-io#303)

* Switch usage of 'json' to 'data' in metadata APIs
* Use 'raw_request=True' for Envoy client post/put APIs

* Update README.md (amundsen-io#302)

* Link deeper to doc content (amundsen-io#304)

Summary of Changes

Will scroll past GitHub repo folders (specially more handy on small screens like phones/tablets)
Like amundsen-io/amundsendatabuilder#147

* Fixed linebreaks with Markdown descriptions (amundsen-io#305)

* Amundsen Notifications Without Preferences (amundsen-io#273)

* Initial start to notifications API (amundsen-io#215)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* addressed comments regarding imports/enum naming

* fixed alphabetical order

* Notifs post email functionality (amundsen-io#222)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* added template support

* made changes to reflect private changes

* added helper function

* fixed lint issue

* addressed comments, added some type checking and cleaned up comments

* testing removing test

* fixed linter

* fixed lint

* fixed linting issues

* skip type checking

* fixed lint

* fixed typing on get request args

* removed typing for get request to fix lint issues

* fixed linter again

* re added test

* raise exception inside of getmailclient

* added exceptions

* addressed comments

* whitespace issue

* removed calls to get_query_param

* fixed syntax error

* Send notification when adding/removing owner from table (amundsen-io#237)

* basic e2e functionality for adding/removing

* send_notification refactor

* fix lint errors

* blank line lint error

* fixed syntax issue

* arg typing

* addressed comments, fixed code style

* Prevent Self-Notifications (amundsen-io#243)

* Prevent user from notifying themselves

* removed exception

* added owner check to send_notification

* Fixed return for no recipients (amundsen-io#244)

* fixed return for no recipients

* fixed linter issue

* Request notifications component (amundsen-io#238)

* init of request form

* basic request component

* getting basic functionality in

* clearing out css

* removed z-index fixes and add constants

* fixed string casting

* added redux-saga calls

* removed reset request notification

* fixed tests

* addressed comments, added basic test, added redux state management for opening/closing component

* added tests, just need to add render test

* cleaned up component tests:

* addressed html/css comments

* removed unecessary styling

* removed collapsed class

* cleaned up render method

* fixed test

* Open request component (amundsen-io#254)

* added button to open up request component

* removed tabledetail changes

* className styling

* fixed text-decoration

* added tests, changed naming for OpenRequest

* styling formatting

* Add, Request, and Remove Email Copy (amundsen-io#257)

* init for fixing email copy for request, add, and remove

* removed print statement

* fixed python unit test

* fixed linter issues

* addressed comments, fixed linter issues

* added notification unit test

* fixed test positional arg

* fix test

* Add notification action logging (amundsen-io#258)

* init of adding action logging

* changed location of action logging

* fixed linter errors

* fixed comment

* addressed comments

* remove request test call (amundsen-io#259)

* hide request if description already exists (amundsen-io#269)

* fixed open request button, request form styling (amundsen-io#267)

* Added request dropdown component (amundsen-io#262)

* init

* made fixes

* cleaned up code

* fixed color issues

* fixed import order

* fixed styling, changed ducks/sagas

* User dropdown (amundsen-io#263)

* init

* fixed sty;es

* fixed test issue

* fixed test

* added tests, addressed comments

* Request Metadata Component Tests (amundsen-io#270)

* added tests + readonly field to stop errors

* fixed tslint

* addressed comments, added header tests

* Request form navigation fix, dropdown fix (amundsen-io#272)

* Request form navigation fix, dropdown fix

* added test

* added unique id to dropdown

* Creates User Preferences page with no functionality (amundsen-io#266)

* init

* added event handlers

* removed test file

* added constants

* addressed comments

* fixed test, removed all links to page

* updated test

* fixed call to onclick

* removed preferences page

* Python cleanup + tests (amundsen-io#277)

* Python cleanup + tests

* More tests + revert some unecessary changes

* Bring dropdown UI closer to design (amundsen-io#278)

* Rename OpenRequestDescription for clarity + code cleanup + test additions (amundsen-io#279)

* Notifications ducks cleanup + tests (amundsen-io#280)

* Notifications ducks cleanup + tests

* Fix issues

* Fix template for edge case of empty form (amundsen-io#281)

* Temporary debugging code, will revert

* Temporary debugging code, will revert

* Implement notification form confirmation (amundsen-io#289)

* Preserve compatibility in base_mail_client (amundsen-io#290)

* Notifications Configs + Doc (amundsen-io#291)

* Add notification config

* Code cleanup

* More cleanup + add a test

* Add some doc for how to enable features

* Add config utils test + fix type error

* Relative URLs to child configuration docs (amundsen-io#294)

* Relative URLs to child configuration docs

Relative URLs to docs in the same folder should do. They work for any branch, local copies of the docs - and should work better if we ever (or whenever :-) we get to having e.g a Sphinx generated site.

* Update application_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Remove temporary debugging code

* Improve behavior of notification sending for owner editing (amundsen-io#296)

* Initial Implementation: Notification only on success

* Cleanup + tests: Notification only on success

* Cleanup: Remove test code to trigger failure

* Cleanup: Lint fix

* Workaround for not notifying teams or alumni

* Cleanup: Remove import mistake

* Utilize NotificationType enums instead of hardcoded string

* Remove use of render_template

* More minor cleanups

* Address some feedback

* Cleanup

* More cleanup

* Notifications Improvements (amundsen-io#301)

* Initial start to notifications API (amundsen-io#215)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* addressed comments regarding imports/enum naming

* fixed alphabetical order

* Notifs post email functionality (amundsen-io#222)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* added template support

* made changes to reflect private changes

* added helper function

* fixed lint issue

* addressed comments, added some type checking and cleaned up comments

* testing removing test

* fixed linter

* fixed lint

* fixed linting issues

* skip type checking

* fixed lint

* fixed typing on get request args

* removed typing for get request to fix lint issues

* fixed linter again

* re added test

* raise exception inside of getmailclient

* added exceptions

* addressed comments

* whitespace issue

* removed calls to get_query_param

* fixed syntax error

* Send notification when adding/removing owner from table (amundsen-io#237)

* basic e2e functionality for adding/removing

* send_notification refactor

* fix lint errors

* blank line lint error

* fixed syntax issue

* arg typing

* addressed comments, fixed code style

* Prevent Self-Notifications (amundsen-io#243)

* Prevent user from notifying themselves

* removed exception

* added owner check to send_notification

* Fixed return for no recipients (amundsen-io#244)

* fixed return for no recipients

* fixed linter issue

* Request notifications component (amundsen-io#238)

* init of request form

* basic request component

* getting basic functionality in

* clearing out css

* removed z-index fixes and add constants

* fixed string casting

* added redux-saga calls

* removed reset request notification

* fixed tests

* addressed comments, added basic test, added redux state management for opening/closing component

* added tests, just need to add render test

* cleaned up component tests:

* addressed html/css comments

* removed unecessary styling

* removed collapsed class

* cleaned up render method

* fixed test

* Open request component (amundsen-io#254)

* added button to open up request component

* removed tabledetail changes

* className styling

* fixed text-decoration

* added tests, changed naming for OpenRequest

* styling formatting

* Add, Request, and Remove Email Copy (amundsen-io#257)

* init for fixing email copy for request, add, and remove

* removed print statement

* fixed python unit test

* fixed linter issues

* addressed comments, fixed linter issues

* added notification unit test

* fixed test positional arg

* fix test

* Add notification action logging (amundsen-io#258)

* init of adding action logging

* changed location of action logging

* fixed linter errors

* fixed comment

* addressed comments

* remove request test call (amundsen-io#259)

* hide request if description already exists (amundsen-io#269)

* fixed open request button, request form styling (amundsen-io#267)

* Added request dropdown component (amundsen-io#262)

* init

* made fixes

* cleaned up code

* fixed color issues

* fixed import order

* fixed styling, changed ducks/sagas

* User dropdown (amundsen-io#263)

* init

* fixed sty;es

* fixed test issue

* fixed test

* added tests, addressed comments

* Request Metadata Component Tests (amundsen-io#270)

* added tests + readonly field to stop errors

* fixed tslint

* addressed comments, added header tests

* Request form navigation fix, dropdown fix (amundsen-io#272)

* Request form navigation fix, dropdown fix

* added test

* added unique id to dropdown

* Creates User Preferences page with no functionality (amundsen-io#266)

* init

* added event handlers

* removed test file

* added constants

* addressed comments

* fixed test, removed all links to page

* updated test

* fixed call to onclick

* removed preferences page

* Python cleanup + tests (amundsen-io#277)

* Python cleanup + tests

* More tests + revert some unecessary changes

* Bring dropdown UI closer to design (amundsen-io#278)

* Rename OpenRequestDescription for clarity + code cleanup + test additions (amundsen-io#279)

* Notifications ducks cleanup + tests (amundsen-io#280)

* Notifications ducks cleanup + tests

* Fix issues

* Fix template for edge case of empty form (amundsen-io#281)

* Temporary debugging code, will revert

* Temporary debugging code, will revert

* Implement notification form confirmation (amundsen-io#289)

* Preserve compatibility in base_mail_client (amundsen-io#290)

* Notifications Configs + Doc (amundsen-io#291)

* Add notification config

* Code cleanup

* More cleanup + add a test

* Add some doc for how to enable features

* Add config utils test + fix type error

* Relative URLs to child configuration docs (amundsen-io#294)

* Relative URLs to child configuration docs

Relative URLs to docs in the same folder should do. They work for any branch, local copies of the docs - and should work better if we ever (or whenever :-) we get to having e.g a Sphinx generated site.

* Update application_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Remove temporary debugging code

* Improve behavior of notification sending for owner editing (amundsen-io#296)

* Initial Implementation: Notification only on success

* Cleanup + tests: Notification only on success

* Cleanup: Remove test code to trigger failure

* Cleanup: Lint fix

* Workaround for not notifying teams or alumni

* Cleanup: Remove import mistake

* Utilize NotificationType enums instead of hardcoded string

* Remove use of render_template

* More minor cleanups

* Address some feedback

* Cleanup

* More cleanup

* Updates for RequestMetadataForm

* Switch to generating a  for url + comment required for request column descriptions

* Update some tests + comment out ones that need update before merge

* Update some tests + comment out ones that need update before merge

* Code cleanup

* Update and rename notification_utils python tests

* Modify resource_url check + add docstrings for python tests

* Component cleanup

* Cleanup component tests

* Fix some typos

* optimize docker (amundsen-io#300)

* Update developer_guide.md (amundsen-io#310)

Fix a 404

* Custom routes + Further notification cleanup (amundsen-io#309)

* Further notification cleanup

* Catch any errors getting the user for metrics + add doc for INIT_CUSTOM_ROUTES

* Revert change to _build_metrics

* Fix some merge conflicts

* Fix some merge conflicts

* Add source for notification email links (amundsen-io#312)

* Add source for notification email links

* Update TableDetail logic

* Fix FlashMessage styles

* Update config-types.ts (amundsen-io#314)

* Convert usages of `white` to `$white`

* - ResourceSelector now uses `setResource` action instead of onChange prop
- Added/fixed test cases for ResourceSelector/SearchPage
- Deleted unused code in SearchPage

* Added additional test cases for SearchBar

* Modified list-group shoadows

* Added a test case for ResourceSelector
  • Loading branch information
Daniel authored and ttannis committed Oct 22, 2019
1 parent 74c652f commit da1083c
Show file tree
Hide file tree
Showing 74 changed files with 2,335 additions and 622 deletions.
2 changes: 1 addition & 1 deletion amundsen_application/static/css/_avatars.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.sb-avatar > div {
border: 1px solid white;
border: 1px solid $white;
}

.sb-avatar > img {
Expand Down
10 changes: 5 additions & 5 deletions amundsen_application/static/css/_buttons-default.scss
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
&.btn-flat-icon {
border: none;
background-color: transparent;
color: $text-medium;
color: $text-secondary;
box-shadow: none !important;
padding: 0px;
text-align: left;
Expand All @@ -96,7 +96,7 @@
margin: 4px 0 0 0;
padding: 0;

background-color: $gray-light;
background-color: $icon-bg;
border: none;
mask-image: url('/static/images/icons/Close.svg');
-webkit-mask-image: url('/static/images/icons/Close.svg');
Expand All @@ -110,7 +110,7 @@
&:focus,
&:not(.disabled):hover,
&:not([disabled]):hover {
background-color: $gray-dark;
background-color: $icon-bg-dark;
}
}

Expand All @@ -119,11 +119,11 @@
-webkit-box-shadow: none;
-moz-box-shadow: none;
box-shadow: none;
color: $text-medium;
color: $text-secondary;
pointer-events: none;

&:hover {
color: $text-medium;
color: $text-secondary;
}
}
}
264 changes: 264 additions & 0 deletions amundsen_application/static/css/_colors.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,264 @@
/**
Avoid using these color definitions directly.
Define semantic variables that reference this color palette instead.
The color palette can be swapped out or modified without
revisiting each individual color usage.
---------------
Do this:
$text-primary: $gray100;
body {
color: $text-primary;
}
----------------
Don't do this:
body {
color: $gray100;
}
*/

$white: #FFFFFF;
$black: #000000;

/* Red */
$red0: #FFFAFB;
$red5: #FFE5E9;
$red10: #FFCFD5;
$red20: #FFA0AC;
$red30: #FF7689;
$red40: #FF516B;
$red50: #FF3354;
$red60: #E6193F;
$red70: #B8072C;
$red80: #8C0020;
$red90: #670019;
$red100: #560015;

/* Sunset */
$sunset0: #FFFBFA;
$sunset5: #FFE4DD;
$sunset10: #FFCCBF;
$sunset20: #FF9E87;
$sunset30: #FF7B5C;
$sunset40: #FF623E;
$sunset50: #FF4E28;
$sunset60: #DB3615;
$sunset70: #AF230A;
$sunset80: #841604;
$sunset90: #5F0E01;
$sunset100: #4E0B00;

/* Orange */
$orange0: #FFF6F2;
$orange5: #FFE8DD;
$orange10: #FFD9C7;
$orange20: #FFB38F;
$orange30: #FF915D;
$orange40: #FF7232;
$orange50: #F9560E;
$orange60: #D03D00;
$orange70: #A82E00;
$orange80: #832300;
$orange90: #651A00;
$orange100: #581600;

/* Amber */
$amber0: #FFFDFA;
$amber5: #FFF6E7;
$amber10: #FFF0D4;
$amber20: #FFE0A9;
$amber30: #FFD082;
$amber40: #FFC161;
$amber50: #FFB146;
$amber60: #FFA030;
$amber70: #FF8D1F;
$amber80: #FE7E13;
$amber90: #E66909;
$amber100: #CB5803;

/* Yellow */
$yellow0: #FFFEFA;
$yellow5: #FFF8D9;
$yellow10: #FFF3B8;
$yellow20: #FFE77B;
$yellow30: #FFDD4C;
$yellow40: #FFD32A;
$yellow50: #FFCA13;
$yellow60: #FFC002;
$yellow70: #EFAC00;
$yellow80: #DC9900;
$yellow90: #C78700;
$yellow100: #B07600;

/* Citron */
$citron0: #FFFFF2;
$citron5: #FFFFD2;
$citron10: #FEFFB2;
$citron20: #FBFF6F;
$citron30: #F1FB3B;
$citron40: #E2F316;
$citron50: #CCE700;
$citron60: #B5D900;
$citron70: #9AC800;
$citron80: #82B400;
$citron90: #6C9C00;
$citron100: #578000;

/* Lime */
$lime0: #FDFFFA;
$lime5: #EDFED0;
$lime10: #D6F3A0;
$lime20: #A4DC48;
$lime30: #75C404;
$lime40: #5EAB00;
$lime50: #499300;
$lime60: #347D00;
$lime70: #216800;
$lime80: #155600;
$lime90: #0E4400;
$lime100: #0A3600;

/* Green */
$green0: #FAFFFC;
$green5: #D1FFE2;
$green10: #A8FFC4;
$green20: #4BE77A;
$green30: #04CD3D;
$green40: #00B32E;
$green50: #009B22;
$green60: #008316;
$green70: #006E0B;
$green80: #005A05;
$green90: #004802;
$green100: #003901;

/* Mint */
$mint0: #FAFFFD;
$mint5: #D1FFEE;
$mint10: #A6FBDE;
$mint20: #4AE3AE;
$mint30: #04CA83;
$mint40: #00B16F;
$mint50: #00985D;
$mint60: #00824C;
$mint70: #006C3C;
$mint80: #00592F;
$mint90: #004724;
$mint100: #00381C;

/* Teal */
$teal0: #FAFFFE;
$teal5: #D1FFF7;
$teal10: #A8FFF4;
$teal20: #4CEAE4;
$teal30: #04CED2;
$teal40: #00B0B9;
$teal50: #00949F;
$teal60: #007B85;
$teal70: #00626B;
$teal80: #004C53;
$teal90: #003B40;
$teal100: #003338;

/* Cyan */
$cyan0: #FAFDFF;
$cyan5: #E7F6FF;
$cyan10: #D4F0FF;
$cyan20: #A9E1FF;
$cyan30: #82D2FF;
$cyan40: #5DBCF4;
$cyan50: #3A97D3;
$cyan60: #2277B3;
$cyan70: #135B96;
$cyan80: #09457B;
$cyan90: #043563;
$cyan100: #01284E;

/* Blue */
$blue0: #FAFBFF;
$blue5: #E8ECFF;
$blue10: #D5DCFF;
$blue20: #ACBBFF;
$blue30: #869DFF;
$blue40: #6686FF;
$blue50: #4B73FF;
$blue60: #3668FF;
$blue70: #2156DB;
$blue80: #1242AF;
$blue90: #093186;
$blue100: #042260;

/* Indigo */
$indigo0: #FAFAFF;
$indigo5: #EBEBFF;
$indigo10: #DCDCFF;
$indigo20: #BABAFF;
$indigo30: #9C9BFF;
$indigo40: #8481FF;
$indigo50: #726BFF;
$indigo60: #665AFF;
$indigo70: #604CFF;
$indigo80: #523BE4;
$indigo90: #3E29B1;
$indigo100: #2B1B81;

/* Purple */
$purple0: #FDFAFF;
$purple5: #F6EBFF;
$purple10: #ECDCFF;
$purple20: #D7B8FF;
$purple30: #C294FF;
$purple40: #AD71FF;
$purple50: #9B52FF;
$purple60: #8B37FF;
$purple70: #7B20F9;
$purple80: #590DC4;
$purple90: #420499;
$purple100: #390188;

/* Pink */
$pink0: #FFFAFD;
$pink5: #FFE1F2;
$pink10: #FFC7E4;
$pink20: #FF8FCC;
$pink30: #FF5DBB;
$pink40: #FF32B1;
$pink50: #FF0EB0;
$pink60: #DE00A7;
$pink70: #BD00A0;
$pink80: #A00093;
$pink90: #860081;
$pink100: #71006F;

/* Rose */
$rose0: #FFF2F5;
$rose5: #FFE1E9;
$rose10: #FFCFDC;
$rose20: #FFA0BA;
$rose30: #FF769E;
$rose40: #FF5187;
$rose50: #FF3378;
$rose60: #E51966;
$rose70: #B70752;
$rose80: #8B0040;
$rose90: #660031;
$rose100: #55002A;

/* Gray */
$gray0: #FCFCFF;
$gray5: #F4F4FA;
$gray10: #E7E7EF;
$gray15: #D8D8E4;
$gray20: #CACAD9;
$gray30: #ACACC0;
$gray40: #9191A8;
$gray50: #787891;
$gray60: #63637B;
$gray70: #515167;
$gray80: #414155;
$gray90: #333344;
$gray100: #292936;
4 changes: 3 additions & 1 deletion amundsen_application/static/css/_dropdowns.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@import 'variables';

.dropdown-menu {
box-shadow: 0 0 24px -2px rgba(0, 0, 0, .2);
border-radius: 5px;
Expand All @@ -7,7 +9,7 @@

li {
&:hover {
background-color: $gray-lightest;
background-color: $body-bg-secondary;
}
a {
padding: 8px;
Expand Down
Loading

0 comments on commit da1083c

Please sign in to comment.