Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS: Amundsen Frontend not reaching Neo4j #257

Closed
lordravo opened this issue Jan 29, 2020 · 6 comments · Fixed by #1603
Closed

AWS: Amundsen Frontend not reaching Neo4j #257

lordravo opened this issue Jan 29, 2020 · 6 comments · Fixed by #1603
Labels
status:needs_reproducing For bugs that need to be reproduced in order to get fixed status:needs_votes Issue or bug fix that needs support from the community to be considered type:bug An unexpected problem or unintended behavior

Comments

@lordravo
Copy link

lordravo commented Jan 29, 2020

I just followed the aws-ecs-deployment guide, and successfully launched the frontend, elasticsearch and neo4j endpoints.

After executing a dag with a BigQueryMetadataExtractor, I was also able to send metadata to Neo4j. As you can see:
image

But, for some reason, nothing is reachable through the amundsen frontend. Just a blank page:
image

Looking into the developer console there is a failed request:
/api/search/v0/table?query=events&page_index=0
image

{"msg":"Encountered exception: HTTPConnectionPool(host='amundsensearch', port=5000): Max retries exceeded with url: /search?query_term=events&page_index=0 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f3bf88fd470>: Failed to establish a new connection: [Errno -2] Name or service not known'))","search_term":"events","tables":{"page_index":0,"results":[],"total_results":0}}

I am not sure if it is related, but the elasticsearch endpoint returns the following:

{
"name" : "-ZjL23y",
"cluster_name" : "docker-cluster",
"cluster_uuid" : "yekS4uxBS76ULwUj4yp57A",
"version" : {
"number" : "6.7.0",
"build_flavor" : "default",
"build_type" : "docker",
"build_hash" : "8453f77",
"build_date" : "2019-03-21T15:32:29.844721Z",
"build_snapshot" : false,
"lucene_version" : "7.7.0",
"minimum_wire_compatibility_version" : "5.6.0",
"minimum_index_compatibility_version" : "5.0.0"
},
"tagline" : "You Know, for Search"
}

Any ideas why? Am I missing something?

@jornh
Copy link
Contributor

jornh commented Jan 29, 2020

It could be the “classic gotcha” that you also need to ingest data into Elasticsearch through the databuilder.

Here’s a sample of doing that: https://github.com/lyft/amundsendatabuilder/blob/v1.5.1/example/scripts/sample_data_loader.py#L590

@jornh
Copy link
Contributor

jornh commented Jan 29, 2020

The architecture diagram and the Search and Databuilder sections in https://github.com/lyft/amundsen/blob/master/docs/architecture.md gives a good high level overview.

@feng-tao feng-tao added amundsensearchlibrary keep fresh Disables stalebot from closing an issue labels Jan 29, 2020
@lordravo
Copy link
Author

lordravo commented Jan 30, 2020

Hi @jornh, thanks for the help..

I added a create_es_publisher_sample_job to the DAG, but even so all requests on Amunsen Frontend ends up with status 500.. It seems a configuration issue perhaps?

Event the /api/auth_user endpoints returns:

{"msg":"Encountered exception: AUTH_USER_METHOD is not configured"}

And api/metadata/v0/get_last_indexed:

{"msg":"Encountered exception: HTTPConnectionPool(host='amundsenmetadata', port=5000): Max retries exceeded with url: /latest_updated_ts (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f3bf88ac080>: Failed to establish a new connection: [Errno -2] Name or service not known'))","timestamp":null}

I am attaching my code anyways...
sample_amundsen_v2.zip

The amundsen_databuilder_table_metadata_job task works properly, adding the metadata to Neo4J

The es_table_job task endsup with success, bit I'm not sure how to check any effects other than trying to query on Amundsen Frontend.

    es_table_job = PythonOperator(
        task_id='es_table_job',
        python_callable=create_es_publisher_sample_job,
        provide_context=True,
        op_kwargs={
            'elasticsearch_index_alias': 'table_search_index',
            'elasticsearch_doc_type_key': 'table',
            'model_name': 'databuilder.models.table_elasticsearch_document.TableESDocument'
        }
    )

Any idea?


Edit: It seems on the Elasticsearch side, everything is fine. Looking into http://host:9200/tablese8214591-bd7b-4c2f-b6d3-2eabcc8a6aa2/_search, I was able to retrieve all metadata previously sent.

Digging into the docker-ecs-amundsen.yml, there is the following environment variables on the amundsenfrontend:
- SEARCHSERVICE_BASE=http://amundsensearch:5000
- METADATASERVICE_BASE=http://amundsenmetadata:5000

I wonder if it is related, since every search cames up with:

Encountered exception: HTTPConnectionPool(host='amundsensearch', port=5000): Max retries exceeded with url: /search?query_term=test&page_index=0 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f3bf8909278>: Failed to establish a new connection: [Errno -2] Name or service not known'))


Edit2: Looking back to my launch script, I found out some odd warnings from ecs-cli compose:

ecs-cli compose --cluster-config lg-amundsen --file docker-ecs-amundsen.yml up --create-log-groups --ecs-profile lg-amundsen
[WARN] Skipping unsupported YAML option for service... [option name]=container_name [service name]=amundsenfrontend
[WARN] Skipping unsupported YAML option for service... [option name]=depends_on [service name]=amundsenfrontend
[WARN] Skipping unsupported YAML option for service... [option name]=container_name [service name]=neo4j
[WARN] Skipping unsupported YAML option for service... [option name]=container_name [service name]=elasticsearch
[WARN] Skipping unsupported YAML option for service... [option name]=container_name [service name]=amundsensearch
[WARN] Skipping unsupported YAML option for service... [option name]=depends_on [service name]=amundsensearch
[WARN] Skipping unsupported YAML option for service... [option name]=container_name [service name]=amundsenmetadata
[WARN] Skipping unsupported YAML option for service... [option name]=depends_on [service name]=amundsenmetadata

It seems to have skipped yaml keys like: container_name and depends_on
That seems bad

@lordravo
Copy link
Author

lordravo commented Jan 31, 2020

I'm pretty sure it is ECS related... I just launched Amundsen on a CentOS Instance, on GoogleCloud. Exact same yml (without the aws logs), and everything is working so far.

@Golodhros Golodhros added type:bug An unexpected problem or unintended behavior status:needs_reproducing For bugs that need to be reproduced in order to get fixed labels May 29, 2020
@andrey-oreshko
Copy link

@lordravo hey i'm experiencing the same issue
Did you come up with some solution except using CentOS?

gjxdxh pushed a commit to gjxdxh/amundsen that referenced this issue Dec 8, 2020
* Druid metadata extractor

* add doc

* fix lint

* add extra deps

* Update version
dorianj pushed a commit to dorianj/amundsen that referenced this issue Apr 25, 2021
* Initial start to notifications API (amundsen-io#215)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* addressed comments regarding imports/enum naming

* fixed alphabetical order

* Notifs post email functionality (amundsen-io#222)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* added template support

* made changes to reflect private changes

* added helper function

* fixed lint issue

* addressed comments, added some type checking and cleaned up comments

* testing removing test

* fixed linter

* fixed lint

* fixed linting issues

* skip type checking

* fixed lint

* fixed typing on get request args

* removed typing for get request to fix lint issues

* fixed linter again

* re added test

* raise exception inside of getmailclient

* added exceptions

* addressed comments

* whitespace issue

* removed calls to get_query_param

* fixed syntax error

* Send notification when adding/removing owner from table (amundsen-io#237)

* basic e2e functionality for adding/removing

* send_notification refactor

* fix lint errors

* blank line lint error

* fixed syntax issue

* arg typing

* addressed comments, fixed code style

* Prevent Self-Notifications (amundsen-io#243)

* Prevent user from notifying themselves

* removed exception

* added owner check to send_notification

* Fixed return for no recipients (amundsen-io#244)

* fixed return for no recipients

* fixed linter issue

* Request notifications component (amundsen-io#238)

* init of request form

* basic request component

* getting basic functionality in

* clearing out css

* removed z-index fixes and add constants

* fixed string casting

* added redux-saga calls

* removed reset request notification

* fixed tests

* addressed comments, added basic test, added redux state management for opening/closing component

* added tests, just need to add render test

* cleaned up component tests:

* addressed html/css comments

* removed unecessary styling

* removed collapsed class

* cleaned up render method

* fixed test

* Open request component (amundsen-io#254)

* added button to open up request component

* removed tabledetail changes

* className styling

* fixed text-decoration

* added tests, changed naming for OpenRequest

* styling formatting

* Add, Request, and Remove Email Copy (amundsen-io#257)

* init for fixing email copy for request, add, and remove

* removed print statement

* fixed python unit test

* fixed linter issues

* addressed comments, fixed linter issues

* added notification unit test

* fixed test positional arg

* fix test

* Add notification action logging (amundsen-io#258)

* init of adding action logging

* changed location of action logging

* fixed linter errors

* fixed comment

* addressed comments

* remove request test call (amundsen-io#259)

* hide request if description already exists (amundsen-io#269)

* fixed open request button, request form styling (amundsen-io#267)

* Added request dropdown component (amundsen-io#262)

* init

* made fixes

* cleaned up code

* fixed color issues

* fixed import order

* fixed styling, changed ducks/sagas

* User dropdown (amundsen-io#263)

* init

* fixed sty;es

* fixed test issue

* fixed test

* added tests, addressed comments

* Request Metadata Component Tests (amundsen-io#270)

* added tests + readonly field to stop errors

* fixed tslint

* addressed comments, added header tests

* Request form navigation fix, dropdown fix (amundsen-io#272)

* Request form navigation fix, dropdown fix

* added test

* added unique id to dropdown

* Creates User Preferences page with no functionality (amundsen-io#266)

* init

* added event handlers

* removed test file

* added constants

* addressed comments

* fixed test, removed all links to page

* updated test

* fixed call to onclick

* removed preferences page

* Python cleanup + tests (amundsen-io#277)

* Python cleanup + tests

* More tests + revert some unecessary changes

* Bring dropdown UI closer to design (amundsen-io#278)

* Rename OpenRequestDescription for clarity + code cleanup + test additions (amundsen-io#279)

* Notifications ducks cleanup + tests (amundsen-io#280)

* Notifications ducks cleanup + tests

* Fix issues

* Fix template for edge case of empty form (amundsen-io#281)

* Temporary debugging code, will revert

* Temporary debugging code, will revert

* Implement notification form confirmation (amundsen-io#289)

* Preserve compatibility in base_mail_client (amundsen-io#290)

* Notifications Configs + Doc (amundsen-io#291)

* Add notification config

* Code cleanup

* More cleanup + add a test

* Add some doc for how to enable features

* Add config utils test + fix type error

* Relative URLs to child configuration docs (amundsen-io#294)

* Relative URLs to child configuration docs

Relative URLs to docs in the same folder should do. They work for any branch, local copies of the docs - and should work better if we ever (or whenever :-) we get to having e.g a Sphinx generated site.

* Update application_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Remove temporary debugging code

* Improve behavior of notification sending for owner editing (amundsen-io#296)

* Initial Implementation: Notification only on success

* Cleanup + tests: Notification only on success

* Cleanup: Remove test code to trigger failure

* Cleanup: Lint fix

* Workaround for not notifying teams or alumni

* Cleanup: Remove import mistake

* Utilize NotificationType enums instead of hardcoded string

* Remove use of render_template

* More minor cleanups

* Address some feedback

* Cleanup

* More cleanup
dorianj pushed a commit to dorianj/amundsen that referenced this issue Apr 25, 2021
* Initial start to notifications API (amundsen-io#215)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* addressed comments regarding imports/enum naming

* fixed alphabetical order

* Notifs post email functionality (amundsen-io#222)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* added template support

* made changes to reflect private changes

* added helper function

* fixed lint issue

* addressed comments, added some type checking and cleaned up comments

* testing removing test

* fixed linter

* fixed lint

* fixed linting issues

* skip type checking

* fixed lint

* fixed typing on get request args

* removed typing for get request to fix lint issues

* fixed linter again

* re added test

* raise exception inside of getmailclient

* added exceptions

* addressed comments

* whitespace issue

* removed calls to get_query_param

* fixed syntax error

* Send notification when adding/removing owner from table (amundsen-io#237)

* basic e2e functionality for adding/removing

* send_notification refactor

* fix lint errors

* blank line lint error

* fixed syntax issue

* arg typing

* addressed comments, fixed code style

* Prevent Self-Notifications (amundsen-io#243)

* Prevent user from notifying themselves

* removed exception

* added owner check to send_notification

* Fixed return for no recipients (amundsen-io#244)

* fixed return for no recipients

* fixed linter issue

* Request notifications component (amundsen-io#238)

* init of request form

* basic request component

* getting basic functionality in

* clearing out css

* removed z-index fixes and add constants

* fixed string casting

* added redux-saga calls

* removed reset request notification

* fixed tests

* addressed comments, added basic test, added redux state management for opening/closing component

* added tests, just need to add render test

* cleaned up component tests:

* addressed html/css comments

* removed unecessary styling

* removed collapsed class

* cleaned up render method

* fixed test

* Open request component (amundsen-io#254)

* added button to open up request component

* removed tabledetail changes

* className styling

* fixed text-decoration

* added tests, changed naming for OpenRequest

* styling formatting

* Add, Request, and Remove Email Copy (amundsen-io#257)

* init for fixing email copy for request, add, and remove

* removed print statement

* fixed python unit test

* fixed linter issues

* addressed comments, fixed linter issues

* added notification unit test

* fixed test positional arg

* fix test

* Add notification action logging (amundsen-io#258)

* init of adding action logging

* changed location of action logging

* fixed linter errors

* fixed comment

* addressed comments

* remove request test call (amundsen-io#259)

* hide request if description already exists (amundsen-io#269)

* fixed open request button, request form styling (amundsen-io#267)

* Added request dropdown component (amundsen-io#262)

* init

* made fixes

* cleaned up code

* fixed color issues

* fixed import order

* fixed styling, changed ducks/sagas

* User dropdown (amundsen-io#263)

* init

* fixed sty;es

* fixed test issue

* fixed test

* added tests, addressed comments

* Request Metadata Component Tests (amundsen-io#270)

* added tests + readonly field to stop errors

* fixed tslint

* addressed comments, added header tests

* Request form navigation fix, dropdown fix (amundsen-io#272)

* Request form navigation fix, dropdown fix

* added test

* added unique id to dropdown

* Creates User Preferences page with no functionality (amundsen-io#266)

* init

* added event handlers

* removed test file

* added constants

* addressed comments

* fixed test, removed all links to page

* updated test

* fixed call to onclick

* removed preferences page

* Python cleanup + tests (amundsen-io#277)

* Python cleanup + tests

* More tests + revert some unecessary changes

* Bring dropdown UI closer to design (amundsen-io#278)

* Rename OpenRequestDescription for clarity + code cleanup + test additions (amundsen-io#279)

* Notifications ducks cleanup + tests (amundsen-io#280)

* Notifications ducks cleanup + tests

* Fix issues

* Fix template for edge case of empty form (amundsen-io#281)

* Temporary debugging code, will revert

* Temporary debugging code, will revert

* Implement notification form confirmation (amundsen-io#289)

* Preserve compatibility in base_mail_client (amundsen-io#290)

* Notifications Configs + Doc (amundsen-io#291)

* Add notification config

* Code cleanup

* More cleanup + add a test

* Add some doc for how to enable features

* Add config utils test + fix type error

* Relative URLs to child configuration docs (amundsen-io#294)

* Relative URLs to child configuration docs

Relative URLs to docs in the same folder should do. They work for any branch, local copies of the docs - and should work better if we ever (or whenever :-) we get to having e.g a Sphinx generated site.

* Update application_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Remove temporary debugging code

* Improve behavior of notification sending for owner editing (amundsen-io#296)

* Initial Implementation: Notification only on success

* Cleanup + tests: Notification only on success

* Cleanup: Remove test code to trigger failure

* Cleanup: Lint fix

* Workaround for not notifying teams or alumni

* Cleanup: Remove import mistake

* Utilize NotificationType enums instead of hardcoded string

* Remove use of render_template

* More minor cleanups

* Address some feedback

* Cleanup

* More cleanup

* Updates for RequestMetadataForm

* Switch to generating a  for url + comment required for request column descriptions

* Update some tests + comment out ones that need update before merge

* Update some tests + comment out ones that need update before merge

* Code cleanup

* Update and rename notification_utils python tests

* Modify resource_url check + add docstrings for python tests

* Component cleanup

* Cleanup component tests

* Fix some typos
dorianj pushed a commit to dorianj/amundsen that referenced this issue Apr 25, 2021
* Merge `master` into `feature/search_v2` (amundsen-io#253)

* Clean up doc (amundsen-io#249)

* Remove example folder in FE (amundsen-io#251)

* Add better logging for profile page views (amundsen-io#239)

* Added new search page layout (amundsen-io#250)

* Added SearchPanel to search page, with new wide layout
* Added 'ResourceSelector'

* Add SearchBar to NavBar + update styles (amundsen-io#252)

* Add SearchBar to NavBar + update styles

* Lint fix

* Code cleanup

* Fix tests

* Update ResourceListItem UI (amundsen-io#255)

* WIP

* Update layout

* Some code cleanup

* Tests

* Add some starter doc for the AppConfig

* Code cleanup + update UserListItem description UI

* start icon -> resource icon

* Moved Feedback tool to NavBar (amundsen-io#256)

* Update Feedback Component

* Update tests

* Clean up some styles

* reposition form

* Tweak feedback style

* Initial implementation of SearchFilter (amundsen-io#260)

* Initial implementation of SearchFilter

* Clean some code + add CheckBoxItem tests

* Fixed warning on ResourceSelector

* Add/fix some more tests

* Some tweaks before merge

* Implement New color theme (amundsen-io#276)

* Added a color palette file
* Replaced $gray-light/dark colors with semantic variables for each purpose
* Update brand colors to indigo

* Merge `master` into  `feature/search_v2` (amundsen-io#286)

* Update searchv2 master (amundsen-io#313)

* Clean up doc (amundsen-io#249)

* Remove example folder in FE (amundsen-io#251)

* Add better logging for profile page views (amundsen-io#239)

* add stalebot config (amundsen-io#264)

* Update stalebot setting (amundsen-io#268)

* Adds the request timeout configuration (amundsen-io#275)

* Adds the request timeout configuration

* Bumps the version to take advantage of request timeout

* Update AxiosError handling (amundsen-io#283)

* Update v0.ts

* lint fix

* Use Redux-Saga for Search Actions (amundsen-io#265)

* Added redux actions and sagas instead for each search action: `submitSearch`, `setResource`, `setPageIndex`, `loadPreviousSearch`, and `UrlDidUpdate`. This greatly simplifies the `SearchPage` logic in preparation for adding filters.
* Added `navigation-utils`.

* Removed `SQUASH COMMITS` from the PR template (amundsen-io#287)

Removed `SQUASH COMMITS` from the PR template

* TagInfo now fires 'submitSearch' instead of using navigation (amundsen-io#285)

* Remove render_template for feedback email (amundsen-io#293)

* Remove render_template for feedback email

* Fix html markup

* Added auto-select resource after searching (amundsen-io#292)

* Truncate the column type (amundsen-io#297)

* Truncate the column type

* Update truncation method

* Cleanup logic

* Improve table & columns description formatting (amundsen-io#98) (amundsen-io#298)

* Add support for React-Markdown to editable text fields
* Add support for windows via cross-env

* Update EditableText component (amundsen-io#299)

* Fix some styling issues with react-markdown
* Update EditableText to use React Refs instead of ref callbacks
* Add configs for table and column description max lengths

* Change 'json' to 'data' field for Python Requests (amundsen-io#303)

* Switch usage of 'json' to 'data' in metadata APIs
* Use 'raw_request=True' for Envoy client post/put APIs

* Update README.md (amundsen-io#302)

* Link deeper to doc content (amundsen-io#304)

Summary of Changes

Will scroll past GitHub repo folders (specially more handy on small screens like phones/tablets)
Like amundsen-io/amundsendatabuilder#147

* Fixed linebreaks with Markdown descriptions (amundsen-io#305)

* Amundsen Notifications Without Preferences (amundsen-io#273)

* Initial start to notifications API (amundsen-io#215)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* addressed comments regarding imports/enum naming

* fixed alphabetical order

* Notifs post email functionality (amundsen-io#222)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* added template support

* made changes to reflect private changes

* added helper function

* fixed lint issue

* addressed comments, added some type checking and cleaned up comments

* testing removing test

* fixed linter

* fixed lint

* fixed linting issues

* skip type checking

* fixed lint

* fixed typing on get request args

* removed typing for get request to fix lint issues

* fixed linter again

* re added test

* raise exception inside of getmailclient

* added exceptions

* addressed comments

* whitespace issue

* removed calls to get_query_param

* fixed syntax error

* Send notification when adding/removing owner from table (amundsen-io#237)

* basic e2e functionality for adding/removing

* send_notification refactor

* fix lint errors

* blank line lint error

* fixed syntax issue

* arg typing

* addressed comments, fixed code style

* Prevent Self-Notifications (amundsen-io#243)

* Prevent user from notifying themselves

* removed exception

* added owner check to send_notification

* Fixed return for no recipients (amundsen-io#244)

* fixed return for no recipients

* fixed linter issue

* Request notifications component (amundsen-io#238)

* init of request form

* basic request component

* getting basic functionality in

* clearing out css

* removed z-index fixes and add constants

* fixed string casting

* added redux-saga calls

* removed reset request notification

* fixed tests

* addressed comments, added basic test, added redux state management for opening/closing component

* added tests, just need to add render test

* cleaned up component tests:

* addressed html/css comments

* removed unecessary styling

* removed collapsed class

* cleaned up render method

* fixed test

* Open request component (amundsen-io#254)

* added button to open up request component

* removed tabledetail changes

* className styling

* fixed text-decoration

* added tests, changed naming for OpenRequest

* styling formatting

* Add, Request, and Remove Email Copy (amundsen-io#257)

* init for fixing email copy for request, add, and remove

* removed print statement

* fixed python unit test

* fixed linter issues

* addressed comments, fixed linter issues

* added notification unit test

* fixed test positional arg

* fix test

* Add notification action logging (amundsen-io#258)

* init of adding action logging

* changed location of action logging

* fixed linter errors

* fixed comment

* addressed comments

* remove request test call (amundsen-io#259)

* hide request if description already exists (amundsen-io#269)

* fixed open request button, request form styling (amundsen-io#267)

* Added request dropdown component (amundsen-io#262)

* init

* made fixes

* cleaned up code

* fixed color issues

* fixed import order

* fixed styling, changed ducks/sagas

* User dropdown (amundsen-io#263)

* init

* fixed sty;es

* fixed test issue

* fixed test

* added tests, addressed comments

* Request Metadata Component Tests (amundsen-io#270)

* added tests + readonly field to stop errors

* fixed tslint

* addressed comments, added header tests

* Request form navigation fix, dropdown fix (amundsen-io#272)

* Request form navigation fix, dropdown fix

* added test

* added unique id to dropdown

* Creates User Preferences page with no functionality (amundsen-io#266)

* init

* added event handlers

* removed test file

* added constants

* addressed comments

* fixed test, removed all links to page

* updated test

* fixed call to onclick

* removed preferences page

* Python cleanup + tests (amundsen-io#277)

* Python cleanup + tests

* More tests + revert some unecessary changes

* Bring dropdown UI closer to design (amundsen-io#278)

* Rename OpenRequestDescription for clarity + code cleanup + test additions (amundsen-io#279)

* Notifications ducks cleanup + tests (amundsen-io#280)

* Notifications ducks cleanup + tests

* Fix issues

* Fix template for edge case of empty form (amundsen-io#281)

* Temporary debugging code, will revert

* Temporary debugging code, will revert

* Implement notification form confirmation (amundsen-io#289)

* Preserve compatibility in base_mail_client (amundsen-io#290)

* Notifications Configs + Doc (amundsen-io#291)

* Add notification config

* Code cleanup

* More cleanup + add a test

* Add some doc for how to enable features

* Add config utils test + fix type error

* Relative URLs to child configuration docs (amundsen-io#294)

* Relative URLs to child configuration docs

Relative URLs to docs in the same folder should do. They work for any branch, local copies of the docs - and should work better if we ever (or whenever :-) we get to having e.g a Sphinx generated site.

* Update application_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Remove temporary debugging code

* Improve behavior of notification sending for owner editing (amundsen-io#296)

* Initial Implementation: Notification only on success

* Cleanup + tests: Notification only on success

* Cleanup: Remove test code to trigger failure

* Cleanup: Lint fix

* Workaround for not notifying teams or alumni

* Cleanup: Remove import mistake

* Utilize NotificationType enums instead of hardcoded string

* Remove use of render_template

* More minor cleanups

* Address some feedback

* Cleanup

* More cleanup

* Notifications Improvements (amundsen-io#301)

* Initial start to notifications API (amundsen-io#215)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* addressed comments regarding imports/enum naming

* fixed alphabetical order

* Notifs post email functionality (amundsen-io#222)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* added template support

* made changes to reflect private changes

* added helper function

* fixed lint issue

* addressed comments, added some type checking and cleaned up comments

* testing removing test

* fixed linter

* fixed lint

* fixed linting issues

* skip type checking

* fixed lint

* fixed typing on get request args

* removed typing for get request to fix lint issues

* fixed linter again

* re added test

* raise exception inside of getmailclient

* added exceptions

* addressed comments

* whitespace issue

* removed calls to get_query_param

* fixed syntax error

* Send notification when adding/removing owner from table (amundsen-io#237)

* basic e2e functionality for adding/removing

* send_notification refactor

* fix lint errors

* blank line lint error

* fixed syntax issue

* arg typing

* addressed comments, fixed code style

* Prevent Self-Notifications (amundsen-io#243)

* Prevent user from notifying themselves

* removed exception

* added owner check to send_notification

* Fixed return for no recipients (amundsen-io#244)

* fixed return for no recipients

* fixed linter issue

* Request notifications component (amundsen-io#238)

* init of request form

* basic request component

* getting basic functionality in

* clearing out css

* removed z-index fixes and add constants

* fixed string casting

* added redux-saga calls

* removed reset request notification

* fixed tests

* addressed comments, added basic test, added redux state management for opening/closing component

* added tests, just need to add render test

* cleaned up component tests:

* addressed html/css comments

* removed unecessary styling

* removed collapsed class

* cleaned up render method

* fixed test

* Open request component (amundsen-io#254)

* added button to open up request component

* removed tabledetail changes

* className styling

* fixed text-decoration

* added tests, changed naming for OpenRequest

* styling formatting

* Add, Request, and Remove Email Copy (amundsen-io#257)

* init for fixing email copy for request, add, and remove

* removed print statement

* fixed python unit test

* fixed linter issues

* addressed comments, fixed linter issues

* added notification unit test

* fixed test positional arg

* fix test

* Add notification action logging (amundsen-io#258)

* init of adding action logging

* changed location of action logging

* fixed linter errors

* fixed comment

* addressed comments

* remove request test call (amundsen-io#259)

* hide request if description already exists (amundsen-io#269)

* fixed open request button, request form styling (amundsen-io#267)

* Added request dropdown component (amundsen-io#262)

* init

* made fixes

* cleaned up code

* fixed color issues

* fixed import order

* fixed styling, changed ducks/sagas

* User dropdown (amundsen-io#263)

* init

* fixed sty;es

* fixed test issue

* fixed test

* added tests, addressed comments

* Request Metadata Component Tests (amundsen-io#270)

* added tests + readonly field to stop errors

* fixed tslint

* addressed comments, added header tests

* Request form navigation fix, dropdown fix (amundsen-io#272)

* Request form navigation fix, dropdown fix

* added test

* added unique id to dropdown

* Creates User Preferences page with no functionality (amundsen-io#266)

* init

* added event handlers

* removed test file

* added constants

* addressed comments

* fixed test, removed all links to page

* updated test

* fixed call to onclick

* removed preferences page

* Python cleanup + tests (amundsen-io#277)

* Python cleanup + tests

* More tests + revert some unecessary changes

* Bring dropdown UI closer to design (amundsen-io#278)

* Rename OpenRequestDescription for clarity + code cleanup + test additions (amundsen-io#279)

* Notifications ducks cleanup + tests (amundsen-io#280)

* Notifications ducks cleanup + tests

* Fix issues

* Fix template for edge case of empty form (amundsen-io#281)

* Temporary debugging code, will revert

* Temporary debugging code, will revert

* Implement notification form confirmation (amundsen-io#289)

* Preserve compatibility in base_mail_client (amundsen-io#290)

* Notifications Configs + Doc (amundsen-io#291)

* Add notification config

* Code cleanup

* More cleanup + add a test

* Add some doc for how to enable features

* Add config utils test + fix type error

* Relative URLs to child configuration docs (amundsen-io#294)

* Relative URLs to child configuration docs

Relative URLs to docs in the same folder should do. They work for any branch, local copies of the docs - and should work better if we ever (or whenever :-) we get to having e.g a Sphinx generated site.

* Update application_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Remove temporary debugging code

* Improve behavior of notification sending for owner editing (amundsen-io#296)

* Initial Implementation: Notification only on success

* Cleanup + tests: Notification only on success

* Cleanup: Remove test code to trigger failure

* Cleanup: Lint fix

* Workaround for not notifying teams or alumni

* Cleanup: Remove import mistake

* Utilize NotificationType enums instead of hardcoded string

* Remove use of render_template

* More minor cleanups

* Address some feedback

* Cleanup

* More cleanup

* Updates for RequestMetadataForm

* Switch to generating a  for url + comment required for request column descriptions

* Update some tests + comment out ones that need update before merge

* Update some tests + comment out ones that need update before merge

* Code cleanup

* Update and rename notification_utils python tests

* Modify resource_url check + add docstrings for python tests

* Component cleanup

* Cleanup component tests

* Fix some typos

* optimize docker (amundsen-io#300)

* Update developer_guide.md (amundsen-io#310)

Fix a 404

* Custom routes + Further notification cleanup (amundsen-io#309)

* Further notification cleanup

* Catch any errors getting the user for metrics + add doc for INIT_CUSTOM_ROUTES

* Revert change to _build_metrics

* Fix some merge conflicts

* Fix some merge conflicts

* Add source for notification email links (amundsen-io#312)

* Add source for notification email links

* Update TableDetail logic

* Fix FlashMessage styles

* Update config-types.ts (amundsen-io#314)

* Convert usages of `white` to `$white`

* - ResourceSelector now uses `setResource` action instead of onChange prop
- Added/fixed test cases for ResourceSelector/SearchPage
- Deleted unused code in SearchPage

* Added additional test cases for SearchBar

* Modified list-group shoadows

* Added a test case for ResourceSelector
dorianj pushed a commit to dorianj/amundsen that referenced this issue Apr 25, 2021
* Druid metadata extractor

* add doc

* fix lint

* add extra deps

* Update version
feng-tao pushed a commit that referenced this issue May 7, 2021
* Initial start to notifications API (#215)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* addressed comments regarding imports/enum naming

* fixed alphabetical order

* Notifs post email functionality (#222)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* added template support

* made changes to reflect private changes

* added helper function

* fixed lint issue

* addressed comments, added some type checking and cleaned up comments

* testing removing test

* fixed linter

* fixed lint

* fixed linting issues

* skip type checking

* fixed lint

* fixed typing on get request args

* removed typing for get request to fix lint issues

* fixed linter again

* re added test

* raise exception inside of getmailclient

* added exceptions

* addressed comments

* whitespace issue

* removed calls to get_query_param

* fixed syntax error

* Send notification when adding/removing owner from table (#237)

* basic e2e functionality for adding/removing

* send_notification refactor

* fix lint errors

* blank line lint error

* fixed syntax issue

* arg typing

* addressed comments, fixed code style

* Prevent Self-Notifications (#243)

* Prevent user from notifying themselves

* removed exception

* added owner check to send_notification

* Fixed return for no recipients (#244)

* fixed return for no recipients

* fixed linter issue

* Request notifications component (#238)

* init of request form

* basic request component

* getting basic functionality in

* clearing out css

* removed z-index fixes and add constants

* fixed string casting

* added redux-saga calls

* removed reset request notification

* fixed tests

* addressed comments, added basic test, added redux state management for opening/closing component

* added tests, just need to add render test

* cleaned up component tests:

* addressed html/css comments

* removed unecessary styling

* removed collapsed class

* cleaned up render method

* fixed test

* Open request component (#254)

* added button to open up request component

* removed tabledetail changes

* className styling

* fixed text-decoration

* added tests, changed naming for OpenRequest

* styling formatting

* Add, Request, and Remove Email Copy (#257)

* init for fixing email copy for request, add, and remove

* removed print statement

* fixed python unit test

* fixed linter issues

* addressed comments, fixed linter issues

* added notification unit test

* fixed test positional arg

* fix test

* Add notification action logging (#258)

* init of adding action logging

* changed location of action logging

* fixed linter errors

* fixed comment

* addressed comments

* remove request test call (#259)

* hide request if description already exists (#269)

* fixed open request button, request form styling (#267)

* Added request dropdown component (#262)

* init

* made fixes

* cleaned up code

* fixed color issues

* fixed import order

* fixed styling, changed ducks/sagas

* User dropdown (#263)

* init

* fixed sty;es

* fixed test issue

* fixed test

* added tests, addressed comments

* Request Metadata Component Tests (#270)

* added tests + readonly field to stop errors

* fixed tslint

* addressed comments, added header tests

* Request form navigation fix, dropdown fix (#272)

* Request form navigation fix, dropdown fix

* added test

* added unique id to dropdown

* Creates User Preferences page with no functionality (#266)

* init

* added event handlers

* removed test file

* added constants

* addressed comments

* fixed test, removed all links to page

* updated test

* fixed call to onclick

* removed preferences page

* Python cleanup + tests (#277)

* Python cleanup + tests

* More tests + revert some unecessary changes

* Bring dropdown UI closer to design (#278)

* Rename OpenRequestDescription for clarity + code cleanup + test additions (#279)

* Notifications ducks cleanup + tests (#280)

* Notifications ducks cleanup + tests

* Fix issues

* Fix template for edge case of empty form (#281)

* Temporary debugging code, will revert

* Temporary debugging code, will revert

* Implement notification form confirmation (#289)

* Preserve compatibility in base_mail_client (#290)

* Notifications Configs + Doc (#291)

* Add notification config

* Code cleanup

* More cleanup + add a test

* Add some doc for how to enable features

* Add config utils test + fix type error

* Relative URLs to child configuration docs (#294)

* Relative URLs to child configuration docs

Relative URLs to docs in the same folder should do. They work for any branch, local copies of the docs - and should work better if we ever (or whenever :-) we get to having e.g a Sphinx generated site.

* Update application_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Remove temporary debugging code

* Improve behavior of notification sending for owner editing (#296)

* Initial Implementation: Notification only on success

* Cleanup + tests: Notification only on success

* Cleanup: Remove test code to trigger failure

* Cleanup: Lint fix

* Workaround for not notifying teams or alumni

* Cleanup: Remove import mistake

* Utilize NotificationType enums instead of hardcoded string

* Remove use of render_template

* More minor cleanups

* Address some feedback

* Cleanup

* More cleanup
feng-tao pushed a commit that referenced this issue May 7, 2021
* Initial start to notifications API (#215)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* addressed comments regarding imports/enum naming

* fixed alphabetical order

* Notifs post email functionality (#222)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* added template support

* made changes to reflect private changes

* added helper function

* fixed lint issue

* addressed comments, added some type checking and cleaned up comments

* testing removing test

* fixed linter

* fixed lint

* fixed linting issues

* skip type checking

* fixed lint

* fixed typing on get request args

* removed typing for get request to fix lint issues

* fixed linter again

* re added test

* raise exception inside of getmailclient

* added exceptions

* addressed comments

* whitespace issue

* removed calls to get_query_param

* fixed syntax error

* Send notification when adding/removing owner from table (#237)

* basic e2e functionality for adding/removing

* send_notification refactor

* fix lint errors

* blank line lint error

* fixed syntax issue

* arg typing

* addressed comments, fixed code style

* Prevent Self-Notifications (#243)

* Prevent user from notifying themselves

* removed exception

* added owner check to send_notification

* Fixed return for no recipients (#244)

* fixed return for no recipients

* fixed linter issue

* Request notifications component (#238)

* init of request form

* basic request component

* getting basic functionality in

* clearing out css

* removed z-index fixes and add constants

* fixed string casting

* added redux-saga calls

* removed reset request notification

* fixed tests

* addressed comments, added basic test, added redux state management for opening/closing component

* added tests, just need to add render test

* cleaned up component tests:

* addressed html/css comments

* removed unecessary styling

* removed collapsed class

* cleaned up render method

* fixed test

* Open request component (#254)

* added button to open up request component

* removed tabledetail changes

* className styling

* fixed text-decoration

* added tests, changed naming for OpenRequest

* styling formatting

* Add, Request, and Remove Email Copy (#257)

* init for fixing email copy for request, add, and remove

* removed print statement

* fixed python unit test

* fixed linter issues

* addressed comments, fixed linter issues

* added notification unit test

* fixed test positional arg

* fix test

* Add notification action logging (#258)

* init of adding action logging

* changed location of action logging

* fixed linter errors

* fixed comment

* addressed comments

* remove request test call (#259)

* hide request if description already exists (#269)

* fixed open request button, request form styling (#267)

* Added request dropdown component (#262)

* init

* made fixes

* cleaned up code

* fixed color issues

* fixed import order

* fixed styling, changed ducks/sagas

* User dropdown (#263)

* init

* fixed sty;es

* fixed test issue

* fixed test

* added tests, addressed comments

* Request Metadata Component Tests (#270)

* added tests + readonly field to stop errors

* fixed tslint

* addressed comments, added header tests

* Request form navigation fix, dropdown fix (#272)

* Request form navigation fix, dropdown fix

* added test

* added unique id to dropdown

* Creates User Preferences page with no functionality (#266)

* init

* added event handlers

* removed test file

* added constants

* addressed comments

* fixed test, removed all links to page

* updated test

* fixed call to onclick

* removed preferences page

* Python cleanup + tests (#277)

* Python cleanup + tests

* More tests + revert some unecessary changes

* Bring dropdown UI closer to design (#278)

* Rename OpenRequestDescription for clarity + code cleanup + test additions (#279)

* Notifications ducks cleanup + tests (#280)

* Notifications ducks cleanup + tests

* Fix issues

* Fix template for edge case of empty form (#281)

* Temporary debugging code, will revert

* Temporary debugging code, will revert

* Implement notification form confirmation (#289)

* Preserve compatibility in base_mail_client (#290)

* Notifications Configs + Doc (#291)

* Add notification config

* Code cleanup

* More cleanup + add a test

* Add some doc for how to enable features

* Add config utils test + fix type error

* Relative URLs to child configuration docs (#294)

* Relative URLs to child configuration docs

Relative URLs to docs in the same folder should do. They work for any branch, local copies of the docs - and should work better if we ever (or whenever :-) we get to having e.g a Sphinx generated site.

* Update application_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Remove temporary debugging code

* Improve behavior of notification sending for owner editing (#296)

* Initial Implementation: Notification only on success

* Cleanup + tests: Notification only on success

* Cleanup: Remove test code to trigger failure

* Cleanup: Lint fix

* Workaround for not notifying teams or alumni

* Cleanup: Remove import mistake

* Utilize NotificationType enums instead of hardcoded string

* Remove use of render_template

* More minor cleanups

* Address some feedback

* Cleanup

* More cleanup

* Updates for RequestMetadataForm

* Switch to generating a  for url + comment required for request column descriptions

* Update some tests + comment out ones that need update before merge

* Update some tests + comment out ones that need update before merge

* Code cleanup

* Update and rename notification_utils python tests

* Modify resource_url check + add docstrings for python tests

* Component cleanup

* Cleanup component tests

* Fix some typos
feng-tao pushed a commit that referenced this issue May 7, 2021
* Merge `master` into `feature/search_v2` (#253)

* Clean up doc (#249)

* Remove example folder in FE (#251)

* Add better logging for profile page views (#239)

* Added new search page layout (#250)

* Added SearchPanel to search page, with new wide layout
* Added 'ResourceSelector'

* Add SearchBar to NavBar + update styles (#252)

* Add SearchBar to NavBar + update styles

* Lint fix

* Code cleanup

* Fix tests

* Update ResourceListItem UI (#255)

* WIP

* Update layout

* Some code cleanup

* Tests

* Add some starter doc for the AppConfig

* Code cleanup + update UserListItem description UI

* start icon -> resource icon

* Moved Feedback tool to NavBar (#256)

* Update Feedback Component

* Update tests

* Clean up some styles

* reposition form

* Tweak feedback style

* Initial implementation of SearchFilter (#260)

* Initial implementation of SearchFilter

* Clean some code + add CheckBoxItem tests

* Fixed warning on ResourceSelector

* Add/fix some more tests

* Some tweaks before merge

* Implement New color theme (#276)

* Added a color palette file
* Replaced $gray-light/dark colors with semantic variables for each purpose
* Update brand colors to indigo

* Merge `master` into  `feature/search_v2` (#286)

* Update searchv2 master (#313)

* Clean up doc (#249)

* Remove example folder in FE (#251)

* Add better logging for profile page views (#239)

* add stalebot config (#264)

* Update stalebot setting (#268)

* Adds the request timeout configuration (#275)

* Adds the request timeout configuration

* Bumps the version to take advantage of request timeout

* Update AxiosError handling (#283)

* Update v0.ts

* lint fix

* Use Redux-Saga for Search Actions (#265)

* Added redux actions and sagas instead for each search action: `submitSearch`, `setResource`, `setPageIndex`, `loadPreviousSearch`, and `UrlDidUpdate`. This greatly simplifies the `SearchPage` logic in preparation for adding filters.
* Added `navigation-utils`.

* Removed `SQUASH COMMITS` from the PR template (#287)

Removed `SQUASH COMMITS` from the PR template

* TagInfo now fires 'submitSearch' instead of using navigation (#285)

* Remove render_template for feedback email (#293)

* Remove render_template for feedback email

* Fix html markup

* Added auto-select resource after searching (#292)

* Truncate the column type (#297)

* Truncate the column type

* Update truncation method

* Cleanup logic

* Improve table & columns description formatting (#98) (#298)

* Add support for React-Markdown to editable text fields
* Add support for windows via cross-env

* Update EditableText component (#299)

* Fix some styling issues with react-markdown
* Update EditableText to use React Refs instead of ref callbacks
* Add configs for table and column description max lengths

* Change 'json' to 'data' field for Python Requests (#303)

* Switch usage of 'json' to 'data' in metadata APIs
* Use 'raw_request=True' for Envoy client post/put APIs

* Update README.md (#302)

* Link deeper to doc content (#304)

Summary of Changes

Will scroll past GitHub repo folders (specially more handy on small screens like phones/tablets)
Like amundsen-io/amundsendatabuilder#147

* Fixed linebreaks with Markdown descriptions (#305)

* Amundsen Notifications Without Preferences (#273)

* Initial start to notifications API (#215)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* addressed comments regarding imports/enum naming

* fixed alphabetical order

* Notifs post email functionality (#222)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* added template support

* made changes to reflect private changes

* added helper function

* fixed lint issue

* addressed comments, added some type checking and cleaned up comments

* testing removing test

* fixed linter

* fixed lint

* fixed linting issues

* skip type checking

* fixed lint

* fixed typing on get request args

* removed typing for get request to fix lint issues

* fixed linter again

* re added test

* raise exception inside of getmailclient

* added exceptions

* addressed comments

* whitespace issue

* removed calls to get_query_param

* fixed syntax error

* Send notification when adding/removing owner from table (#237)

* basic e2e functionality for adding/removing

* send_notification refactor

* fix lint errors

* blank line lint error

* fixed syntax issue

* arg typing

* addressed comments, fixed code style

* Prevent Self-Notifications (#243)

* Prevent user from notifying themselves

* removed exception

* added owner check to send_notification

* Fixed return for no recipients (#244)

* fixed return for no recipients

* fixed linter issue

* Request notifications component (#238)

* init of request form

* basic request component

* getting basic functionality in

* clearing out css

* removed z-index fixes and add constants

* fixed string casting

* added redux-saga calls

* removed reset request notification

* fixed tests

* addressed comments, added basic test, added redux state management for opening/closing component

* added tests, just need to add render test

* cleaned up component tests:

* addressed html/css comments

* removed unecessary styling

* removed collapsed class

* cleaned up render method

* fixed test

* Open request component (#254)

* added button to open up request component

* removed tabledetail changes

* className styling

* fixed text-decoration

* added tests, changed naming for OpenRequest

* styling formatting

* Add, Request, and Remove Email Copy (#257)

* init for fixing email copy for request, add, and remove

* removed print statement

* fixed python unit test

* fixed linter issues

* addressed comments, fixed linter issues

* added notification unit test

* fixed test positional arg

* fix test

* Add notification action logging (#258)

* init of adding action logging

* changed location of action logging

* fixed linter errors

* fixed comment

* addressed comments

* remove request test call (#259)

* hide request if description already exists (#269)

* fixed open request button, request form styling (#267)

* Added request dropdown component (#262)

* init

* made fixes

* cleaned up code

* fixed color issues

* fixed import order

* fixed styling, changed ducks/sagas

* User dropdown (#263)

* init

* fixed sty;es

* fixed test issue

* fixed test

* added tests, addressed comments

* Request Metadata Component Tests (#270)

* added tests + readonly field to stop errors

* fixed tslint

* addressed comments, added header tests

* Request form navigation fix, dropdown fix (#272)

* Request form navigation fix, dropdown fix

* added test

* added unique id to dropdown

* Creates User Preferences page with no functionality (#266)

* init

* added event handlers

* removed test file

* added constants

* addressed comments

* fixed test, removed all links to page

* updated test

* fixed call to onclick

* removed preferences page

* Python cleanup + tests (#277)

* Python cleanup + tests

* More tests + revert some unecessary changes

* Bring dropdown UI closer to design (#278)

* Rename OpenRequestDescription for clarity + code cleanup + test additions (#279)

* Notifications ducks cleanup + tests (#280)

* Notifications ducks cleanup + tests

* Fix issues

* Fix template for edge case of empty form (#281)

* Temporary debugging code, will revert

* Temporary debugging code, will revert

* Implement notification form confirmation (#289)

* Preserve compatibility in base_mail_client (#290)

* Notifications Configs + Doc (#291)

* Add notification config

* Code cleanup

* More cleanup + add a test

* Add some doc for how to enable features

* Add config utils test + fix type error

* Relative URLs to child configuration docs (#294)

* Relative URLs to child configuration docs

Relative URLs to docs in the same folder should do. They work for any branch, local copies of the docs - and should work better if we ever (or whenever :-) we get to having e.g a Sphinx generated site.

* Update application_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Remove temporary debugging code

* Improve behavior of notification sending for owner editing (#296)

* Initial Implementation: Notification only on success

* Cleanup + tests: Notification only on success

* Cleanup: Remove test code to trigger failure

* Cleanup: Lint fix

* Workaround for not notifying teams or alumni

* Cleanup: Remove import mistake

* Utilize NotificationType enums instead of hardcoded string

* Remove use of render_template

* More minor cleanups

* Address some feedback

* Cleanup

* More cleanup

* Notifications Improvements (#301)

* Initial start to notifications API (#215)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* addressed comments regarding imports/enum naming

* fixed alphabetical order

* Notifs post email functionality (#222)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* added template support

* made changes to reflect private changes

* added helper function

* fixed lint issue

* addressed comments, added some type checking and cleaned up comments

* testing removing test

* fixed linter

* fixed lint

* fixed linting issues

* skip type checking

* fixed lint

* fixed typing on get request args

* removed typing for get request to fix lint issues

* fixed linter again

* re added test

* raise exception inside of getmailclient

* added exceptions

* addressed comments

* whitespace issue

* removed calls to get_query_param

* fixed syntax error

* Send notification when adding/removing owner from table (#237)

* basic e2e functionality for adding/removing

* send_notification refactor

* fix lint errors

* blank line lint error

* fixed syntax issue

* arg typing

* addressed comments, fixed code style

* Prevent Self-Notifications (#243)

* Prevent user from notifying themselves

* removed exception

* added owner check to send_notification

* Fixed return for no recipients (#244)

* fixed return for no recipients

* fixed linter issue

* Request notifications component (#238)

* init of request form

* basic request component

* getting basic functionality in

* clearing out css

* removed z-index fixes and add constants

* fixed string casting

* added redux-saga calls

* removed reset request notification

* fixed tests

* addressed comments, added basic test, added redux state management for opening/closing component

* added tests, just need to add render test

* cleaned up component tests:

* addressed html/css comments

* removed unecessary styling

* removed collapsed class

* cleaned up render method

* fixed test

* Open request component (#254)

* added button to open up request component

* removed tabledetail changes

* className styling

* fixed text-decoration

* added tests, changed naming for OpenRequest

* styling formatting

* Add, Request, and Remove Email Copy (#257)

* init for fixing email copy for request, add, and remove

* removed print statement

* fixed python unit test

* fixed linter issues

* addressed comments, fixed linter issues

* added notification unit test

* fixed test positional arg

* fix test

* Add notification action logging (#258)

* init of adding action logging

* changed location of action logging

* fixed linter errors

* fixed comment

* addressed comments

* remove request test call (#259)

* hide request if description already exists (#269)

* fixed open request button, request form styling (#267)

* Added request dropdown component (#262)

* init

* made fixes

* cleaned up code

* fixed color issues

* fixed import order

* fixed styling, changed ducks/sagas

* User dropdown (#263)

* init

* fixed sty;es

* fixed test issue

* fixed test

* added tests, addressed comments

* Request Metadata Component Tests (#270)

* added tests + readonly field to stop errors

* fixed tslint

* addressed comments, added header tests

* Request form navigation fix, dropdown fix (#272)

* Request form navigation fix, dropdown fix

* added test

* added unique id to dropdown

* Creates User Preferences page with no functionality (#266)

* init

* added event handlers

* removed test file

* added constants

* addressed comments

* fixed test, removed all links to page

* updated test

* fixed call to onclick

* removed preferences page

* Python cleanup + tests (#277)

* Python cleanup + tests

* More tests + revert some unecessary changes

* Bring dropdown UI closer to design (#278)

* Rename OpenRequestDescription for clarity + code cleanup + test additions (#279)

* Notifications ducks cleanup + tests (#280)

* Notifications ducks cleanup + tests

* Fix issues

* Fix template for edge case of empty form (#281)

* Temporary debugging code, will revert

* Temporary debugging code, will revert

* Implement notification form confirmation (#289)

* Preserve compatibility in base_mail_client (#290)

* Notifications Configs + Doc (#291)

* Add notification config

* Code cleanup

* More cleanup + add a test

* Add some doc for how to enable features

* Add config utils test + fix type error

* Relative URLs to child configuration docs (#294)

* Relative URLs to child configuration docs

Relative URLs to docs in the same folder should do. They work for any branch, local copies of the docs - and should work better if we ever (or whenever :-) we get to having e.g a Sphinx generated site.

* Update application_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Remove temporary debugging code

* Improve behavior of notification sending for owner editing (#296)

* Initial Implementation: Notification only on success

* Cleanup + tests: Notification only on success

* Cleanup: Remove test code to trigger failure

* Cleanup: Lint fix

* Workaround for not notifying teams or alumni

* Cleanup: Remove import mistake

* Utilize NotificationType enums instead of hardcoded string

* Remove use of render_template

* More minor cleanups

* Address some feedback

* Cleanup

* More cleanup

* Updates for RequestMetadataForm

* Switch to generating a  for url + comment required for request column descriptions

* Update some tests + comment out ones that need update before merge

* Update some tests + comment out ones that need update before merge

* Code cleanup

* Update and rename notification_utils python tests

* Modify resource_url check + add docstrings for python tests

* Component cleanup

* Cleanup component tests

* Fix some typos

* optimize docker (#300)

* Update developer_guide.md (#310)

Fix a 404

* Custom routes + Further notification cleanup (#309)

* Further notification cleanup

* Catch any errors getting the user for metrics + add doc for INIT_CUSTOM_ROUTES

* Revert change to _build_metrics

* Fix some merge conflicts

* Fix some merge conflicts

* Add source for notification email links (#312)

* Add source for notification email links

* Update TableDetail logic

* Fix FlashMessage styles

* Update config-types.ts (#314)

* Convert usages of `white` to `$white`

* - ResourceSelector now uses `setResource` action instead of onChange prop
- Added/fixed test cases for ResourceSelector/SearchPage
- Deleted unused code in SearchPage

* Added additional test cases for SearchBar

* Modified list-group shoadows

* Added a test case for ResourceSelector
feng-tao added a commit that referenced this issue May 7, 2021
* Druid metadata extractor

* add doc

* fix lint

* add extra deps

* Update version
@hkuchibhotla
Copy link

running into the same issue, any luck with getting this to work on ECS?

hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this issue Jun 30, 2022
* Druid metadata extractor

* add doc

* fix lint

* add extra deps

* Update version
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this issue Jun 30, 2022
* Initial start to notifications API (amundsen-io#215)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* addressed comments regarding imports/enum naming

* fixed alphabetical order

* Notifs post email functionality (amundsen-io#222)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* added template support

* made changes to reflect private changes

* added helper function

* fixed lint issue

* addressed comments, added some type checking and cleaned up comments

* testing removing test

* fixed linter

* fixed lint

* fixed linting issues

* skip type checking

* fixed lint

* fixed typing on get request args

* removed typing for get request to fix lint issues

* fixed linter again

* re added test

* raise exception inside of getmailclient

* added exceptions

* addressed comments

* whitespace issue

* removed calls to get_query_param

* fixed syntax error

* Send notification when adding/removing owner from table (amundsen-io#237)

* basic e2e functionality for adding/removing

* send_notification refactor

* fix lint errors

* blank line lint error

* fixed syntax issue

* arg typing

* addressed comments, fixed code style

* Prevent Self-Notifications (amundsen-io#243)

* Prevent user from notifying themselves

* removed exception

* added owner check to send_notification

* Fixed return for no recipients (amundsen-io#244)

* fixed return for no recipients

* fixed linter issue

* Request notifications component (amundsen-io#238)

* init of request form

* basic request component

* getting basic functionality in

* clearing out css

* removed z-index fixes and add constants

* fixed string casting

* added redux-saga calls

* removed reset request notification

* fixed tests

* addressed comments, added basic test, added redux state management for opening/closing component

* added tests, just need to add render test

* cleaned up component tests:

* addressed html/css comments

* removed unecessary styling

* removed collapsed class

* cleaned up render method

* fixed test

* Open request component (amundsen-io#254)

* added button to open up request component

* removed tabledetail changes

* className styling

* fixed text-decoration

* added tests, changed naming for OpenRequest

* styling formatting

* Add, Request, and Remove Email Copy (amundsen-io#257)

* init for fixing email copy for request, add, and remove

* removed print statement

* fixed python unit test

* fixed linter issues

* addressed comments, fixed linter issues

* added notification unit test

* fixed test positional arg

* fix test

* Add notification action logging (amundsen-io#258)

* init of adding action logging

* changed location of action logging

* fixed linter errors

* fixed comment

* addressed comments

* remove request test call (amundsen-io#259)

* hide request if description already exists (amundsen-io#269)

* fixed open request button, request form styling (amundsen-io#267)

* Added request dropdown component (amundsen-io#262)

* init

* made fixes

* cleaned up code

* fixed color issues

* fixed import order

* fixed styling, changed ducks/sagas

* User dropdown (amundsen-io#263)

* init

* fixed sty;es

* fixed test issue

* fixed test

* added tests, addressed comments

* Request Metadata Component Tests (amundsen-io#270)

* added tests + readonly field to stop errors

* fixed tslint

* addressed comments, added header tests

* Request form navigation fix, dropdown fix (amundsen-io#272)

* Request form navigation fix, dropdown fix

* added test

* added unique id to dropdown

* Creates User Preferences page with no functionality (amundsen-io#266)

* init

* added event handlers

* removed test file

* added constants

* addressed comments

* fixed test, removed all links to page

* updated test

* fixed call to onclick

* removed preferences page

* Python cleanup + tests (amundsen-io#277)

* Python cleanup + tests

* More tests + revert some unecessary changes

* Bring dropdown UI closer to design (amundsen-io#278)

* Rename OpenRequestDescription for clarity + code cleanup + test additions (amundsen-io#279)

* Notifications ducks cleanup + tests (amundsen-io#280)

* Notifications ducks cleanup + tests

* Fix issues

* Fix template for edge case of empty form (amundsen-io#281)

* Temporary debugging code, will revert

* Temporary debugging code, will revert

* Implement notification form confirmation (amundsen-io#289)

* Preserve compatibility in base_mail_client (amundsen-io#290)

* Notifications Configs + Doc (amundsen-io#291)

* Add notification config

* Code cleanup

* More cleanup + add a test

* Add some doc for how to enable features

* Add config utils test + fix type error

* Relative URLs to child configuration docs (amundsen-io#294)

* Relative URLs to child configuration docs

Relative URLs to docs in the same folder should do. They work for any branch, local copies of the docs - and should work better if we ever (or whenever :-) we get to having e.g a Sphinx generated site.

* Update application_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Remove temporary debugging code

* Improve behavior of notification sending for owner editing (amundsen-io#296)

* Initial Implementation: Notification only on success

* Cleanup + tests: Notification only on success

* Cleanup: Remove test code to trigger failure

* Cleanup: Lint fix

* Workaround for not notifying teams or alumni

* Cleanup: Remove import mistake

* Utilize NotificationType enums instead of hardcoded string

* Remove use of render_template

* More minor cleanups

* Address some feedback

* Cleanup

* More cleanup
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this issue Jun 30, 2022
* Initial start to notifications API (amundsen-io#215)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* addressed comments regarding imports/enum naming

* fixed alphabetical order

* Notifs post email functionality (amundsen-io#222)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* added template support

* made changes to reflect private changes

* added helper function

* fixed lint issue

* addressed comments, added some type checking and cleaned up comments

* testing removing test

* fixed linter

* fixed lint

* fixed linting issues

* skip type checking

* fixed lint

* fixed typing on get request args

* removed typing for get request to fix lint issues

* fixed linter again

* re added test

* raise exception inside of getmailclient

* added exceptions

* addressed comments

* whitespace issue

* removed calls to get_query_param

* fixed syntax error

* Send notification when adding/removing owner from table (amundsen-io#237)

* basic e2e functionality for adding/removing

* send_notification refactor

* fix lint errors

* blank line lint error

* fixed syntax issue

* arg typing

* addressed comments, fixed code style

* Prevent Self-Notifications (amundsen-io#243)

* Prevent user from notifying themselves

* removed exception

* added owner check to send_notification

* Fixed return for no recipients (amundsen-io#244)

* fixed return for no recipients

* fixed linter issue

* Request notifications component (amundsen-io#238)

* init of request form

* basic request component

* getting basic functionality in

* clearing out css

* removed z-index fixes and add constants

* fixed string casting

* added redux-saga calls

* removed reset request notification

* fixed tests

* addressed comments, added basic test, added redux state management for opening/closing component

* added tests, just need to add render test

* cleaned up component tests:

* addressed html/css comments

* removed unecessary styling

* removed collapsed class

* cleaned up render method

* fixed test

* Open request component (amundsen-io#254)

* added button to open up request component

* removed tabledetail changes

* className styling

* fixed text-decoration

* added tests, changed naming for OpenRequest

* styling formatting

* Add, Request, and Remove Email Copy (amundsen-io#257)

* init for fixing email copy for request, add, and remove

* removed print statement

* fixed python unit test

* fixed linter issues

* addressed comments, fixed linter issues

* added notification unit test

* fixed test positional arg

* fix test

* Add notification action logging (amundsen-io#258)

* init of adding action logging

* changed location of action logging

* fixed linter errors

* fixed comment

* addressed comments

* remove request test call (amundsen-io#259)

* hide request if description already exists (amundsen-io#269)

* fixed open request button, request form styling (amundsen-io#267)

* Added request dropdown component (amundsen-io#262)

* init

* made fixes

* cleaned up code

* fixed color issues

* fixed import order

* fixed styling, changed ducks/sagas

* User dropdown (amundsen-io#263)

* init

* fixed sty;es

* fixed test issue

* fixed test

* added tests, addressed comments

* Request Metadata Component Tests (amundsen-io#270)

* added tests + readonly field to stop errors

* fixed tslint

* addressed comments, added header tests

* Request form navigation fix, dropdown fix (amundsen-io#272)

* Request form navigation fix, dropdown fix

* added test

* added unique id to dropdown

* Creates User Preferences page with no functionality (amundsen-io#266)

* init

* added event handlers

* removed test file

* added constants

* addressed comments

* fixed test, removed all links to page

* updated test

* fixed call to onclick

* removed preferences page

* Python cleanup + tests (amundsen-io#277)

* Python cleanup + tests

* More tests + revert some unecessary changes

* Bring dropdown UI closer to design (amundsen-io#278)

* Rename OpenRequestDescription for clarity + code cleanup + test additions (amundsen-io#279)

* Notifications ducks cleanup + tests (amundsen-io#280)

* Notifications ducks cleanup + tests

* Fix issues

* Fix template for edge case of empty form (amundsen-io#281)

* Temporary debugging code, will revert

* Temporary debugging code, will revert

* Implement notification form confirmation (amundsen-io#289)

* Preserve compatibility in base_mail_client (amundsen-io#290)

* Notifications Configs + Doc (amundsen-io#291)

* Add notification config

* Code cleanup

* More cleanup + add a test

* Add some doc for how to enable features

* Add config utils test + fix type error

* Relative URLs to child configuration docs (amundsen-io#294)

* Relative URLs to child configuration docs

Relative URLs to docs in the same folder should do. They work for any branch, local copies of the docs - and should work better if we ever (or whenever :-) we get to having e.g a Sphinx generated site.

* Update application_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Remove temporary debugging code

* Improve behavior of notification sending for owner editing (amundsen-io#296)

* Initial Implementation: Notification only on success

* Cleanup + tests: Notification only on success

* Cleanup: Remove test code to trigger failure

* Cleanup: Lint fix

* Workaround for not notifying teams or alumni

* Cleanup: Remove import mistake

* Utilize NotificationType enums instead of hardcoded string

* Remove use of render_template

* More minor cleanups

* Address some feedback

* Cleanup

* More cleanup

* Updates for RequestMetadataForm

* Switch to generating a  for url + comment required for request column descriptions

* Update some tests + comment out ones that need update before merge

* Update some tests + comment out ones that need update before merge

* Code cleanup

* Update and rename notification_utils python tests

* Modify resource_url check + add docstrings for python tests

* Component cleanup

* Cleanup component tests

* Fix some typos
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this issue Jun 30, 2022
* Merge `master` into `feature/search_v2` (amundsen-io#253)

* Clean up doc (amundsen-io#249)

* Remove example folder in FE (amundsen-io#251)

* Add better logging for profile page views (amundsen-io#239)

* Added new search page layout (amundsen-io#250)

* Added SearchPanel to search page, with new wide layout
* Added 'ResourceSelector'

* Add SearchBar to NavBar + update styles (amundsen-io#252)

* Add SearchBar to NavBar + update styles

* Lint fix

* Code cleanup

* Fix tests

* Update ResourceListItem UI (amundsen-io#255)

* WIP

* Update layout

* Some code cleanup

* Tests

* Add some starter doc for the AppConfig

* Code cleanup + update UserListItem description UI

* start icon -> resource icon

* Moved Feedback tool to NavBar (amundsen-io#256)

* Update Feedback Component

* Update tests

* Clean up some styles

* reposition form

* Tweak feedback style

* Initial implementation of SearchFilter (amundsen-io#260)

* Initial implementation of SearchFilter

* Clean some code + add CheckBoxItem tests

* Fixed warning on ResourceSelector

* Add/fix some more tests

* Some tweaks before merge

* Implement New color theme (amundsen-io#276)

* Added a color palette file
* Replaced $gray-light/dark colors with semantic variables for each purpose
* Update brand colors to indigo

* Merge `master` into  `feature/search_v2` (amundsen-io#286)

* Update searchv2 master (amundsen-io#313)

* Clean up doc (amundsen-io#249)

* Remove example folder in FE (amundsen-io#251)

* Add better logging for profile page views (amundsen-io#239)

* add stalebot config (amundsen-io#264)

* Update stalebot setting (amundsen-io#268)

* Adds the request timeout configuration (amundsen-io#275)

* Adds the request timeout configuration

* Bumps the version to take advantage of request timeout

* Update AxiosError handling (amundsen-io#283)

* Update v0.ts

* lint fix

* Use Redux-Saga for Search Actions (amundsen-io#265)

* Added redux actions and sagas instead for each search action: `submitSearch`, `setResource`, `setPageIndex`, `loadPreviousSearch`, and `UrlDidUpdate`. This greatly simplifies the `SearchPage` logic in preparation for adding filters.
* Added `navigation-utils`.

* Removed `SQUASH COMMITS` from the PR template (amundsen-io#287)

Removed `SQUASH COMMITS` from the PR template

* TagInfo now fires 'submitSearch' instead of using navigation (amundsen-io#285)

* Remove render_template for feedback email (amundsen-io#293)

* Remove render_template for feedback email

* Fix html markup

* Added auto-select resource after searching (amundsen-io#292)

* Truncate the column type (amundsen-io#297)

* Truncate the column type

* Update truncation method

* Cleanup logic

* Improve table & columns description formatting (amundsen-io#98) (amundsen-io#298)

* Add support for React-Markdown to editable text fields
* Add support for windows via cross-env

* Update EditableText component (amundsen-io#299)

* Fix some styling issues with react-markdown
* Update EditableText to use React Refs instead of ref callbacks
* Add configs for table and column description max lengths

* Change 'json' to 'data' field for Python Requests (amundsen-io#303)

* Switch usage of 'json' to 'data' in metadata APIs
* Use 'raw_request=True' for Envoy client post/put APIs

* Update README.md (amundsen-io#302)

* Link deeper to doc content (amundsen-io#304)

Summary of Changes

Will scroll past GitHub repo folders (specially more handy on small screens like phones/tablets)
Like amundsen-io/amundsendatabuilder#147

* Fixed linebreaks with Markdown descriptions (amundsen-io#305)

* Amundsen Notifications Without Preferences (amundsen-io#273)

* Initial start to notifications API (amundsen-io#215)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* addressed comments regarding imports/enum naming

* fixed alphabetical order

* Notifs post email functionality (amundsen-io#222)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* added template support

* made changes to reflect private changes

* added helper function

* fixed lint issue

* addressed comments, added some type checking and cleaned up comments

* testing removing test

* fixed linter

* fixed lint

* fixed linting issues

* skip type checking

* fixed lint

* fixed typing on get request args

* removed typing for get request to fix lint issues

* fixed linter again

* re added test

* raise exception inside of getmailclient

* added exceptions

* addressed comments

* whitespace issue

* removed calls to get_query_param

* fixed syntax error

* Send notification when adding/removing owner from table (amundsen-io#237)

* basic e2e functionality for adding/removing

* send_notification refactor

* fix lint errors

* blank line lint error

* fixed syntax issue

* arg typing

* addressed comments, fixed code style

* Prevent Self-Notifications (amundsen-io#243)

* Prevent user from notifying themselves

* removed exception

* added owner check to send_notification

* Fixed return for no recipients (amundsen-io#244)

* fixed return for no recipients

* fixed linter issue

* Request notifications component (amundsen-io#238)

* init of request form

* basic request component

* getting basic functionality in

* clearing out css

* removed z-index fixes and add constants

* fixed string casting

* added redux-saga calls

* removed reset request notification

* fixed tests

* addressed comments, added basic test, added redux state management for opening/closing component

* added tests, just need to add render test

* cleaned up component tests:

* addressed html/css comments

* removed unecessary styling

* removed collapsed class

* cleaned up render method

* fixed test

* Open request component (amundsen-io#254)

* added button to open up request component

* removed tabledetail changes

* className styling

* fixed text-decoration

* added tests, changed naming for OpenRequest

* styling formatting

* Add, Request, and Remove Email Copy (amundsen-io#257)

* init for fixing email copy for request, add, and remove

* removed print statement

* fixed python unit test

* fixed linter issues

* addressed comments, fixed linter issues

* added notification unit test

* fixed test positional arg

* fix test

* Add notification action logging (amundsen-io#258)

* init of adding action logging

* changed location of action logging

* fixed linter errors

* fixed comment

* addressed comments

* remove request test call (amundsen-io#259)

* hide request if description already exists (amundsen-io#269)

* fixed open request button, request form styling (amundsen-io#267)

* Added request dropdown component (amundsen-io#262)

* init

* made fixes

* cleaned up code

* fixed color issues

* fixed import order

* fixed styling, changed ducks/sagas

* User dropdown (amundsen-io#263)

* init

* fixed sty;es

* fixed test issue

* fixed test

* added tests, addressed comments

* Request Metadata Component Tests (amundsen-io#270)

* added tests + readonly field to stop errors

* fixed tslint

* addressed comments, added header tests

* Request form navigation fix, dropdown fix (amundsen-io#272)

* Request form navigation fix, dropdown fix

* added test

* added unique id to dropdown

* Creates User Preferences page with no functionality (amundsen-io#266)

* init

* added event handlers

* removed test file

* added constants

* addressed comments

* fixed test, removed all links to page

* updated test

* fixed call to onclick

* removed preferences page

* Python cleanup + tests (amundsen-io#277)

* Python cleanup + tests

* More tests + revert some unecessary changes

* Bring dropdown UI closer to design (amundsen-io#278)

* Rename OpenRequestDescription for clarity + code cleanup + test additions (amundsen-io#279)

* Notifications ducks cleanup + tests (amundsen-io#280)

* Notifications ducks cleanup + tests

* Fix issues

* Fix template for edge case of empty form (amundsen-io#281)

* Temporary debugging code, will revert

* Temporary debugging code, will revert

* Implement notification form confirmation (amundsen-io#289)

* Preserve compatibility in base_mail_client (amundsen-io#290)

* Notifications Configs + Doc (amundsen-io#291)

* Add notification config

* Code cleanup

* More cleanup + add a test

* Add some doc for how to enable features

* Add config utils test + fix type error

* Relative URLs to child configuration docs (amundsen-io#294)

* Relative URLs to child configuration docs

Relative URLs to docs in the same folder should do. They work for any branch, local copies of the docs - and should work better if we ever (or whenever :-) we get to having e.g a Sphinx generated site.

* Update application_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Remove temporary debugging code

* Improve behavior of notification sending for owner editing (amundsen-io#296)

* Initial Implementation: Notification only on success

* Cleanup + tests: Notification only on success

* Cleanup: Remove test code to trigger failure

* Cleanup: Lint fix

* Workaround for not notifying teams or alumni

* Cleanup: Remove import mistake

* Utilize NotificationType enums instead of hardcoded string

* Remove use of render_template

* More minor cleanups

* Address some feedback

* Cleanup

* More cleanup

* Notifications Improvements (amundsen-io#301)

* Initial start to notifications API (amundsen-io#215)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* addressed comments regarding imports/enum naming

* fixed alphabetical order

* Notifs post email functionality (amundsen-io#222)

* initial start to notifications API

* fixing some styling

* fixed lint errors

* update types

* added tests

* linter, moved notification types

* added template support

* made changes to reflect private changes

* added helper function

* fixed lint issue

* addressed comments, added some type checking and cleaned up comments

* testing removing test

* fixed linter

* fixed lint

* fixed linting issues

* skip type checking

* fixed lint

* fixed typing on get request args

* removed typing for get request to fix lint issues

* fixed linter again

* re added test

* raise exception inside of getmailclient

* added exceptions

* addressed comments

* whitespace issue

* removed calls to get_query_param

* fixed syntax error

* Send notification when adding/removing owner from table (amundsen-io#237)

* basic e2e functionality for adding/removing

* send_notification refactor

* fix lint errors

* blank line lint error

* fixed syntax issue

* arg typing

* addressed comments, fixed code style

* Prevent Self-Notifications (amundsen-io#243)

* Prevent user from notifying themselves

* removed exception

* added owner check to send_notification

* Fixed return for no recipients (amundsen-io#244)

* fixed return for no recipients

* fixed linter issue

* Request notifications component (amundsen-io#238)

* init of request form

* basic request component

* getting basic functionality in

* clearing out css

* removed z-index fixes and add constants

* fixed string casting

* added redux-saga calls

* removed reset request notification

* fixed tests

* addressed comments, added basic test, added redux state management for opening/closing component

* added tests, just need to add render test

* cleaned up component tests:

* addressed html/css comments

* removed unecessary styling

* removed collapsed class

* cleaned up render method

* fixed test

* Open request component (amundsen-io#254)

* added button to open up request component

* removed tabledetail changes

* className styling

* fixed text-decoration

* added tests, changed naming for OpenRequest

* styling formatting

* Add, Request, and Remove Email Copy (amundsen-io#257)

* init for fixing email copy for request, add, and remove

* removed print statement

* fixed python unit test

* fixed linter issues

* addressed comments, fixed linter issues

* added notification unit test

* fixed test positional arg

* fix test

* Add notification action logging (amundsen-io#258)

* init of adding action logging

* changed location of action logging

* fixed linter errors

* fixed comment

* addressed comments

* remove request test call (amundsen-io#259)

* hide request if description already exists (amundsen-io#269)

* fixed open request button, request form styling (amundsen-io#267)

* Added request dropdown component (amundsen-io#262)

* init

* made fixes

* cleaned up code

* fixed color issues

* fixed import order

* fixed styling, changed ducks/sagas

* User dropdown (amundsen-io#263)

* init

* fixed sty;es

* fixed test issue

* fixed test

* added tests, addressed comments

* Request Metadata Component Tests (amundsen-io#270)

* added tests + readonly field to stop errors

* fixed tslint

* addressed comments, added header tests

* Request form navigation fix, dropdown fix (amundsen-io#272)

* Request form navigation fix, dropdown fix

* added test

* added unique id to dropdown

* Creates User Preferences page with no functionality (amundsen-io#266)

* init

* added event handlers

* removed test file

* added constants

* addressed comments

* fixed test, removed all links to page

* updated test

* fixed call to onclick

* removed preferences page

* Python cleanup + tests (amundsen-io#277)

* Python cleanup + tests

* More tests + revert some unecessary changes

* Bring dropdown UI closer to design (amundsen-io#278)

* Rename OpenRequestDescription for clarity + code cleanup + test additions (amundsen-io#279)

* Notifications ducks cleanup + tests (amundsen-io#280)

* Notifications ducks cleanup + tests

* Fix issues

* Fix template for edge case of empty form (amundsen-io#281)

* Temporary debugging code, will revert

* Temporary debugging code, will revert

* Implement notification form confirmation (amundsen-io#289)

* Preserve compatibility in base_mail_client (amundsen-io#290)

* Notifications Configs + Doc (amundsen-io#291)

* Add notification config

* Code cleanup

* More cleanup + add a test

* Add some doc for how to enable features

* Add config utils test + fix type error

* Relative URLs to child configuration docs (amundsen-io#294)

* Relative URLs to child configuration docs

Relative URLs to docs in the same folder should do. They work for any branch, local copies of the docs - and should work better if we ever (or whenever :-) we get to having e.g a Sphinx generated site.

* Update application_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Update flask_config.md

Relative doc link

* Remove temporary debugging code

* Improve behavior of notification sending for owner editing (amundsen-io#296)

* Initial Implementation: Notification only on success

* Cleanup + tests: Notification only on success

* Cleanup: Remove test code to trigger failure

* Cleanup: Lint fix

* Workaround for not notifying teams or alumni

* Cleanup: Remove import mistake

* Utilize NotificationType enums instead of hardcoded string

* Remove use of render_template

* More minor cleanups

* Address some feedback

* Cleanup

* More cleanup

* Updates for RequestMetadataForm

* Switch to generating a  for url + comment required for request column descriptions

* Update some tests + comment out ones that need update before merge

* Update some tests + comment out ones that need update before merge

* Code cleanup

* Update and rename notification_utils python tests

* Modify resource_url check + add docstrings for python tests

* Component cleanup

* Cleanup component tests

* Fix some typos

* optimize docker (amundsen-io#300)

* Update developer_guide.md (amundsen-io#310)

Fix a 404

* Custom routes + Further notification cleanup (amundsen-io#309)

* Further notification cleanup

* Catch any errors getting the user for metrics + add doc for INIT_CUSTOM_ROUTES

* Revert change to _build_metrics

* Fix some merge conflicts

* Fix some merge conflicts

* Add source for notification email links (amundsen-io#312)

* Add source for notification email links

* Update TableDetail logic

* Fix FlashMessage styles

* Update config-types.ts (amundsen-io#314)

* Convert usages of `white` to `$white`

* - ResourceSelector now uses `setResource` action instead of onChange prop
- Added/fixed test cases for ResourceSelector/SearchPage
- Deleted unused code in SearchPage

* Added additional test cases for SearchBar

* Modified list-group shoadows

* Added a test case for ResourceSelector
@Golodhros Golodhros added status:needs_votes Issue or bug fix that needs support from the community to be considered and removed keep fresh Disables stalebot from closing an issue labels Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:needs_reproducing For bugs that need to be reproduced in order to get fixed status:needs_votes Issue or bug fix that needs support from the community to be considered type:bug An unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants