Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggestions for more consistent field names in Executor #83

Merged
merged 3 commits into from
Nov 10, 2017
Merged

suggestions for more consistent field names in Executor #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
637c28d
suggestions for more consistent field names in Executor
prismofeverything Oct 15, 2017
db3880b
Merge branch 'master' of https://github.com/ga4gh/task-execution-sche…
prismofeverything Nov 8, 2017
f04f253
changed names to image and command in README
prismofeverything Nov 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ an MD5 checksum on an input file and uploads the output:
},
"executors" : [
{
"image_name" : "ubuntu",
"cmd" : ["md5sum", "/container/input"],
"image" : "ubuntu",
"command" : ["md5sum", "/container/input"],
"stdout" : "/container/output",
"stderr" : "/container/stderr",
"workdir": "/tmp"
Expand All @@ -73,8 +73,8 @@ A minimal version of the same task, including only the required fields looks lik
],
"executors" : [
{
"image_name" : "ubuntu",
"cmd" : ["md5sum", "/container/input"],
"image" : "ubuntu",
"command" : ["md5sum", "/container/input"],
"stdout" : "/container/output"
}
]
Expand Down
6 changes: 3 additions & 3 deletions task_execution.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,13 +142,13 @@ message Executor {
// quay.io/aptible/ubuntu
// gcr.io/my-org/my-image
// etc...
string image_name = 1;
string image = 1;

// REQUIRED
//
// A sequence of program arguments to execute, where the first argument
// is the program to execute (i.e. argv).
repeated string cmd = 2;
repeated string command = 2;

// OPTIONAL
//
Expand Down Expand Up @@ -186,7 +186,7 @@ message Executor {
// OPTIONAL
//
// Enviromental variables to set within the container.
map<string,string> environ = 8;
map<string,string> env = 8;
}

// Resources describes the resources requested by a task.
Expand Down