Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestions for more consistent field names in Executor #83

Merged
merged 3 commits into from
Nov 10, 2017

Conversation

prismofeverything
Copy link
Contributor

Going through the schema and implementing a remote interface for funnel, all of the field names are so concise and elegant that these three field names stuck out.

I am proposing three changes:

  • image_name --> image

Most of the other fields throughout the schema are single names, and the word image does not need to be disambiguated with any other fields in the schema, so this seems like the natural choice.

  • cmd --> command

The schema is refreshingly light on abbreviated names to the point where this one stands out. Why not just command?

  • environ --> env

This one is funny because it is really just a different abbreviation of environment. I would almost prefer environment since it is nice to be clear, but we have such a long-standing tradition of using the three letters ENV to stand for the environment (even the bash program called env) that I think this one makes sense.

Open to all thoughts and ideas on this.

@briandoconnor
Copy link
Contributor

Changes seems fine to me

@geoffjentry
Copy link
Contributor

👍 this all seems right

@pditommaso
Copy link

👍

@buchanae
Copy link
Contributor

buchanae commented Nov 3, 2017

@prismofeverything can you update the README as well please?

@prismofeverything
Copy link
Contributor Author

Okay, done.

@kellrott kellrott merged commit 23b4412 into ga4gh:master Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants