suggestions for more consistent field names in Executor #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going through the schema and implementing a remote interface for funnel, all of the field names are so concise and elegant that these three field names stuck out.
I am proposing three changes:
Most of the other fields throughout the schema are single names, and the word
image
does not need to be disambiguated with any other fields in the schema, so this seems like the natural choice.The schema is refreshingly light on abbreviated names to the point where this one stands out. Why not just
command
?This one is funny because it is really just a different abbreviation of
environment
. I would almost preferenvironment
since it is nice to be clear, but we have such a long-standing tradition of using the three letters ENV to stand for the environment (even the bash program calledenv
) that I think this one makes sense.Open to all thoughts and ideas on this.