Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change the last release branch to mondays release branch #3222

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

arjunaj5
Copy link
Contributor

@arjunaj5 arjunaj5 commented Oct 10, 2024

Clickup

https://app.clickup.com

Code Coverage

Please add code coverage here

UI Preview

Please add screenshots for UI changes

Summary by CodeRabbit

  • Chores
    • Updated the logic for determining the last release branch name to reference the last Monday instead of the last Friday.
    • Cron schedule remains unchanged, running every Monday at 11:30 AM UTC.

@github-actions github-actions bot added the size/XS Extra Small PR label Oct 10, 2024
Copy link

PR description must contain a link to a ClickUp (case-insensitive)

@arjunaj5 arjunaj5 changed the base branch from Fyle-create-release-mon to master October 15, 2024 05:07
Copy link

coderabbitai bot commented Oct 15, 2024

Walkthrough

The pull request modifies the workflow file .github/workflows/create-release-branch.yml to update the logic for determining the last release branch name. The cron schedule remains unchanged, running every Monday at 11:30 AM UTC. The key change is that the last_release_branch environment variable is now set to the date of the last Monday instead of the last Friday, affecting the branch naming convention in subsequent workflow steps.

Changes

File Change Summary
.github/workflows/create-release-branch.yml Updated logic for last_release_branch to use last Monday's date instead of last Friday's. Cron schedule remains unchanged.

Possibly related PRs

Suggested reviewers

  • suyashpatil78
  • Chethan-Fyle

🎉 In the land of code where branches grow,
A tweak was made, and now we know,
Mondays guide the naming spree,
A fresh release for you and me!
So raise a cheer, let’s celebrate,
Our branches bloom, oh isn’t it great! 🌿


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between 46ee637 and 4c5304b.

📒 Files selected for processing (1)
  • .github/workflows/create-release-branch.yml (1 hunks)
🧰 Additional context used
🔇 Additional comments (2)
.github/workflows/create-release-branch.yml (2)

Line range hint 1-46: Workflow integrity maintained.

The modification to the last_release_branch variable is the only change in this file. The rest of the workflow, including the cron schedule, branch creation logic, and Slack notification, remains intact. This change does not introduce any conflicts or issues with the existing workflow structure.

Ensure that the team is aware of the new diff comparison scope in the Slack notifications, as it now covers a full week from Monday to Monday, rather than Friday to Monday.

🧰 Tools
🪛 actionlint

15-15: shellcheck reported issue in this script: SC2086:info:1:59: Double quote to prevent globbing and word splitting

(shellcheck)


15-15: shellcheck reported issue in this script: SC2086:info:2:81: Double quote to prevent globbing and word splitting

(shellcheck)


19-19: shellcheck reported issue in this script: SC2086:info:2:32: Double quote to prevent globbing and word splitting

(shellcheck)


19-19: shellcheck reported issue in this script: SC2086:info:4:33: Double quote to prevent globbing and word splitting

(shellcheck)


17-17: Modification of last release branch naming convention.

The change from using the last Friday to the last Monday for the last_release_branch variable is logically sound. It aligns with the workflow's Monday execution schedule, ensuring that the diff comparison in the Slack notification covers the most recent weekly cycle.

However, be aware that this change will affect the scope of changes included in the diff comparison URL. Ensure all stakeholders are informed about this modification to prevent any confusion in change tracking.

To verify the impact of this change, execute the following script:

✅ Verification successful

Verification Complete: last_release_branch change is correctly localized and consistent.

The update to use the last Monday for last_release_branch is properly implemented within .github/workflows/create-release-branch.yml and does not affect other workflows.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of last_release_branch in the workflow

# Test: Check if last_release_branch is used consistently
rg --type yaml 'last_release_branch' .github/workflows/create-release-branch.yml

# Test: Ensure no other workflows are affected by this change
rg --type yaml 'last_release_branch' .github/workflows

Length of output: 757


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

PR description must contain a link to a ClickUp (case-insensitive)

2 similar comments
Copy link

PR description must contain a link to a ClickUp (case-insensitive)

Copy link

PR description must contain a link to a ClickUp (case-insensitive)

Copy link

Unit Test Coverage % values
Statements 95.87% ( 19140 / 19964 )
Branches 91.11% ( 10532 / 11559 )
Functions 94.28% ( 5707 / 6053 )
Lines 95.9% ( 18271 / 19051 )

@arjunaj5 arjunaj5 merged commit adc6faf into master Oct 15, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Extra Small PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants