-
Notifications
You must be signed in to change notification settings - Fork 15
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: migrate public currency and exchange rate api to platform (#3220)
- Loading branch information
1 parent
fb10289
commit 46ee637
Showing
8 changed files
with
158 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| export interface ExchangeRateResponse { | ||
| exchange_rate: number; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| import { TestBed } from '@angular/core/testing'; | ||
| import { PlatformCommonApiService } from './platform-common-api.service'; | ||
| import { HttpTestingController, HttpClientTestingModule } from '@angular/common/http/testing'; | ||
| import { HttpClient } from '@angular/common/http'; | ||
| import { of } from 'rxjs'; | ||
|
|
||
| const requestObj = { | ||
| someKey: 'someValue', | ||
| }; | ||
|
|
||
| const apiResponse = { | ||
| message: 'SUCCESS', | ||
| }; | ||
|
|
||
| describe('PlatformCommonApiService', () => { | ||
| let platformCommonApiService: PlatformCommonApiService; | ||
| let httpTestingController: HttpTestingController; | ||
| let httpClient: jasmine.SpyObj<HttpClient>; | ||
| const rootUrl = 'https://staging.fyle.tech'; | ||
|
|
||
| beforeEach(() => { | ||
| const httpClientSpy = jasmine.createSpyObj('HttpClient', ['get', 'post']); | ||
|
|
||
| TestBed.configureTestingModule({ | ||
| imports: [HttpClientTestingModule], | ||
| providers: [ | ||
| PlatformCommonApiService, | ||
| { | ||
| provide: HttpClient, | ||
| useValue: httpClientSpy, | ||
| }, | ||
| ], | ||
| }); | ||
| platformCommonApiService = TestBed.inject(PlatformCommonApiService); | ||
| httpTestingController = TestBed.inject(HttpTestingController); | ||
| httpClient = TestBed.inject(HttpClient) as jasmine.SpyObj<HttpClient>; | ||
| platformCommonApiService.setRoot(rootUrl); | ||
| }); | ||
|
|
||
| it('should be created', () => { | ||
| expect(platformCommonApiService).toBeTruthy(); | ||
| }); | ||
|
|
||
| it('setRoot(): should set root url', () => { | ||
| expect(platformCommonApiService.ROOT_ENDPOINT).toBe(rootUrl); | ||
| }); | ||
|
|
||
| describe('get():', () => { | ||
| it('should make GET request without params', (done) => { | ||
| httpClient.get.and.returnValue(of(apiResponse)); | ||
|
|
||
| platformCommonApiService.get('/currency/list').subscribe((res) => { | ||
| expect(res).toEqual(apiResponse); | ||
| expect(httpClient.get).toHaveBeenCalledOnceWith( | ||
| 'https://staging.fyle.tech/platform/v1/common/currency/list', | ||
| {} | ||
| ); | ||
| done(); | ||
| }); | ||
| }); | ||
|
|
||
| it('should make GET request with params', (done) => { | ||
| httpClient.get.and.returnValue(of(apiResponse)); | ||
|
|
||
| platformCommonApiService.get('/currency/exchange_rate', { params: requestObj }).subscribe((res) => { | ||
| expect(res).toEqual(apiResponse); | ||
| expect(httpClient.get).toHaveBeenCalledOnceWith( | ||
| 'https://staging.fyle.tech/platform/v1/common/currency/exchange_rate', | ||
| { | ||
| params: requestObj, | ||
| } | ||
| ); | ||
| done(); | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| httpTestingController.verify(); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { HttpClient } from '@angular/common/http'; | ||
| import { Injectable } from '@angular/core'; | ||
| import { Observable } from 'rxjs'; | ||
| import { environment } from 'src/environments/environment'; | ||
|
|
||
| @Injectable({ | ||
| providedIn: 'root', | ||
| }) | ||
| export class PlatformCommonApiService { | ||
| ROOT_ENDPOINT: string; | ||
|
|
||
| constructor(private httpClient: HttpClient) { | ||
| this.ROOT_ENDPOINT = environment.ROOT_URL; | ||
| } | ||
|
|
||
| setRoot(rootUrl: string): void { | ||
| this.ROOT_ENDPOINT = rootUrl; | ||
| } | ||
|
|
||
| get<T>(url: string, config = {}): Observable<T> { | ||
| return this.httpClient.get<T>(this.ROOT_ENDPOINT + '/platform/v1/common' + url, config); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters