Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Added unit test cases for dismiss dialog #3176

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

devendrafyle
Copy link
Contributor

Copy link
Contributor

@Dimple16 Dimple16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comments

});

describe('dismiss():', () => {
it('should dismiss item', (done) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should dismiss expense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep updated

@devendrafyle devendrafyle requested a review from Dimple16 August 20, 2024 08:48
Copy link

Unit Test Coverage % values
Statements 95.84% ( 19056 / 19882 )
Branches 91.13% ( 10417 / 11430 )
Functions 94.2% ( 5702 / 6053 )
Lines 95.87% ( 18187 / 18969 )

@devendrafyle devendrafyle merged commit e9a682a into FYLE-86cw6epah Aug 26, 2024
6 checks passed
devendrafyle added a commit that referenced this pull request Aug 27, 2024
* feat: Dismiss dialog for potential duplicate expenses

* minor fixes

* minor comment fixes

* removed not required model

* removed not used model file

* test: Added unit test cases for dismiss dialog (#3176)

* test: Added unit test cases for dismiss dialog

* added more test cases and fixed minor comments

---------

Co-authored-by: Devendra Singh Rana <devendra@Devendras-MacBook-Air.local>

* improve unit test coverage

---------

Co-authored-by: Devendra Singh Rana <devendra@Devendras-MacBook-Air.local>
devendrafyle added a commit that referenced this pull request Aug 28, 2024
* feat: Dismiss dialog for potential duplicate expenses

* minor fixes

* minor comment fixes

* removed not required model

* removed not used model file

* test: Added unit test cases for dismiss dialog (#3176)

* test: Added unit test cases for dismiss dialog

* added more test cases and fixed minor comments

---------

Co-authored-by: Devendra Singh Rana <devendra@Devendras-MacBook-Air.local>

* improve unit test coverage

---------

Co-authored-by: Devendra Singh Rana <devendra@Devendras-MacBook-Air.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Medium PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants