feat: Dismiss Dialog for duplicate expenses #3175
Conversation
devendrafyle
requested review from
Chethan-Fyle and
suyashpatil78
as code owners
| .dismiss-dialog { | ||
| &--header { | ||
| font-size: 16px; | ||
| line-height: 20.48px; |
| display: flex; | ||
| padding: 12px 16px; | ||
| justify-content: center; | ||
| color: #fff; |
| styleUrls: ['./dismiss-dialog.component.scss'], | ||
| }) | ||
| export class DismissDialogComponent implements OnInit { | ||
| // eslint-disable-next-line |
There was a problem hiding this comment.
fixed this by adding the observable type
|
|
||
| // eslint-disable-next-line |
There was a problem hiding this comment.
eslint throwing error here, else need to create new modal for it
There was a problem hiding this comment.
fixed this by creating new type in model file
| @@ -952,6 +952,17 @@ ion-modal.flag-unflag-modal { | |||
| padding-top: 0 !important; | |||
| } | |||
|
|
|||
| ion-popover.dismiss-dialog { | |||
| --width: 298px; | |||
There was a problem hiding this comment.
check this in different resolutions
There was a problem hiding this comment.
i have checked this, seems to working fine
src/theme/colors.scss
Outdated
| @@ -47,6 +47,7 @@ $shadow-lg: rgba(44, 48, 78, 0.1); | |||
|
|
|||
| $brand-primary: #ff3366 !default; | |||
| $brand-primary-light: #fe5196 !default; | |||
| $brand-gradient: linear-gradient(162deg, #f36 3.01%, #fe5196 111.5%); | |||
There was a problem hiding this comment.
this is not required, we already have $pink-gradient
There was a problem hiding this comment.
ahh right, will fix this
| font-size: 14px; | ||
| line-height: 18px; | ||
| color: $blue-black; | ||
| font-weight: 400; |
There was a problem hiding this comment.
This should be there by default, check if it's not required
There was a problem hiding this comment.
no, actually that is for different dialog, for this dismiss dialog we need to add this class styling since the color is different by default and we also want margin-top
| @@ -0,0 +1,3 @@ | |||
| import { Expense } from './expense.model'; | |||
|
|
|||
| export type Expenses = Expense[]; | |||
There was a problem hiding this comment.
don't we have this already?
There was a problem hiding this comment.
we do not have the exact model already, but we can skip this
* test: Added unit test cases for dismiss dialog * added more test cases and fixed minor comments --------- Co-authored-by: Devendra Singh Rana <devendra@Devendras-MacBook-Air.local>
|
* feat: Dismiss dialog for potential duplicate expenses * minor fixes * minor comment fixes * removed not required model * removed not used model file * test: Added unit test cases for dismiss dialog (#3176) * test: Added unit test cases for dismiss dialog * added more test cases and fixed minor comments --------- Co-authored-by: Devendra Singh Rana <devendra@Devendras-MacBook-Air.local> * improve unit test coverage --------- Co-authored-by: Devendra Singh Rana <devendra@Devendras-MacBook-Air.local>
Dismiss Dialog
Clickup
https://app.clickup.com/t/86cw6epah