Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coding standards, database standards, and performance pass #15

Open
wants to merge 81 commits into
base: 8.x-1.x
Choose a base branch
from
Open

Coding standards, database standards, and performance pass #15

wants to merge 81 commits into from

Commits on May 12, 2020

  1. column rename

    qadan committed May 12, 2020
    Configuration menu
    Copy the full SHA
    adec5f5 View commit details
    Browse the repository at this point in the history

  2. nodes as entities

    qadan committed May 12, 2020
    Configuration menu
    Copy the full SHA
    591a721 View commit details
    Browse the repository at this point in the history

  3. doesn't seem necessary

    qadan committed May 12, 2020
    Configuration menu
    Copy the full SHA
    bef8612 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2020

  1. return array

    qadan committed May 14, 2020
    Configuration menu
    Copy the full SHA
    01a721b View commit details
    Browse the repository at this point in the history

Commits on May 29, 2020

  1. more null vs array issues

    qadan committed May 29, 2020
    Configuration menu
    Copy the full SHA
    fb8127d View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. missing same level of precision on form

    qadan committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    a4ad7ab View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2020

  1. much simpler migration

    qadan committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    6041a19 View commit details
    Browse the repository at this point in the history

  2. replacing with safer insert query

    qadan committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    1dc3b3f View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. Merge pull request #1 from qadan/column_rename 

    column rename
    @adam-vessey
    adam-vessey authored Jun 22, 2020
    Configuration menu
    Copy the full SHA
    1bf7e10 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2 from qadan/node_entities 

    Node entities
    @adam-vessey
    adam-vessey authored Jun 22, 2020
    Configuration menu
    Copy the full SHA
    b472870 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #3 from qadan/null-check 

    Null check
    @adam-vessey
    adam-vessey authored Jun 22, 2020
    Configuration menu
    Copy the full SHA
    320a098 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2020

  1. update readme, fix issues

    qadan committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    202aefd View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2020

  1. fix logging

    qadan committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    469f4d2 View commit details
    Browse the repository at this point in the history

  2. issue with the form not having a preselected node

    qadan committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    5dca542 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2020

  1. closing brace

    qadan committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    1c61f42 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #5 from qadan/updates 

    update readme, fix issues
    @IAMlKeno
    IAMlKeno authored Jul 2, 2020
    Configuration menu
    Copy the full SHA
    f1598e4 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2020

  1. first pass at coding standards overhaul

    qadan committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    629095a View commit details
    Browse the repository at this point in the history

  2. some more cleanup, making configs work

    qadan committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    a094ceb View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2020

  1. all the little random translation and markup and injection issues

    qadan committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    007f968 View commit details
    Browse the repository at this point in the history

  2. and a host of fixes

    qadan committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    20181e8 View commit details
    Browse the repository at this point in the history

  3. and re-run coding standards

    qadan committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    7bbdddc View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2020

  1. nasty ksm hiding in there

    qadan committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    5c01fc6 View commit details
    Browse the repository at this point in the history

  2. null default

    qadan committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    d498679 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2020

  1. fixes for things

    qadan committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    e68defa View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. default for ranges query

    qadan committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    cefe830 View commit details
    Browse the repository at this point in the history

  2. random issues with random forms and random screens

    qadan committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    f3c9d00 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2020

  1. move some schema stuff, generate ids

    qadan committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    e85d1cb View commit details
    Browse the repository at this point in the history

  2. missing a thing

    qadan committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    19c563b View commit details
    Browse the repository at this point in the history

  3. Merge pull request #6 from qadan/coding-standards 

    first pass at coding standards overhaul
    @JojoVes
    JojoVes authored Jul 24, 2020
    Configuration menu
    Copy the full SHA
    f8a3714 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2020

  1. overhaul the redirect thingy

    qadan committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    966d91d View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2020

  1. Adding use statements to condition.

    @MorganDawe
    MorganDawe committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    eb9940c View commit details
    Browse the repository at this point in the history

  2. Merge pull request #8 from MorganDawe/8.x-ir-144 

    Adding use statements to condition.
    Daniel Aitken authored Jul 29, 2020
    Configuration menu
    Copy the full SHA
    44ed00a View commit details
    Browse the repository at this point in the history

  3. :Merge branch '8.x-1.x' of github.com:discoverygarden/embargoes into … 

    …8.x-1.x
    qadan committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    fff5ba1 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2020

  1. check contents of ranges

    qadan committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    beb7dc9 View commit details
    Browse the repository at this point in the history

  2. cast to array since cant be sure whats in the param

    qadan committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    149bcbd View commit details
    Browse the repository at this point in the history

  3. readme and licensing

    qadan committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    136824c View commit details
    Browse the repository at this point in the history

  4. log view

    qadan committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    12227da View commit details
    Browse the repository at this point in the history

  5. add field plugin

    qadan committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    d3253d0 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #7 from qadan/coding-standards 

    overhaul the redirect thingy
    @JojoVes
    JojoVes authored Jul 30, 2020
    Configuration menu
    Copy the full SHA
    d5d7785 View commit details
    Browse the repository at this point in the history

  7. Merge branch '8.x-1.x' of github.com:discoverygarden/embargoes into e… 

    …mbargoes-logs
    qadan committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    2a24e54 View commit details
    Browse the repository at this point in the history

  8. coding standards

    qadan committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    b69619d View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2020

  1. checking for actual entities before redirect

    qadan committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    1f23513 View commit details
    Browse the repository at this point in the history

  2. cache tags and contexts

    qadan committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    4e2dc29 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'entity-checks' of github.com:qadan/embargoes into embar… 

    …goes-logs
    qadan committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    b60890d View commit details
    Browse the repository at this point in the history

  4. cache tag all the things also fixes

    qadan committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    47ba163 View commit details
    Browse the repository at this point in the history

  5. more caching stuff

    qadan committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    0ac5e56 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2020

  1. Merge pull request #10 from qadan/entity-checks 

    checking for actual entities before redirect
    @jordandukart
    jordandukart authored Aug 4, 2020
    Configuration menu
    Copy the full SHA
    4569395 View commit details
    Browse the repository at this point in the history

  2. add the dang template, string stuff

    qadan committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    3b1e2a6 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2020

  1. fixing behaviour

    qadan committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    aae7232 View commit details
    Browse the repository at this point in the history

  2. repairs

    qadan committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    ad63c0a View commit details
    Browse the repository at this point in the history

  3. Merge pull request #9 from qadan/embargoes-logs 

    Embargoes logs
    @JojoVes
    JojoVes authored Aug 5, 2020
    Configuration menu
    Copy the full SHA
    1ff0ba0 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2020

  1. readme stuff

    qadan committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    d8ab1f0 View commit details
    Browse the repository at this point in the history

  2. check embargoed status on files

    qadan committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    d007dcd View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2020

  1. more updates

    qadan committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    ecc03dc View commit details
    Browse the repository at this point in the history

  2. merge conflicts

    qadan committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    a007625 View commit details
    Browse the repository at this point in the history

  3. check images

    qadan committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    fb1e8f1 View commit details
    Browse the repository at this point in the history

  4. entity config shenanigans in the background

    qadan committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    141b3ad View commit details
    Browse the repository at this point in the history

  5. coder fixes

    qadan committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    b9e773d View commit details
    Browse the repository at this point in the history

  6. Merge pull request #11 from qadan/behaviour-fixes 

    fixing behaviour
    @JojoVes
    JojoVes authored Aug 7, 2020
    Configuration menu
    Copy the full SHA
    c1718da View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. Adding new embargoes block.

    @MorganDawe
    MorganDawe committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    acb654c View commit details
    Browse the repository at this point in the history

  2. Merge branch '8.x-1.x' of github.com:discoverygarden/embargoes into 8… 

    ….x-1.x
    @MorganDawe
    MorganDawe committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    a7770c3 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2020

  1. Adding new embargoes notification block.

    @MorganDawe
    MorganDawe committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    41debf3 View commit details
    Browse the repository at this point in the history

  2. Bringing up to date with head.

    @MorganDawe
    MorganDawe committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    246a615 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2020

  1. fix issue of setting expiration date for indefinite embargoes 

    This can happen when switching something from scheduled to indefinite without manually clearing the expiration date before toggling the indefinite radio button in the form.
Wasn't breaking anything, but it made the embargoes page look misleading.
    @JojoVes
    JojoVes committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    e10507b View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2020

  1. make sure the contact message is added for nodes that don't have any … 

    …exempt users

before this change, if viewing an embargoed object that didn't have any exempt users, then the foreach loop wouldn't be run for the empty array and the message wouldn't be added.
    @JojoVes
    JojoVes committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    ab6cdcd View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. Merge pull request #12 from MorganDawe/8.x-ir-121 

    8.x ir 121
    Daniel Aitken authored Aug 31, 2020
    Configuration menu
    Copy the full SHA
    cd50724 View commit details
    Browse the repository at this point in the history

  2. update embargo admin permission

    qadan committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    a0054cd View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2020

  1. cache issue, fixing readmes

    qadan committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    a6ed5c0 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #13 from qadan/embargo-admin-permission 

    update embargo admin permission
    @IAMlKeno
    IAMlKeno authored Sep 1, 2020
    Configuration menu
    Copy the full SHA
    9472b82 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. fixing

    @lutaylor
    lutaylor committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    0f45848 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #14 from lutaylor/wmcupdate 

    fixing
    @adam-vessey
    adam-vessey authored Sep 21, 2020
    Configuration menu
    Copy the full SHA
    5da21b4 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2021

  1. empty nids array is returned if no relationships

    @nchiasson-dgi
    nchiasson-dgi committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    f1e924f View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2021

  1. Merge pull request #15 from nchiasson-dgi/8.x-1.x-return_empty_nids_a… 

    …rray

empty nids array is returned if no relationships
    @jordandukart
    jordandukart authored Jan 21, 2021
    Configuration menu
    Copy the full SHA
    3b6905b View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. D9 compat.

    @jordandukart
    jordandukart committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    ab1cbe2 View commit details
    Browse the repository at this point in the history

  2. Don't create entities when the IP range is invalid.

    @jordandukart
    jordandukart committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    005732d View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. Don't use messenger.

    @jordandukart
    jordandukart committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    5f6827d View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. Merge pull request #17 from jordandukart/8.x-1.x 

    D9 compat.
    @adam-vessey
    adam-vessey authored Mar 10, 2021
    Configuration menu
    Copy the full SHA
    e3da2d7 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2021

  1. Adding a default message for embargo notification block

    @IAMlKeno
    IAMlKeno committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    201a111 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2021

  1. Merge pull request #18 from IAMlKeno/dgi8-63 

    Adding a default message for embargo notification block
    @JojoVes
    JojoVes authored Jun 2, 2021
    Configuration menu
    Copy the full SHA
    bfaf078 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. Fix for missing entity configuration in Drupal 9 

    ```
Drupal\Core\Config\Schema\SchemaIncompleteException: Entity type 'Drupal\embargoes\Entity\EmbargoesEmbargoEntity' is missing 'config_export' definition in its annotation
```
    @nigelgbanks
    nigelgbanks committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    25892c8 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #19 from nigelgbanks/fixes-for-drupal-9 

    Fix for missing entity configuration in Drupal 9
    @jordandukart
    jordandukart authored Jun 21, 2021
    Configuration menu
    Copy the full SHA
    40f23eb View commit details
    Browse the repository at this point in the history