Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a default message for embargo notification block #18

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

IAMlKeno
Copy link

@IAMlKeno IAMlKeno commented Jun 1, 2021

As the embargoes module provides a notification message block.

By default the contact email is null and the message embargo_notification_message is excluded. When rendered, Drupal attempts to provide translatable markup. As null on embargo_notification_message is not a string, drupal return the following error message. Let's just provide a generic message.

InvalidArgumentException: $string ("") must be a string. in Drupal\Core\StringTranslation\TranslatableMarkup->__construct() (line 132 of /opt/www/drupal/core/lib/Drupal/Core/StringTranslation/TranslatableMarkup.php).

@JojoVes JojoVes merged commit bfaf078 into discoverygarden:8.x-1.x Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants