Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release-docs TOKEN_GITHUB to GITHUB_TOKEN #2802

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

Thorium
Copy link
Member

@Thorium Thorium commented Aug 9, 2024

Fix release yaml docs token

Co-authored-by: Andrii Chebukin <XperiAndri@Outlook.com>
@Thorium
Copy link
Member Author

Thorium commented Aug 9, 2024

Integration test failed but I expect it's nothing to do with this commit, they are just bit un-reliable, addressed at #2797 .

@xperiandri xperiandri merged commit f07f74d into fsprojects:master Aug 13, 2024
1 of 3 checks passed
@xperiandri
Copy link
Collaborator

remote: Support for password authentication was removed on August 13, 2021.
remote: Please see https://docs.github.com/get-started/getting-started-with-git/about-remote-repositories#cloning-with-https-urls for information on currently recommended modes of authentication.

@Thorium
Copy link
Member Author

Thorium commented Aug 14, 2024

Ok so it gets further than before, that's good news!

The messages you pasted are just informational messages. It is doing token auth, not password auth.
I think what goes wrong is this:

image

Authentication failed

So CI is using that user to try to push the release-docs, but the token is for some other user?

@Numpsy
Copy link
Contributor

Numpsy commented Aug 19, 2024

At a risk of not having a clue what I'm doing (never used gh-pages) - an observation -

The build script at

FAKE/build.fsx

Line 997 in f07f74d

let auth = sprintf "%s:x-oauth-basic@" githubToken.Value
uses x-oauth-basic when building the URL, but looking at the code for some github pages publishing actions, e.g. https://github.com/peaceiris/actions-gh-pages/blob/0b7567fde6f7517edcc13d8ffa2d89cd8734d47c/src/set-tokens.ts#L100, I see them using x-access-token instead.
Is that something that needs reviewing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants