SdkAssemblyResolver improvements #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt to collect all versions and evaluate the selection later.
xperiandri
reviewed
Aug 6, 2024
xperiandri
reviewed
Aug 7, 2024
xperiandri
approved these changes
Aug 7, 2024
|
I would prefer release pipeline to be fixed and run to completion before we merge new fixes |
|
This one may actually help the pipeline. :-) |
|
For now the issue is that pushing the same version of the package to NuGet does not skip it but fails |
|
That's intentional I guess, NuGet packages cannot be updated. |
xperiandri
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It still seems we have unreliable integration tests.
I still blame the SdkAssemblyResolver not being able to pick proper .NET versions.
There were some "try finds" which just took first ever found version, and I think it should rather collect a list of versions to make the decision of proper version later.
Also added verbosity to intergration-test-log so we could better see what goes wrong, if something goes wrong.