Fix FromAsCasing warnings in container files #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
frobware
commented
Aug 1, 2024
frobware
commented
- Update Konflux references to v0.2
- Makefile: gracefully handle kubectl delete
- ** remove BASE_IMAGES_DIGESTS refernce since its no longer supported**
- chore(deps): update konflux references
- fix OOM because of watching configmap resource
- chore(deps): update konflux references
- bpfman-operator: Add test helper for BpfmanConfigReconciler setup
- bpfman-operator: Refactor TestBpfmanConfigReconcileAndDelete for OpenShift
- chore(deps): update konflux references
- chore(deps): update konflux references
- chore(deps): update konflux references to 3806116
- Red Hat Konflux update bpfman-operator-bundle Signed-off-by: red-hat-konflux konflux@no-reply.konflux-ci.dev
- fix the docker file setting
- chore(deps): update konflux references
- chore(deps): update konflux references
- remove BASE_IMAGES to fix bundle pull and push flows
- chore(deps): update konflux references
- chore(deps): update konflux references
- chore(deps): update konflux references to f93024e
- bpfman-agent: don't try to unload bpf program that isn't loaded
- Add konflux catalog file to bpfman operator component Signed-off-by: Mohamed Mahmoud mmahmoud@redhat.com
- Red Hat Konflux update bpfman-operator-catalog Signed-off-by: red-hat-konflux konflux@no-reply.konflux-ci.dev
- Handle deletes of BpfPrograms for BpfApplications
- add bpfman-operator-catalog folder
- remove older API fields
- chore(deps): update konflux references
- Fix FromAsCasing warnings in container files
Signed-off-by: red-hat-konflux <123456+red-hat-konflux[bot]@users.noreply.github.com>
Modify `undeploy` and `catalog-undeploy` targets in the Makefile to include the `--ignore-not-found` flag when deleting resources. This ensures that resource deletion commands do not error out when resources are already absent. This follows the existing pattern for handling non-existent resources in `kubectl delete` calls throughout the Makefile. Signed-off-by: Andrew McDermott <amcdermo@redhat.com>
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
…eferences Update Konflux references to v0.2
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
chore(deps): update konflux references
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
chore(deps): update konflux references
Fix OOM because of watching configmap resource
…-if-not-found Makefile: gracefully handle kubectl delete
Introduce a new test helper function `setupTestEnvironment` to standardise the setup process for BpfmanConfigReconciler tests. This function handles the initialisation of the fake client, the registration of necessary types with the runtime scheme, and the configuration of the reconciler. The helper enables specific OpenShift testing by conditionally setting the RestrictedSCC field on the reconciler object. The logic is taken from the existing TestBpfmanConfigReconcileAndDelete function. The previous setup logic duplicated paths to various YAML files by pre-pending ../../. This new setup function dispenses with the duplicated paths by using the constants declared in the internal package and resolves the path at runtime to the actual files in the filesystem relative to the test directory. This allows us to refer to the canonical path without having to duplicate it, ensuring that if we ever change the filename then the test code doesn't need to be updated. This commit allows us to share the test setup logic so that we can subsequently modify TestBpfmanConfigReconcileAndDelete to verify that the Restricted SCC is created in the OpenShift test case, which was previously not tested. Signed-off-by: Andrew McDermott <amcdermo@redhat.com>
…Shift Refactor the TestBpfmanConfigReconcileAndDelete function to use a table-driven approach, enabling testing for both standard and OpenShift environments. This change introduces testing for OpenShift by verifying that the Restricted Security Context Constraints (SCC) is created and configured correctly when the isOpenShift flag is true. Additionally, this test identified that the Restricted SCC was not being deleted during the reconciliation process. The reconciler function has been updated to address this omission, ensuring proper cleanup of resources in the OpenShift case. The refactored test uses the new setupTestEnvironment helper function to standardise the setup process. Signed-off-by: Andrew McDermott <amcdermo@redhat.com>
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
chore(deps): update konflux references
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
chore(deps): update konflux references
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
chore(deps): update konflux references to 3806116
Signed-off-by: red-hat-konflux <konflux@no-reply.konflux-ci.dev>
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
…ndle Red Hat Konflux update bpfman-operator-bundle
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
chore(deps): update konflux references
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
chore(deps): update konflux references
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
chore(deps): update konflux references
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
chore(deps): update konflux references to f93024e
Fixes: bpfman#74 Signed-off-by: Andre Fredette <afredette@redhat.com>
bpfman-agent: don't try to unload bpf program that isn't loaded
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
Konflux catalog
Signed-off-by: red-hat-konflux <konflux@no-reply.konflux-ci.dev>
When BpfPrograms are deleted by unLoadAndDeleteBpfProgramsList(), the relevant controller needs to know that the programs are being deleted so it can update the global status correctly. This change updates the status to bpfmaniov1alpha1.BpfProgCondUnloaded before deleting the program object, which makes it work more like the delete case of reconcileBpfProgram(). Signed-off-by: Andre Fredette <afredette@redhat.com>
Handle deletes of BpfPrograms for BpfApplications
…c-deployment Update TestBpfmanConfigReconcileAndDelete unit test to verify that the OpenShift SCC is deployed
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
…talog Red Hat Konflux update bpfman-operator-catalog
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
chore(deps): update konflux references
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
chore(deps): update konflux references
This commit addresses the FromAsCasing warnings issued by Docker during the build process by ensuring that 'as' is converted to 'AS' in the FROM directives. Warnings observed: - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 5) Reference: https://docs.docker.com/reference/build-checks/from-as-casing/ Signed-off-by: Andrew McDermott <amcdermo@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.