Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OOM because of watching configmap resource #62

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Jul 23, 2024

Fix #56 reproduce steps are also doc in the issue

  • before the fix
 oom-kill:constraint=CONSTRAINT_MEMCG,nodemask=(null),cpuset=cri-containerd-499c6676bdf79e4157b694d4730d50eec01501a8c4faea1395a1fc62e2d52b73.scope,mems_allowed=0,oom_memcg=/system.slice/docker-113354b7db17a99a283c23fa84fb21b639ee29a2ec5a747c7f7c033a5e19b39f.scope/kubelet.slice/kubelet-kubepods.slice/kubelet-kubepods-burstable.slice/kubelet-kubepods-burstable-podfd0578d2_fe8d_4c8d_ba5f_20c00dede626.slice/cri-containerd-499c6676bdf79e4157b694d4730d50eec01501a8c4faea1395a1fc62e2d52b73.scope,task_memcg=/system.slice/docker-113354b7db17a99a283c23fa84fb21b639ee29a2ec5a747c7f7c033a5e19b39f.scope/kubelet.slice/kubelet-kubepods.slice/kubelet-kubepods-burstable.slice/kubelet-kubepods-burstable-podfd0578d2_fe8d_4c8d_ba5f_20c00dede626.slice/cri-containerd-499c6676bdf79e4157b694d4730d50eec01501a8c4faea1395a1fc62e2d52b73.scope,task=bpfman-operator,pid=2304220,uid=65532
[534829.056623] Memory cgroup out of memory: Killed process 2304220 (bpfman-operator) total-vm:1398540kB, anon-rss:129324kB, file-rss:26880kB, shmem-rss:0kB, UID:65532 pgtables:440kB oom_score_adj:998
  • After the fix
   PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND                                                            
2272755 65532     20   0 1267076  39652  28032 S   0.3   0.1   0:02.86 bpfman-operator      

Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
@msherif1234 msherif1234 changed the title Fix cache Fix OOM because of watching configmap resource Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 27.36%. Comparing base (4d90ded) to head (f823b05).
Report is 1 commits behind head on main.

Files Patch % Lines
cmd/bpfman-operator/main.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   27.39%   27.36%   -0.03%     
==========================================
  Files          81       81              
  Lines        6968     6975       +7     
==========================================
  Hits         1909     1909              
- Misses       4873     4880       +7     
  Partials      186      186              
Flag Coverage Δ
unittests 27.36% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msherif1234 msherif1234 requested a review from anfredette July 24, 2024 11:53
Copy link
Contributor

@anfredette anfredette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 9ec4c4e into bpfman:main Jul 24, 2024
16 checks passed
msherif1234 pushed a commit to msherif1234/bpfman-operator that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce operator memory consumption (OOMKilled)
2 participants