sse-multiplexd.c: fix leaking pipe FDs #259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sse-multiplexd leaks pipe FDs to its child processes, so newer children keep the older ones alive when they should have received a SIGPIPE already fixes freifunk-gluon/gluon#2468
|
Thanks - I couldn't edit the commit message of your PR, so I had to open a new one: #260 |
|
Ah, okay, editing doesn't seem possible if the PR comes from an org account. Good to know. Either way, i'm happy if the issue get's resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sse-multiplexd leaks pipe FDs to its child processes, so newer children keep the older ones alive when they should have received a SIGPIPE already
fixes freifunk-gluon/gluon#2468
@NeoRaider I don't really know what to write as a commit message, you are very welcome to open a PR yourself, edit this one or whatever. My intention is just to get the fix upstream. In today's FFRN nightly I had already patched it in, but of course I would like to get rid of the downstream patch quickly.