Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status Page: multiple data collection processes #2468

Closed
herbetom opened this issue Apr 12, 2022 · 3 comments · Fixed by freifunk-gluon/packages#260 or #2572
Closed

Status Page: multiple data collection processes #2468

herbetom opened this issue Apr 12, 2022 · 3 comments · Fixed by freifunk-gluon/packages#260 or #2572
Assignees
@neocturne
Labels
0. type: bug This is a bug 1. severity: blocker This issue/pr is required for the next release 9. meta: known issue Known issue which should be mentioned in release notes
Milestone
2022.1

Comments

@herbetom
Copy link
Contributor

Bug report

What is the problem?

It can happen that Status Page data collection runs multiple times:

gluon-neighbour-info -s  -l -d ::1 -p 1001 -t 3 -r statistics
/lib/gluon/status-page/providers/stations mesh1
/lib/gluon/status-page/providers/neighbours-batadv

Screenshot-htop

It can be reproduced by opening multiple tabs of the status page. But it can also happen with just a single tab and some Browser foo.

The processes seem to accumulate and eventually all memory is used and there is a reboot.

Gluon Version:
Seen on Gluon master Branch for quite some time (quite possibly since the bump to 21.03). No reports regarding the last v2021.1.1 release.

Reports from the following devices:

  • ath79:
    • EAP225-Outdoor (128 MB RAM)
    • WS-AP3610 (128 MB RAM)
  • ramips-mt7621:
    • Mi Router 4A Gigabit Edition (128 MB RAM)
@neocturne neocturne self-assigned this Apr 12, 2022
@neocturne neocturne added 0. type: bug This is a bug 1. severity: blocker This issue/pr is required for the next release labels Apr 12, 2022
@AiyionPrime
Copy link
Member

I think I reproduced the behavior on an or750i on the current master.

@AiyionPrime
Copy link
Member

@herbetom and I met online sunday and dug into this issue.
I do not have a device to test further for now, but tested some commits:

This is the current log in case someone wants to take this further:

git bisect start
# bad: [ae7b87b0f0da02e658ee6ea3a910bef3afb2168d] Merge pull request #2520 from freifunk-gluon/check-updater-branch
git bisect bad ae7b87b0f0da02e658ee6ea3a910bef3afb2168d
# bad: [36f406746e88e40ed9b61ae43e99702216970f23] gluon-status-page: fix mesh-vpn section for wg (#2502)
git bisect bad 36f406746e88e40ed9b61ae43e99702216970f23
# good: [a5e085b57c02fe75b3b831719217e8f0efd22bd5] ramips-mt7621: add Xiaomi Mi Router 4A (Gigabit Edition)
git bisect good a5e085b57c02fe75b3b831719217e8f0efd22bd5
# good: [0db3c58329ec17ee09ab2abe1b821c55369512a4] modules: update OpenWrt base
git bisect good 0db3c58329ec17ee09ab2abe1b821c55369512a4

On both 'bad' commits I was able to have processes gradually building up, which should not happen.

We did so by having chromium run in background and waited for over an hour or so until it started to happen.

Testing 'good' commits is unfeasible on such a small scale, I think.
Especially since for 'good' commits the bug has just not shown "yet".

Eitherway, just wanted to leave this here, maybe we can go through options later.

@rotanid rotanid added the 9. meta: known issue Known issue which should be mentioned in release notes label Jun 14, 2022
@rotanid rotanid added this to the 2022.1 milestone Jun 26, 2022
herbetom pushed a commit to Freifunk-Rhein-Neckar/packages that referenced this issue Jun 27, 2022
@neocturne @herbetom
sse-multiplexd.c: fix leaking pipe FDs
a4003e6 
sse-multiplexd leaks pipe FDs to its child processes, so newer children keep
the older ones alive when they should have received a SIGPIPE already

fixes freifunk-gluon/gluon#2468
herbetom pushed a commit to Freifunk-Rhein-Neckar/packages that referenced this issue Jun 27, 2022
@neocturne @herbetom
sse-multiplexd.c: fix leaking pipe FDs
12fbaf2 
sse-multiplexd leaks pipe FDs to its child processes, so newer children keep
the older ones alive when they should have received a SIGPIPE already

fixes freifunk-gluon/gluon#2468
@herbetom herbetom mentioned this issue Jun 27, 2022
Closed
neocturne added a commit to freifunk-gluon/packages that referenced this issue Jul 2, 2022
@neocturne
sse-multiplex: fix pipe FD leaks
e944405 
sse-multiplexd leaked pipe FDs to its child processes, so newer children
keep the older ones alive when they should have received a SIGPIPE already.

Closes freifunk-gluon/gluon#2468
neocturne added a commit to freifunk-gluon/packages that referenced this issue Jul 2, 2022
@neocturne
sse-multiplex: fix pipe FD leaks
a2ba87e 
sse-multiplexd leaked pipe FDs to its child processes, so newer children
kept the older ones alive when they should have received a SIGPIPE already.

Closes freifunk-gluon/gluon#2468
@neocturne neocturne mentioned this issue Jul 2, 2022
Merged
rotanid pushed a commit to freifunk-gluon/packages that referenced this issue Jul 3, 2022
@neocturne @rotanid
sse-multiplex: fix pipe FD leaks
04d2b6f 
sse-multiplexd leaked pipe FDs to its child processes, so newer children
kept the older ones alive when they should have received a SIGPIPE already.

Closes freifunk-gluon/gluon#2468
@rotanid
Copy link
Member

rotanid commented Jul 3, 2022 •
edited
Loading

reopen until packages repo got bumped in the modules file

#2572

@rotanid rotanid reopened this Jul 3, 2022
@rotanid rotanid mentioned this issue Jul 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neocturne neocturne

Labels
0. type: bug This is a bug 1. severity: blocker This issue/pr is required for the next release 9. meta: known issue Known issue which should be mentioned in release notes
Projects
None yet
Milestone
2022.1
4 participants
@neocturne @rotanid @AiyionPrime @herbetom