fix: specify precision for net_amount (backport #39481)

[mergify]

Continuation of #38141
Removed optional grand total adjustment functionality, rather it is always adjusted for inclusive taxes.

---

This is an automatic backport of pull request #39481 done by Mergify.

[mergify]

Cherry-pick of 50d56db has failed:

On branch mergify/bp/version-14-hotfix/pr-39481
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit 50d56db0c2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   erpnext/accounts/doctype/accounts_settings/accounts_settings.json
	modified:   erpnext/accounts/doctype/pos_invoice/test_pos_invoice.py
	modified:   erpnext/accounts/doctype/pos_invoice_merge_log/test_pos_invoice_merge_log.py
	modified:   erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py
	modified:   erpnext/controllers/taxes_and_totals.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/public/js/controllers/accounts.js
	both modified:   erpnext/public/js/controllers/taxes_and_totals.js

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[ruthra-kumar]

UI broken

[ruthra-kumar]

UI broken

Fixed

[ruthra-kumar]

@rtdany10
2 test cases, test_rounding_adjustment and test_sales_invoice_discount_amount, which were not failing on the original PR is failing here.

Could you take a look?

[rtdany10]

@ruthra-kumar
The test case test_sales_invoice_discount_amount has wrong assertion.
On develop, it asserts against 0 as grand total itself is an integer and requires on rounding

In v14, the asserting is for -0.01 while the grand total is an integer.

But apparently grand_total assertion is failing here. I guess we should correct the test case either way

[rtdany10]

We will have to correct both the test cases.

I believe this can be attributed to the change in rounding functionality between the versions, 14 and develop. 15 and onwards uses "Banker's Rounding" while 14 uses "Banker's Rounding (legacy)"

[rtdany10]

I do not have write access to this branch, can you correct the test cases please? @ruthra-kumar

[ruthra-kumar]

@rtdany10 Merged

[frappe-pr-bot]

🎉 This issue has been resolved in version 14.73.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀