Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specify precision for net_amount #38141

Closed
wants to merge 14 commits into from

Conversation

rtdany10
Copy link
Contributor

@rtdany10 rtdany10 commented Nov 17, 2023

Solves #38137

But what about older invoices?
@ruthra-kumar @deepeshgarg007


Update:

Introduces a new option in Accounts Settings:
image

Users can optionally opt in to forcefully match total and grand total for inclusive rates, the difference would be booked against round off account then.

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Nov 17, 2023
@rtdany10
Copy link
Contributor Author

Please backport to v14 and v13 as well

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9903049) 67.26% compared to head (aa735fe) 67.27%.
Report is 692 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #38141      +/-   ##
===========================================
+ Coverage    67.26%   67.27%   +0.01%     
===========================================
  Files          757      757              
  Lines        60505    60515      +10     
===========================================
+ Hits         40700    40714      +14     
+ Misses       19805    19801       -4     
Files Coverage Δ
erpnext/controllers/taxes_and_totals.py 94.85% <76.92%> (-0.46%) ⬇️

... and 4 files with indirect coverage changes

@rtdany10 rtdany10 marked this pull request as ready for review November 20, 2023 07:38
bosue

This comment was marked as resolved.

@bosue

This comment was marked as resolved.

@rtdany10
Copy link
Contributor Author

Nice. Still I‘d feel a bit easier if we do backport both setting and logic, but don‘t enable it pre-dev, so don‘t change expectations. Am I wrong?

It has been enabled by default so far, hence the patch to set it to True 😅

@rtdany10
Copy link
Contributor Author

1 similar comment
@rtdany10
Copy link
Contributor Author

rtdany10 commented Dec 2, 2023

Copy link
Member

@deepeshgarg007 deepeshgarg007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rtdany10 I don't think this should be an opt-in settings, for a non multi-currency invoice the net total and the base net total should always match. We should by default handle this scenario and not do this on basis of some setting.

@rtdany10
Copy link
Contributor Author

rtdany10 commented Dec 2, 2023

@rtdany10 I don't think this should be an opt-in settings, for a non multi-currency invoice the net total and the base net total should always match. We should by default handle this scenario and not do this on basis of some setting.

@deepeshgarg007 the opt-in is for another feature, where in grand total is adjusted to match with net total for inclusive taxes. The net total and base net total are always made equal after this PR.

@rtdany10
Copy link
Contributor Author

@deepeshgarg007

Copy link

stale bot commented Dec 30, 2023

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Dec 30, 2023
@rtdany10
Copy link
Contributor Author

rtdany10 commented Jan 1, 2024

@deepeshgarg007

@stale stale bot removed the inactive label Jan 1, 2024
Copy link

stale bot commented Jan 17, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Jan 17, 2024
@rtdany10
Copy link
Contributor Author

@stale stale bot closed this Jan 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts inactive needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants