-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: specify precision for net_amount #38141
Conversation
Please backport to v14 and v13 as well |
3088071
to
46b5b2c
Compare
46b5b2c
to
f5c0032
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #38141 +/- ##
===========================================
+ Coverage 67.26% 67.27% +0.01%
===========================================
Files 757 757
Lines 60505 60515 +10
===========================================
+ Hits 40700 40714 +14
+ Misses 19805 19801 -4
|
…es-register-total
3b2caae
to
6072a54
Compare
erpnext/accounts/doctype/accounts_settings/accounts_settings.json
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
It has been enabled by default so far, hence the patch to set it to True 😅 |
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rtdany10 I don't think this should be an opt-in settings, for a non multi-currency invoice the net total and the base net total should always match. We should by default handle this scenario and not do this on basis of some setting.
@deepeshgarg007 the opt-in is for another feature, where in grand total is adjusted to match with net total for inclusive taxes. The net total and base net total are always made equal after this PR. |
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
Solves #38137
But what about older invoices?
@ruthra-kumar @deepeshgarg007
Update:
Introduces a new option in Accounts Settings:
Users can optionally opt in to forcefully match total and grand total for inclusive rates, the difference would be booked against round off account then.