Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dynamic condition in the pricing rule not working (backport #42467) (backport #42495) #42496

Merged
merged 1 commit into from
Jul 27, 2024
Merged

fix: dynamic condition in the pricing rule not working (backport #42467) (backport #42495) #42496

merged 1 commit into from
Jul 27, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 27, 2024

Create a pricing rule with dynamic condition as net_total > 1000 and create SO for 100 then still pricing rule applied

This is an automatic backport of pull request #42467 done by Mergify.
This is an automatic backport of pull request #42495 done by Mergify.

@mergify
fix: dynamic condition in the pricing rule not working (backport #42467…
fdc2d61 
…) (#42495)

fix: dynamic condition in the pricing rule not working (#42467)

(cherry picked from commit 0e817f4)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
(cherry picked from commit ac2ef21)
@mergify mergify bot mentioned this pull request Jul 27, 2024
Merged
@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. stock labels Jul 27, 2024
@rohitwaghchaure rohitwaghchaure merged commit 334c4d0 into version-15 Jul 27, 2024
12 checks passed
@rohitwaghchaure rohitwaghchaure deleted the mergify/bp/version-15/pr-42495 branch July 27, 2024 05:37
frappe-pr-bot pushed a commit that referenced this pull request Jul 27, 2024
@frappe-bot
chore(release): Bumped to Version 15.31.2
4b66fca 
## [15.31.2](v15.31.1...v15.31.2) (2024-07-27)

### Bug Fixes

* dynamic condition in the pricing rule not working (backport [#42467](#42467)) (backport [#42495](#42495)) ([#42496](#42496)) ([334c4d0](334c4d0))
@frappe-pr-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 15.31.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

@s-aga-r s-aga-r Awaiting requested review from s-aga-r s-aga-r is a code owner

Assignees
No one assigned
Labels
needs-tests This PR needs automated unit-tests. released stock
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frappe-pr-bot @rohitwaghchaure