fix: dynamic condition in the pricing rule not working #42467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitwaghchaure
added
backport version-15-hotfix
and removed
backport version-15-hotfix
needs-tests
|
@Mergifyio backport version-15-hotfix |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 27, 2024
(cherry picked from commit 0e817f4)
rohitwaghchaure
added a commit
that referenced
this pull request
Jul 27, 2024
rohitwaghchaure
pushed a commit
that referenced
this pull request
Jul 27, 2024
…) (backport #42495) (#42496) fix: dynamic condition in the pricing rule not working (backport #42467) (#42495) fix: dynamic condition in the pricing rule not working (#42467) (cherry picked from commit 0e817f4) Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com> (cherry picked from commit ac2ef21) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jul 27, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
(cherry picked from commit 0e817f4)
rohitwaghchaure
added a commit
that referenced
this pull request
Jul 30, 2024
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
## [14.70.13](v14.70.12...v14.70.13) (2024-07-31) ### Bug Fixes * builtins.KeyError: ('ABC', 'Store - CP') (backport [#42505](#42505)) ([#42508](#42508)) ([0256c64](0256c64)) * consider payment entries for checking if tds is deducted ([e7432fc](e7432fc)) * dynamic condition in the pricing rule not working (backport [#42467](#42467)) ([#42543](#42543)) ([53034c3](53034c3)) * **gross profit:** incorrect valuation rate on different warehouses ([1a7efbb](1a7efbb)) * ignore duplicates while creating default templates ([99bc8e8](99bc8e8)) * incorrect cost_center on AR/AP report ([0e2abbd](0e2abbd)) * keep status as In Progress for RIV for Timeout Error (backport [#42274](#42274)) ([#42504](#42504)) ([8e8d0c7](8e8d0c7)) * parenttype in item wise purchase and sales register ([97f2e88](97f2e88)) * performance issue for the report Purchase Order Analysis report (backport [#42503](#42503)) ([#42506](#42506)) ([f42f1bb](f42f1bb)) * price_list_currency not found error (backport [#42534](#42534)) ([#42538](#42538)) ([3ba6f40](3ba6f40)) * warehouse filter in Product Bundle Balance (backport [#42532](#42532)) ([#42536](#42536)) ([0441984](0441984))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
## [15.31.3](v15.31.2...v15.31.3) (2024-07-31) ### Bug Fixes * Adjust initial month's depreciation to end of depreciation period ([9d2ef4d](9d2ef4d)) * builtins.KeyError: ('ABC', 'Store - CP') (backport [#42505](#42505)) ([#42509](#42509)) ([f25b38c](f25b38c)) * consider payment entries for checking if tds is deducted ([183ac41](183ac41)) * dynamic condition in the pricing rule not working (backport [#42467](#42467)) ([#42495](#42495)) ([ac2ef21](ac2ef21)) * field_type is small text for v15 ([9e99eda](9e99eda)) * fields alteration related to subcontracting ([80d4dc2](80d4dc2)) * Fields Modification for Subcontracting DocTypes ([#42383](#42383)) ([422824b](422824b)) * ignore duplicates while creating default templates ([aea8271](aea8271)) * incorrect cost_center on AR/AP report ([0c2e948](0c2e948)) * incorrect current qty for the batch in stock reco (backport [#42434](#42434)) ([#42459](#42459)) ([298a569](298a569)) * keyerror posting_time (backport [#42452](#42452)) ([#42460](#42460)) ([2d2140a](2d2140a)) * not able to save BOM Creator ([#42540](#42540)) ([61280e6](61280e6)) * parenttype in item wise purchase and sales register ([322fbe9](322fbe9)) * performance issue for the report Purchase Order Analysis report (backport [#42503](#42503)) ([#42507](#42507)) ([edf1fcb](edf1fcb)) * price_list_currency not found error (backport [#42534](#42534)) ([#42539](#42539)) ([5fa185d](5fa185d)) * purchase return from rejected warehouse (backport [#42531](#42531)) ([#42535](#42535)) ([b7d70ac](b7d70ac)) * set pos data if not return doc ([25fe08e](25fe08e)) * **tests:** added tests for usecase ([1390c86](1390c86)) * warehouse filter in Product Bundle Balance (backport [#42532](#42532)) ([#42537](#42537)) ([826577c](826577c)) * Warranty Expiry Date not set in the serial number (backport [#42513](#42513)) ([#42515](#42515)) ([fc0db19](fc0db19)) ### Performance Improvements * huge number of serial no creation (backport [#42522](#42522)) ([#42544](#42544)) ([6840f6c](6840f6c))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a pricing rule with dynamic condition as net_total > 1000 and create SO for 100 then still pricing rule applied