chore: remove cmake minium version deprecation warning

This commit ensure that the cmake minimum version < 3.5 deprecation warning is no longer thrown. The minimum cmake version was updated to 3.10 as this is the version that is recommended by the [ROS noetic migration guide](https://wiki.ros.org/noetic/Migration#Increase_required_CMake_version_to_avoid_author_warning).
frankaemika · Sep 1, 2023 · 73d954d · 73d954d
1 parent 30dc6b8
commit 73d954d
Show file tree

Hide file tree

Showing 11 changed files with 43 additions and 10 deletions.
diff --git a/franka_control/CMakeLists.txt b/franka_control/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.4)
+cmake_minimum_required(VERSION 3.10)
 project(franka_control)
 
 set(CMAKE_CXX_STANDARD 14)

diff --git a/franka_description/CMakeLists.txt b/franka_description/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.4)
+cmake_minimum_required(VERSION 3.10)
 project(franka_description)
 
 find_package(catkin REQUIRED)

diff --git a/franka_example_controllers/CMakeLists.txt b/franka_example_controllers/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.4)
+cmake_minimum_required(VERSION 3.10)
 project(franka_example_controllers)
 
 set(CMAKE_BUILD_TYPE Release)
@@ -159,4 +159,4 @@ include(${CMAKE_CURRENT_LIST_DIR}/../cmake/PepTools.cmake OPTIONAL
 if(PEP_TOOLS)
   file(GLOB_RECURSE PYSOURCES ${CMAKE_CURRENT_SOURCE_DIR}/scripts/*.py)
   add_pyformat_target(franka_control FILES ${PYSOURCES})
-endif()
+endif()
diff --git a/franka_gazebo/CMakeLists.txt b/franka_gazebo/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.4)
+cmake_minimum_required(VERSION 3.10)
 project(franka_gazebo)
 
 execute_process(COMMAND uname -m

diff --git a/franka_gazebo/models/ambient_sun/model.config b/franka_gazebo/models/ambient_sun/model.config
@@ -0,0 +1,16 @@
+<?xml version="1.0"?>
+
+<model>
+  <name>Ambient sun</name>
+  <version>1.0</version>
+  <sdf version="1.5">model.sdf</sdf>
+
+  <author>
+    <name>Nate Koenig</name>
+    <email>nate@osrfoundation.org</email>
+  </author>
+
+  <description>
+    A ambient light for the sun.
+  </description>
+</model>
diff --git a/franka_gazebo/models/ambient_sun/model.sdf b/franka_gazebo/models/ambient_sun/model.sdf
@@ -0,0 +1,17 @@
+<?xml version="1.0" ?>
+<sdf version="1.5">
+  <light type="directional" name="ambient">
+    <cast_shadows>true</cast_shadows>
+    <pose>0 0 10 0 0 0</pose>
+    <diffuse>0.8 0.8 0.8 1</diffuse>
+    <specular>0.2 0.2 0.2 1</specular>
+    <ambient>0.4 0.4 0.4 1</ambient>
+    <attenuation>
+      <range>1000</range>
+      <constant>0.9</constant>
+      <linear>0.01</linear>
+      <quadratic>0.001</quadratic>
+    </attenuation>
+    <direction>-0.5 0.1 -0.9</direction>
+  </light>
+</sdf>
diff --git a/franka_gripper/CMakeLists.txt b/franka_gripper/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.4)
+cmake_minimum_required(VERSION 3.10)
 project(franka_gripper)
 
 set(CMAKE_CXX_STANDARD 14)

diff --git a/franka_hw/CMakeLists.txt b/franka_hw/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.4)
+cmake_minimum_required(VERSION 3.10)
 project(franka_hw)
 
 set(CMAKE_CXX_STANDARD 14)

diff --git a/franka_msgs/CMakeLists.txt b/franka_msgs/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.4)
+cmake_minimum_required(VERSION 3.10)
 project(franka_msgs)
 
 find_package(catkin REQUIRED COMPONENTS message_generation std_msgs actionlib_msgs)

diff --git a/franka_ros/CMakeLists.txt b/franka_ros/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.1.3)
+cmake_minimum_required(VERSION 2.8.3)
 project(franka_ros)
 find_package(catkin REQUIRED)
 catkin_metapackage()
diff --git a/franka_visualization/CMakeLists.txt b/franka_visualization/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.4)
+cmake_minimum_required(VERSION 3.10)
 project(franka_visualization)
 
 set(CMAKE_CXX_STANDARD 14)