Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve week1 homework based on feedback in #62 #64

Merged
merged 4 commits into from
Sep 8, 2019

Conversation

hvariant
Copy link
Contributor

@hvariant hvariant commented Sep 6, 2019

No description provided.

Copy link
Member

@shineli1984 shineli1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

doubleEveryOtherRev (x : y : xs) = (x : 2 * y : doubleEveryOtherRev xs)

doubleEveryOther :: [Integer] -> [Integer]
doubleEveryOther = reverse . doubleEveryOtherRev . reverse
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
doubleEveryOther = reverse . doubleEveryOtherRev . reverse
doubleEveryOther = doubleEveryOtherRev . reverse

@shineli1984 shineli1984 merged commit 4a6248b into fp-works:master Sep 8, 2019
stevemao added a commit that referenced this pull request Sep 8, 2019
* master:
  Week2 fix (#72)
  Week 5 ex 1 with updates to Parser and StackVM (#68)
  Week3 (#66)
  improve skips in week3 ex 1 (#69)
  steve week 5 (#63)
  Week2 (#65)
  Improve week1 homework based on feedback in #62 (#64)
  Week1 (#62)
  Daniel M Week 4 (#61)
  Exercise 3: More folds! (#60)
  Week 4 Ex 2,3 (#58)
cht8687 added a commit to cht8687/2019-winter-Haskell-school that referenced this pull request Sep 9, 2019
* upstream/master:
  Week 5 ex 2 to 6 (fp-works#76)
  week 5: use applicative and composition styles (fp-works#75)
  W5steve (fp-works#73)
  Week5 (fp-works#71)
  fix symbol alignment style (fp-works#74)
  Week2 fix (fp-works#72)
  Week 5 ex 1 with updates to Parser and StackVM (fp-works#68)
  Week3 (fp-works#66)
  improve skips in week3 ex 1 (fp-works#69)
  steve week 5 (fp-works#63)
  Week2 (fp-works#65)
  Improve week1 homework based on feedback in fp-works#62 (fp-works#64)
@hvariant hvariant deleted the week1-fix branch September 12, 2019 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants