Week1 #62
Merged
Week1 #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also switched to using Test.Hspec.
shineli1984
approved these changes
Sep 6, 2019
| padList (x:xs) = (x:0:padList xs) | ||
|
|
||
| doubleEveryOther :: [Integer] -> [Integer] | ||
| doubleEveryOther = reverse . doubleEveryOtherRev . reverse |
There was a problem hiding this comment.
Given we are going to sum the digits after double every other digits from the right, do we need to reverse the list back?
There was a problem hiding this comment.
Hmm, if the only goal is to finish validate, then I suppose there is no point in reversing the list back. For the sake of this exercise though, if the list is returned in reverse it doesn't satisfy the requirements.
|
I'll merge this for now and if you want to address the comments, you can create another PR. |
shineli1984
pushed a commit
that referenced
this pull request
Sep 8, 2019
cht8687
added a commit
to cht8687/2019-winter-Haskell-school
that referenced
this pull request
Sep 9, 2019
* upstream/master: Week1 (fp-works#62) Daniel M Week 4 (fp-works#61) Exercise 3: More folds! (fp-works#60) Week 4 Ex 2,3 (fp-works#58) init week5 week4 ex 2,3,4 (fp-works#54) Wei Ning - CIS194 Week4 Homework (fp-works#59) [Week4]: Task1 (fp-works#56) Daniel M Week 3 (fp-works#57) Week 3 Ex 3 + Week 4 Ex 1 (fp-works#55) Task2 (fp-works#50)
cht8687
added a commit
to cht8687/2019-winter-Haskell-school
that referenced
this pull request
Sep 9, 2019
* upstream/master: Week 5 ex 2 to 6 (fp-works#76) week 5: use applicative and composition styles (fp-works#75) W5steve (fp-works#73) Week5 (fp-works#71) fix symbol alignment style (fp-works#74) Week2 fix (fp-works#72) Week 5 ex 1 with updates to Parser and StackVM (fp-works#68) Week3 (fp-works#66) improve skips in week3 ex 1 (fp-works#69) steve week 5 (fp-works#63) Week2 (fp-works#65) Improve week1 homework based on feedback in fp-works#62 (fp-works#64)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
latecomer catching up with homework