@mcap/support: remove .d.ts file in favor of module augmentation in source file #1318
+13
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defunctzombie
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
@mcap/support: Fixed a TS error from an import that did not work in the published package
Docs
None
Description
Supersedes / closes #1300
See also protobufjs/protobuf.js#1499
This area of TypeScript arcana is confusing, but I don't think there is anything about module augmentations that requires them to be in a
.d.tsfile.The way it's currently done was generally working, except as pointed out in #1300 we didn't include the
typingsdir in the published package.I believe we didn't run into this problem in our own code because we usually turn on
"skipLibCheck": true.