fix: add typings to package output

[dnikitop]

Changelog

Docs

Description

Getting these errors in when importing

node_modules/@mcap/support/dist/esm/src/protobufDescriptors.d.ts:1:22 - error TS6053: File '/home/dimitri/src/rosbags2js/node_modules/@mcap/support/typings/protobufjs.d.ts' not found.

1 /// <reference path="../../../typings/protobufjs.d.ts" />
                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@mcap/support/dist/esm/src/protobufDescriptors.d.ts:3:61 - error TS2339: Property 'toDescriptor' does not exist on type 'Root'.

3 export type ProtobufDescriptor = ReturnType<protobufjs.Root["toDescriptor"]>;                                       

PR adds typings/protobufjs.d.ts to package

Before	After

[jtbandes]

What were you importing that caused this error? I've never seen this before.

[dnikitop]

What were you importing that caused this error? I've never seen this before.

Create a new package that imports this.
Importing

import { parse as parseMessageDefinition } from "@foxglove/rosmsg";
import {
  LazyMessageReader as ROS1LazyMessageReader,
  Time,
} from "@foxglove/rosmsg-serialization";
import { MessageReader as ROS2MessageReader } from "@foxglove/rosmsg2-serialization";
import { McapStreamReader, McapTypes } from "@mcap/core";
import { loadDecompressHandlers } from "@mcap/support";
import { createReadStream } from "fs";
import { isEqual } from "lodash";
import { performance } from "perf_hooks";
import protobufjs from "protobufjs";
import { FileDescriptorSet } from "protobufjs/ext/descriptor";

Using this tsconfig

{
  "compilerOptions": {
    "module": "commonjs",
    "esModuleInterop": true,
    "target": "es2020",
    "moduleResolution": "node",
    "sourceMap": true,
    "outDir": "dist",
    "lib": ["es2020"]
  }
}

[dnikitop]

@jtbandes any updates on this?

I can create sample repo trying to import the mcap packages to show the issue

[amacneil]

Replaced by #1318